helm/chart-testing
1
0
Fork 0
mirror of https://github.com/helm/chart-testing.git synced 2026-02-05 09:45:14 +01:00
Code Issues Activity

Fix readiness check (#57)

Browse Source 
Readiness check should happen before tests are executed. Otherwise
the fails if there are tests and test pods match the label selectors
that identify pods. Since test pods have status Completed, they
cause the readiness check to fail.

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
This commit is contained in:
Reinhard Nägele
2018-11-16 13:53:53 +01:00
committed by GitHub
parent b1c8894732
commit 739aa607a8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/tool/helm.go
View File

@@ -68,11 +68,11 @@ func (h Helm) InstallWithValues(chart string, valuesFile string, namespace strin
return err
}
if err := h.exec.RunProcess("helm", "test", release, h.extraArgs); err != nil {
if err := h.kubectl.WaitForDeployments(namespace); err != nil {
return err
}
return h.kubectl.WaitForDeployments(namespace)
return h.exec.RunProcess("helm", "test", release, h.extraArgs)
}
func (h Helm) DeleteRelease(release string) {