From 739aa607a8264b14f71468db204ca8756fa61fdc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Reinhard=20N=C3=A4gele?= <unguiculus@gmail.com>
Date: Fri, 16 Nov 2018 13:53:53 +0100
Subject: [PATCH] Fix readiness check (#57)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Readiness check should happen before tests are executed. Otherwise
the fails if there are tests and test pods match the label selectors
that identify pods. Since test pods have status Completed, they
cause the readiness check to fail.

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
---
 pkg/tool/helm.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pkg/tool/helm.go b/pkg/tool/helm.go
index b949f99..6a2b236 100644
--- a/pkg/tool/helm.go
+++ b/pkg/tool/helm.go
@@ -68,11 +68,11 @@ func (h Helm) InstallWithValues(chart string, valuesFile string, namespace strin
 		return err
 	}
 
-	if err := h.exec.RunProcess("helm", "test", release, h.extraArgs); err != nil {
+	if err := h.kubectl.WaitForDeployments(namespace); err != nil {
 		return err
 	}
 
-	return h.kubectl.WaitForDeployments(namespace)
+	return h.exec.RunProcess("helm", "test", release, h.extraArgs)
 }
 
 func (h Helm) DeleteRelease(release string) {