siderolabs/kres
1
0
Fork 0
mirror of https://github.com/siderolabs/kres.git synced 2026-02-05 09:45:35 +01:00
Code Issues Activity

fix: disable nolintlint linter

Browse Source 
It gives false positives, failing CI runs - see https://github.com/golangci/golangci-lint/issues/3228#issuecomment-2796615846.

Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
This commit is contained in:
Utku Ozdemir
2025-05-05 12:32:54 +02:00
parent 6cbcbd12b6
commit 1a0156b3cd
2 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
.golangci.yml
View File

@@ -1,6 +1,6 @@
# THIS FILE WAS AUTOMATICALLY GENERATED, PLEASE DO NOT EDIT.
#
# Generated on 2025-04-14T12:32:42Z by kres d903dae-dirty.
# Generated on 2025-05-05T10:34:00Z by kres be6d3a6a.
version: "2"
@@ -48,6 +48,7 @@ linters:
- protogetter # complains about us using Value field on typed spec, instead of GetValue which has a different signature
- perfsprint # complains about us using fmt.Sprintf in non-performance critical code, updating just kres took too long
- musttag # seems to be broken - goes into imported libraries and reports issues there
- nolintlint # gives false positives - disable until https://github.com/golangci/golangci-lint/issues/3228 is resolved
# all available settings of specific linters
settings:
cyclop:
@@ -89,11 +90,6 @@ linters:
simple: true
range-loops: true # Report preallocation suggestions on range loops, true by default
for-loops: false # Report preallocation suggestions on for loops, false by default
nolintlint:
allow-unused: false
allow-no-explanation: [ ]
require-explanation: false
require-specific: true
rowserrcheck: { }
testpackage: { }
unparam:

6
internal/output/golangci/golangci.yml
View File

@@ -44,6 +44,7 @@ linters:
- protogetter # complains about us using Value field on typed spec, instead of GetValue which has a different signature
- perfsprint # complains about us using fmt.Sprintf in non-performance critical code, updating just kres took too long
- musttag # seems to be broken - goes into imported libraries and reports issues there
- nolintlint # gives false positives - disable until https://github.com/golangci/golangci-lint/issues/3228 is resolved
# all available settings of specific linters
settings:
cyclop:
@@ -85,11 +86,6 @@ linters:
simple: true
range-loops: true # Report preallocation suggestions on range loops, true by default
for-loops: false # Report preallocation suggestions on for loops, false by default
nolintlint:
allow-unused: false
allow-no-explanation: [ ]
require-explanation: false
require-specific: true
rowserrcheck: { }
testpackage: { }
unparam: