mirror of
https://github.com/openshift/source-to-image.git
synced 2026-02-05 12:44:54 +01:00
return error if pull fails
This commit is contained in:
@@ -182,13 +182,8 @@ func PullImage(name string, d Docker, policy api.PullPolicy, force bool) (*PullR
|
||||
switch policy {
|
||||
case api.PullIfNotPresent:
|
||||
image, err = d.CheckAndPullImage(name)
|
||||
return &PullResult{Image: image, OnBuild: d.IsImageOnBuild(name)}, err
|
||||
case api.PullAlways:
|
||||
image, err = d.PullImage(name)
|
||||
if err == nil {
|
||||
return &PullResult{Image: image, OnBuild: d.IsImageOnBuild(name)}, nil
|
||||
}
|
||||
fallthrough
|
||||
case api.PullNever:
|
||||
image, err = d.CheckImage(name)
|
||||
}
|
||||
|
||||
@@ -447,13 +447,14 @@ func (i *integrationTest) exerciseIncrementalBuild(tag, imageName string, remove
|
||||
|
||||
previousImageID := resp.ImageID
|
||||
config = &api.Config{
|
||||
DockerConfig: dockerConfig(),
|
||||
BuilderImage: imageName,
|
||||
BuilderPullPolicy: api.DefaultBuilderPullPolicy,
|
||||
Source: TestSource,
|
||||
Tag: tag,
|
||||
Incremental: true,
|
||||
RemovePreviousImage: removePreviousImage,
|
||||
DockerConfig: dockerConfig(),
|
||||
BuilderImage: imageName,
|
||||
BuilderPullPolicy: api.DefaultBuilderPullPolicy,
|
||||
Source: TestSource,
|
||||
Tag: tag,
|
||||
Incremental: true,
|
||||
RemovePreviousImage: removePreviousImage,
|
||||
PreviousImagePullPolicy: api.PullIfNotPresent,
|
||||
}
|
||||
|
||||
builder, err = strategies.GetStrategy(config)
|
||||
@@ -480,7 +481,7 @@ func (i *integrationTest) exerciseIncrementalBuild(tag, imageName string, remove
|
||||
}
|
||||
} else {
|
||||
if err != nil {
|
||||
t.Errorf("Coudln't find previous image %s", previousImageID)
|
||||
t.Errorf("Couldn't find previous image %s", previousImageID)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user