1
0
mirror of https://github.com/openshift/installer.git synced 2026-02-05 15:47:14 +01:00

OCPBUGS-5234: azurestack: upi: fix compute scale up

Scaling up a compute machineset will fail in AzureStack UPI with:

```
Message:               failed to create vm $clusterID-worker-mtcazs-2gjsl: failure sending request for machine $clusterID-worker-mtcazs-2gjsl: cannot create vm: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=404 -- Original Error: Code="NotFound" Message="The Availability Set '/subscriptions/$subID/resourceGroups/$clusterID-rg/providers/Microsoft.Compute/availabilitySets/$clusterID-cluster' cannot be found."
```

because machinesets follow the IPI pattern of using "$clusterID-cluster"
as the availabilitySet's name, whereas UPI uses "$clusterID-avset". So
let's change UPI to be consistent with IPI.

Another inconsistence is the RHCOS image name: UPI appends "-image" to
the name whereas IPI just uses the "$clusterID".
This commit is contained in:
Rafael Fonseca
2023-01-03 16:03:13 +01:00
parent 1d972a809c
commit cb94a4aede
5 changed files with 8 additions and 8 deletions

View File

@@ -18,7 +18,7 @@
},
"variables" : {
"location" : "[resourceGroup().location]",
"imageName" : "[concat(parameters('baseName'), '-image')]"
"imageName" : "[parameters('baseName')]"
},
"resources" : [
{

View File

@@ -20,7 +20,7 @@
"masterPublicIpAddressID" : "[resourceId('Microsoft.Network/publicIPAddresses', variables('masterPublicIpAddressName'))]",
"masterLoadBalancerName" : "[concat(parameters('baseName'))]",
"masterLoadBalancerID" : "[resourceId('Microsoft.Network/loadBalancers', variables('masterLoadBalancerName'))]",
"masterAvailabilitySetName" : "[concat(parameters('baseName'), '-avset')]",
"masterAvailabilitySetName" : "[concat(parameters('baseName'), '-cluster')]",
"internalLoadBalancerName" : "[concat(parameters('baseName'), '-internal')]",
"internalLoadBalancerID" : "[resourceId('Microsoft.Network/loadBalancers', variables('internalLoadBalancerName'))]",
"skuName": "Basic"

View File

@@ -40,12 +40,12 @@
"masterSubnetName" : "[concat(parameters('baseName'), '-master-subnet')]",
"masterSubnetRef" : "[concat(variables('virtualNetworkID'), '/subnets/', variables('masterSubnetName'))]",
"masterLoadBalancerName" : "[concat(parameters('baseName'))]",
"masterAvailabilitySetName" : "[concat(parameters('baseName'), '-avset')]",
"masterAvailabilitySetName" : "[concat(parameters('baseName'), '-cluster')]",
"internalLoadBalancerName" : "[concat(parameters('baseName'), '-internal')]",
"sshKeyPath" : "/home/core/.ssh/authorized_keys",
"vmName" : "[concat(parameters('baseName'), '-bootstrap')]",
"nicName" : "[concat(variables('vmName'), '-nic')]",
"imageName" : "[concat(parameters('baseName'), '-image')]",
"imageName" : "[parameters('baseName')]",
"clusterNsgName" : "[concat(parameters('baseName'), '-nsg')]",
"sshPublicIpAddressName" : "[concat(variables('vmName'), '-ssh-pip')]"
},

View File

@@ -46,11 +46,11 @@
"masterSubnetName" : "[concat(parameters('baseName'), '-master-subnet')]",
"masterSubnetRef" : "[concat(variables('virtualNetworkID'), '/subnets/', variables('masterSubnetName'))]",
"masterLoadBalancerName" : "[concat(parameters('baseName'))]",
"masterAvailabilitySetName" : "[concat(parameters('baseName'), '-avset')]",
"masterAvailabilitySetName" : "[concat(parameters('baseName'), '-cluster')]",
"internalLoadBalancerName" : "[concat(parameters('baseName'), '-internal')]",
"sshKeyPath" : "/home/core/.ssh/authorized_keys",
"clusterNsgName" : "[concat(parameters('baseName'), '-nsg')]",
"imageName" : "[concat(parameters('baseName'), '-image')]",
"imageName" : "[parameters('baseName')]",
"numberOfMasters" : 3,
"vms" : {
"copy" : [

View File

@@ -50,8 +50,8 @@
"infraLoadBalancerName" : "[parameters('baseName')]",
"sshKeyPath" : "/home/core/.ssh/authorized_keys",
"identityName" : "[concat(parameters('baseName'), '-identity')]",
"imageName" : "[concat(parameters('baseName'), '-image')]",
"masterAvailabilitySetName" : "[concat(parameters('baseName'), '-avset')]",
"imageName" : "[parameters('baseName')]",
"masterAvailabilitySetName" : "[concat(parameters('baseName'), '-cluster')]",
"numberOfNodes" : "[parameters('numberOfNodes')]",
"vms" : {
"copy" : [