openshift/installer
1
0
Fork 0
mirror of https://github.com/openshift/installer.git synced 2026-02-05 15:47:14 +01:00
Code Issues Releases Activity

no-jira: Fix logging and error messages

Browse Source 
asset/installconfig/gcp:
** Tech Debt.
** Clean up error message and log messages.
This commit is contained in:
barbacbd
2025-08-28 15:01:43 -04:00
parent 5f4e6cdd11
commit cb35883f01
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/asset/installconfig/gcp/validation.go
View File

@@ -445,9 +445,9 @@ func ValidatePrivateDNSZone(client API, ic *types.InstallConfig) field.ErrorList
for _, paramSet := range params {
zone, err := client.GetDNSZoneFromParams(context.TODO(), paramSet)
if err != nil {
logrus.Debug("No private DNS Zone found")
if IsNotFound(err) {
// Ignore the not found error, because the zone will be created in this instance.
logrus.Debug("No private DNS Zone found")
continue
}
return append(allErrs, field.Invalid(field.NewPath("baseDomain"), ic.BaseDomain, err.Error()))
@@ -459,7 +459,7 @@ func ValidatePrivateDNSZone(client API, ic *types.InstallConfig) field.ErrorList
allErrs = append(allErrs, field.Invalid(
field.NewPath("platform").Child("gcp").Child("dns").Child("privateZone").Child("name"),
zoneName,
fmt.Sprintf("found existing private zone %s in project %s with base domain %s", zone.Name, project, ic.BaseDomain),
fmt.Sprintf("found existing private zone %s in project %s with DNS name %s", zone.Name, project, zone.DnsName),
))
} else if err := checkRecordSets(client, ic, project, zone, []string{apiRecordType(ic), apiIntRecordName(ic)}); err != nil {
allErrs = append(allErrs, err)