openshift/installer
1
0
Fork 0
mirror of https://github.com/openshift/installer.git synced 2026-02-05 06:46:36 +01:00
Code Issues Releases Activity

tests: add unit tests for IPv6 networking validations

Browse Source
This commit is contained in:
Thuan Vo
2026-01-19 14:11:55 -08:00
parent 3a2f742642
commit adfe5e7b4a
1 changed files with 58 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
pkg/asset/installconfig/aws/validation_test.go
View File

@@ -22,6 +22,7 @@ import (
"github.com/openshift/installer/pkg/ipnet"
"github.com/openshift/installer/pkg/types"
"github.com/openshift/installer/pkg/types/aws"
"github.com/openshift/installer/pkg/types/network"
)
var (
@@ -155,6 +156,37 @@ func TestValidate(t *testing.T) {
},
expectErr: `^compute\[1\].architecture: Invalid value: "arm64": all compute machine pools must be of the same architecture$`,
},
{
name: "valid dual-stack with IPv6 supporting instance types",
installConfig: icBuild.build(icBuild.withInstanceType("m5.xlarge", "m5.xlarge", "m5.large"), icBuild.withIPFamily(network.DualStackIPv4Primary)),
availRegions: validAvailRegions(),
availZones: validAvailZones(),
instanceTypes: validInstanceTypes(),
},
{
name: "invalid dual-stack control plane instance type does not support IPv6",
installConfig: icBuild.build(icBuild.withInstanceType("m5.xlarge", "m1.xlarge", "m5.large"), icBuild.withIPFamily(network.DualStackIPv4Primary)),
availRegions: validAvailRegions(),
availZones: validAvailZones(),
instanceTypes: validInstanceTypes(),
expectErr: `controlPlane\.platform\.aws\.type: Invalid value: "m1\.xlarge": instance type m1\.xlarge does not support IPv6 networking`,
},
{
name: "invalid dual-stack compute instance type does not support IPv6",
installConfig: icBuild.build(icBuild.withInstanceType("m5.xlarge", "m5.xlarge", "m1.xlarge"), icBuild.withIPFamily(network.DualStackIPv4Primary)),
availRegions: validAvailRegions(),
availZones: validAvailZones(),
instanceTypes: validInstanceTypes(),
expectErr: `compute\[0\]\.platform\.aws\.type: Invalid value: "m1\.xlarge": instance type m1\.xlarge does not support IPv6 networking`,
},
{
name: "invalid dual-stack default machine platform instance types do not support IPv6",
installConfig: icBuild.build(icBuild.withInstanceType("m1.xlarge", "", ""), icBuild.withIPFamily(network.DualStackIPv6Primary)),
availRegions: validAvailRegions(),
availZones: validAvailZones(),
instanceTypes: validInstanceTypes(),
expectErr: `controlPlane\.platform\.aws\.type: Invalid value: "m1\.xlarge": instance type m1\.xlarge does not support IPv6 networking.*compute\[0\]\.platform\.aws\.type: Invalid value: "m1\.xlarge": instance type m1\.xlarge does not support IPv6 networking`,
},
{
name: "invalid edge pool, missing zones",
installConfig: icBuild.build(
@@ -1761,21 +1793,41 @@ func validInstanceTypes() map[string]InstanceType {
DefaultVCpus: 1,
MemInMiB: 2048,
Arches: []string{ec2.ArchitectureTypeX8664},
Networking: Networking{
IPv6Supported: true,
},
},
"m5.large": {
DefaultVCpus: 2,
MemInMiB: 8192,
Arches: []string{ec2.ArchitectureTypeX8664},
Networking: Networking{
IPv6Supported: true,
},
},
"m5.xlarge": {
DefaultVCpus: 4,
MemInMiB: 16384,
Arches: []string{ec2.ArchitectureTypeX8664},
Networking: Networking{
IPv6Supported: true,
},
},
"m6g.xlarge": {
DefaultVCpus: 4,
MemInMiB: 16384,
Arches: []string{ec2.ArchitectureTypeArm64},
Networking: Networking{
IPv6Supported: true,
},
},
"m1.xlarge": {
DefaultVCpus: 4,
MemInMiB: 15360,
Arches: []string{ec2.ArchitectureTypeX8664},
Networking: Networking{
IPv6Supported: false,
},
},
}
}
@@ -2025,3 +2077,9 @@ func (icBuild icBuildForAWS) withPublicIPv4Pool(publicIPv4Pool string) icOption
ic.Platform.AWS.PublicIpv4Pool = publicIPv4Pool
}
}
func (icBuild icBuildForAWS) withIPFamily(ipFamily network.IPFamily) icOption {
return func(ic *types.InstallConfig) {
ic.Platform.AWS.IPFamily = ipFamily
}
}