openshift/installer
1
0
Fork 0
mirror of https://github.com/openshift/installer.git synced 2026-02-05 15:47:14 +01:00
Code Issues Releases Activity

aws/permissions: add VPC permissions unit tests.

Browse Source
This commit is contained in:
Rafael Fonseca
2024-07-11 16:43:52 +02:00
committed by openshift-cherrypick-robot
parent f9f7c355b7
commit 6bc545aa0d
1 changed files with 69 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
pkg/asset/installconfig/aws/permissions_test.go
View File

@@ -411,3 +411,72 @@ func TestKMSKeyPermissions(t *testing.T) {
})
})
}
func TestVPCPermissions(t *testing.T) {
t.Run("Should include", func(t *testing.T) {
t.Run("create network permissions when VPC not specified", func(t *testing.T) {
t.Run("for standard regions", func(t *testing.T) {
ic := validInstallConfig()
ic.AWS.Subnets = nil
ic.AWS.HostedZone = ""
requiredPerms := RequiredPermissionGroups(ic)
assert.Contains(t, requiredPerms, PermissionCreateNetworking)
})
t.Run("for secret regions", func(t *testing.T) {
ic := validInstallConfig()
ic.AWS.Region = "us-iso-east-1"
ic.AWS.Subnets = nil
ic.AWS.HostedZone = ""
requiredPerms := RequiredPermissionGroups(ic)
assert.Contains(t, requiredPerms, PermissionCreateNetworking)
})
})
t.Run("delete network permissions when VPC not specified for standard region", func(t *testing.T) {
ic := validInstallConfig()
ic.AWS.Subnets = nil
ic.AWS.HostedZone = ""
requiredPerms := RequiredPermissionGroups(ic)
assert.Contains(t, requiredPerms, PermissionDeleteNetworking)
})
t.Run("delete shared network permissions when VPC specified for standard region", func(t *testing.T) {
ic := validInstallConfig()
requiredPerms := RequiredPermissionGroups(ic)
assert.Contains(t, requiredPerms, PermissionDeleteSharedNetworking)
})
})
t.Run("Should not include", func(t *testing.T) {
t.Run("create network permissions when VPC specified", func(t *testing.T) {
ic := validInstallConfig()
requiredPerms := RequiredPermissionGroups(ic)
assert.NotContains(t, requiredPerms, PermissionCreateNetworking)
})
t.Run("delete network permissions", func(t *testing.T) {
t.Run("when VPC specified", func(t *testing.T) {
ic := validInstallConfig()
requiredPerms := RequiredPermissionGroups(ic)
assert.NotContains(t, requiredPerms, PermissionDeleteNetworking)
})
t.Run("on secret regions", func(t *testing.T) {
ic := validInstallConfig()
ic.AWS.Region = "us-iso-east-1"
requiredPerms := RequiredPermissionGroups(ic)
assert.NotContains(t, requiredPerms, PermissionDeleteNetworking)
})
})
t.Run("delete shared network permissions", func(t *testing.T) {
t.Run("when VPC not specified", func(t *testing.T) {
ic := validInstallConfig()
ic.AWS.Subnets = nil
ic.AWS.HostedZone = ""
requiredPerms := RequiredPermissionGroups(ic)
assert.NotContains(t, requiredPerms, PermissionDeleteSharedNetworking)
})
t.Run("on secret regions", func(t *testing.T) {
ic := validInstallConfig()
ic.AWS.Region = "us-iso-east-1"
requiredPerms := RequiredPermissionGroups(ic)
assert.NotContains(t, requiredPerms, PermissionDeleteSharedNetworking)
})
})
})
}