1
0
mirror of https://github.com/openshift/installer.git synced 2026-02-05 15:47:14 +01:00

close a verify-codegen ci failure loophole

if the go codegen commands failed, the the hack/verify-codegen.sh script
continued and the CI check passed. see #5406 for an example. the script
was not set to fail on a non-zero return code. this pr adds the bash e
option to the set builtin to catch errors and exit on failure.

Signed-off-by: Christy Norman <christy@linux.vnet.ibm.com>
This commit is contained in:
Christy Norman
2021-12-02 13:42:22 -06:00
parent 8bb07f0448
commit 421e1e20c6

View File

@@ -1,10 +1,11 @@
#!/bin/sh
if [ "$IS_CONTAINER" != "" ]; then
set -x
set -xe
go generate ./pkg/types/installconfig.go
go generate ./pkg/rhcos/ami.go
set +x
# See https://github.com/openshift/installer/pull/5447#discussion_r762340594
# go generate ./pkg/rhcos/ami.go
set +ex
git diff --exit-code
else
podman run --rm \