Through a5276ae (Merge pull request #929 from
giuseppe/add-more-implementations, 2017-10-23).
There have also been a few non-spec changes which I have not
documented in the ChangeLog:
13b4639 .pullapprove.yml: Switch to v2 and other project-template
updates (#902)
f6f2514 README: Make meetings monthly (were weekly) (#910)
e27acdd implementations: Replace "cc-oci-runtime" with "cc-runtime"
(#922)
ec4cc47 implementations: add crun (#929)
d4990d1 implementations: add bwrap-oci (#929)
8a16f08 .mailmap: Consolidate James' entries (#924)
Signed-off-by: W. Trevor King <wking@tremily.us>
The old language is from 72cbff67 (config-linux.md: clearly require
absolute path for namespace, 2017-03-10, #720), but without RFC 2119
language in the absolute path wording, it's not a compliance
requirement (per spec.md's "compliant" definition). This commit
adjusts the language to bring it in line with our current wording for
maskedPaths and readonlyPaths, which we've had since 25f44dd0 (
config-linux: fix format and definitely require value of masked and
readonly paths, 2016-09-30, #587).
Signed-off-by: W. Trevor King <wking@tremily.us>
The latter is much more common:
$ git --no-pager grep -ic "process in the container" origin/master -- *.md
origin/master:runtime.md:1
$ git --no-pager grep -ic "container process" origin/master -- *.md
origin/master:config-linux.md:4
origin/master:config.md:2
origin/master:glossary.md:1
origin/master:runtime.md:5
Signed-off-by: W. Trevor King <wking@tremily.us>
Catching up with 56eb6a1 (modify procfs to proc, 2017-07-28, #905),
because it's strange to change one link label from "procfs" -> "proc"
but leave the other. This will also make it marginally easier to
collapse these to a single link label once we convert the spec to a
single Markdown file [1].
[1]: https://groups.google.com/a/opencontainers.org/d/msg/dev/1Wwd_MEzSjI/DsCkR-UwAgAJ
Subject: [runtime-spec] Hosting 1.0 HTML on opencontainers.org and
timing for transition to single-page Markdown
Date: Thu, 27 Jul 2017 16:23:40 -0700
Message-ID: <20170727232340.GA24408@valgrind.tremily.us>
Signed-off-by: W. Trevor King <wking@tremily.us>
The capitalization in "Container Configuration file" (which we've used
since 70372d38, *.md: update TOC and links, 2015-09-10, #176) was
halfway between "Title Case" and "Sentence case". The current spec
isn't particularly consistent (e.g. we have both "Specification
version" and "POSIX-platform Mounts"), but the ToC has used
"Configuration" for this file since e7be40f0 (Cleanup the spec a bit
to remove WG/git text that's not really part of the spec, 2016-11-14,
#626) so dodge the sentence/title issue and use that here too.
Signed-off-by: W. Trevor King <wking@tremily.us>
It's backed by memory.oom_control, so this commit moves it in with
the rest of the memory-controller config.
Looking at the history, the initial request landing a setting for this
in the Docker/OCI ecosystem seems to be [1], which added
Cgroup.OomKillDisable. That commit was carried from libcontainer into
runC [2] where it is now Resources.OomKillDisable [3]. From runC it
was carried into this repo (with some renaming) in [4]. Subsequent
early doc updates landed in [5,6]. In none of those can I find
discussion about why the setting is not already under memory. I
expect the reason is that the runC structures are flat, so "under
memory" is not a thing there. But in this spec, resources has
per-controller sub-properties. The fact that disableOOMKiller
belonged to the memory controller may have been overlooked in [4] and
never revisited until now.
[1]: https://github.com/docker/libcontainer/pull/417
Subject: cgroups: add support for oom control
[2]: 295c70865d
Subject: cgroups: add support for oom control
[3]: https://github.com/opencontainers/runc/blob/v1.0.0-rc3/libcontainer/configs/cgroup_unix.go#L113-L114
[4]: https://github.com/opencontainers/runtime-spec/pull/51
Subject: Add Go types for specification
[5]: https://github.com/opencontainers/runtime-spec/pull/137
Subject: Adding cgroups path to the Spec.
[6]: https://github.com/opencontainers/runtime-spec/pull/199
Subject: runtime: config: linux: add cgroups informations
Signed-off-by: W. Trevor King <wking@tremily.us>
Through f4d221c (Merge pull request #880 from
dqminh/wking-linux-only-capabilities-again, 2017-07-05). The rc6
release picked up an earlier version of these notes, and those entries
are mostly unchanged except for:
* The credentialSpec entry, which was #814 for credentialspec and now
also includes #859 for credentialSpec.
* The root(.path) Hyper-V entry, which was #820 for root.path and now
also includes #838 for root. I also moved this into the "breaking
changes" section, because rc5 Hyper-V configs required root to be
set, and rc6 Hyper-V configs require it to not be set. Although
whether rc5 allowed Hyper-V configs at all is not clear to me.
* Fixed indenting for the typo-fixes entry, as well as a number of
more recent typo-fix PRs.
Signed-off-by: W. Trevor King <wking@tremily.us>
