Currently, `helm-extra-set-args` is only available as a command-line
flag, despite being part of the config object. This does not appear to
be documented.
This changes sources the value `extraSetArgs` via the `config` object
rather than the cmd.Flags() only.
Signed-off-by: Dylan Arbour <arbourd@users.noreply.github.com>
* feat: verify if targetBranch is present in git repo
If a targetBranch is not present in the git repository the `ct list-changed` command will fail.
The error message for this is not really meaningful.
This commit will validate if the branch exists and throw a error message which the user will understand.
closes #330
Signed-off-by: Marco Lecheler <marco@task.media>
* chore(test): mocking test for chart.BranchExists()
Signed-off-by: Marco Lecheler <marco@task.media>
* fix(lint): use fmt.Errorf for error msg
Signed-off-by: Marco Lecheler <marco@task.media>
---------
Signed-off-by: Marco Lecheler <marco@task.media>
* feat: add kubectl timeout value to configuration
Signed-off-by: Scott Leggett <scott@sl.id.au>
* fix: set a request timeout on kubectl commands
Simple kubectl commands such as get, describe, and logs should return
quickly, but kubectl does not set a timeout on requests by default.
This can mean kubectl hangs forever if the kubernetes API stops
responding during a request, which is quite possible in CI environments
where jobs may cancelled and kubernetes clusters torn down while ct is
running.
This change sets a configurable timeout on such kubectl commands, with a
default value of 30s.
Signed-off-by: Scott Leggett <scott@sl.id.au>
* chore: update integration test for new kubectl API
Signed-off-by: Scott Leggett <scott@sl.id.au>
* fix(test): deploment was not installing due to missing selector
Signed-off-by: paologallinaharbur <paologallina1992@gmail.com>
* feat(test): tesi if chart is upgraded and error is triggered
Signed-off-by: paologallinaharbur <paologallina1992@gmail.com>
* update projecto to go 1.17x
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
* add syft to generate the sboms and update goreleaser
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
* add dependabot config
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
* update dokcerfile to fetch the correct binaries for the arch and update base image
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
If directories are deleted from a chart, ct detects them as invalid
chart directories. A log message is printed to stdout which messes up
the regular output. In order to fix this, the message is now logged to
stderr.
*Example:*
```
$ ct list-changed
Directory 'charts/mychart/templates/deleted' is not a valid chart directory. Skipping...
charts/mychart
```
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
* support execution of additional commands for lint
Given that helm unittest is installed locally or mounted into the chart
testing container one could use this to run helm unittest for each
chart.
```
additional-commands:
- helm unittest --helm3 -f tests/*.yaml {{ .Path }}
```
The command is treated as a go template. Like this it's possible to get
the path to the chart as in the example. It would also be open for
further extension if needed.
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
* Use sh to execute command
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Co-authored-by: Reinhard Nägele <unguiculus@gmail.com>
* rename function to NewCmdTemplateExecutor
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
* add error handling
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
* add documentation
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
* use go-shellwords to split rendered command
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
* Update pkg/tool/cmdexecutor.go
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Co-authored-by: Reinhard Nägele <unguiculus@gmail.com>
* add unit tests
Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Co-authored-by: Reinhard Nägele <unguiculus@gmail.com>
Adding support for Helm 3 introduced creating namespaces
because Helm does not do this automatically anymore.
However, a regression was introduced that always creates
namespaces, even if a dedicated namespace is provided via
CLI flag.
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Fix statefulset test
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Fix deployment apiVersion
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Create custom namespace before test
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Migrate to Go modules
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Add 'go mod download'
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Update machine image
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Install Go
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Fix Go installation
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Fix Go installation
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Override Go link
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Do checkout first
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Fix link
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
* Copy go 1.13 binary in place of circle image default binary
Signed-off-by: Scott Rigby <scott@r6by.com>
* Use latest helm v3 version, and remove install_tiller function
Signed-off-by: Scott Rigby <scott@r6by.com>
* Revert "Use latest helm v3 version, and remove install_tiller function"
This reverts commit 63dedab3a2.
Signed-off-by: Scott Rigby <scott@r6by.com>
* Copy full go 1.13 dir into the circle machine default location after deleting initial install
Signed-off-by: Scott Rigby <scott@r6by.com>
* feat(upgrade): allow skipping missing values files
This allows fixing previous chart versions in a single pull request
without applying a major version bump to the chart version.
Signed-off-by: Jacob LeGrone <git@jacob.work>
* test(skip-missing-values): validate config and HasCIValuesFile method
Signed-off-by: Jacob LeGrone <git@jacob.work>
* docs(skip-missing-values): generate documentation
Signed-off-by: Jacob LeGrone <git@jacob.work>
* fix(chart): switch to filepath from path
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Add helm/kubectl integration test
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Use Chart type from integration tests
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Update .circleci/config.yml
Co-Authored-By: jlegrone <jlegrone@users.noreply.github.com>
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Remove extraneous test chart files
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Fix shellcheck lint
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Remove example kind config from e2e tests
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Remove breaking semver test
This wasn't super clear and was no longer working properly
after the switch to git-worktree.
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Bump kind version
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Test chart upgrades against previous version
Upgrade testing will be run if the --upgrade flag is set (default true)
and chart version increment does not indicate a breaking change
according to the SemVer 2.0 spec.
Any releases associated with previous chart versions which fail to roll
out or for which an initial `helm test` fails will be ignored.
Signed-off-by: Jacob LeGrone <git@jacob.work>
* fix(dep): add version constraint for github.com/otiai10/copy
Signed-off-by: Jacob LeGrone <git@jacob.work>
* refactor(git): checkout whole repository with worktree
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Rename test* to do*
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Return bool, error from BreakingChangeAllowed
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Use errors.Wrapf
Co-Authored-By: jlegrone <jlegrone@users.noreply.github.com>
Signed-off-by: Jacob LeGrone <git@jacob.work>
* Explicitly disable upgrade when not install
Signed-off-by: Jacob LeGrone <git@jacob.work>
Fixes a regression introduced in #73 so that chart directories were no longer required to be in a direct subdirectory of configured chart directories.
This caused problems in https://github.com/helm/charts/pull/10830.
cc @munnerz
* Fix regression in changed chart detection
Please enter the commit message for your changes. Lines starting
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
* Refactor to consider charts at root
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
* Make sure charts are processed only once
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
* Fix typo
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
