helm/chart-testing
1
0
Fork 0
mirror of https://github.com/helm/chart-testing.git synced 2026-02-05 09:45:14 +01:00
Code Issues Activity

Improve error logging (#91)

Browse Source 
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
This commit is contained in:
Reinhard Nägele
2019-01-23 19:15:12 +01:00
committed by GitHub
parent 00f37261fa
commit 868038e2e8
5 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/cmd/install.go
View File

@@ -76,14 +76,14 @@ func install(cmd *cobra.Command, args []string) {
configuration, err := config.LoadConfiguration(cfgFile, cmd, bindRootFlags, bindInstallFlags)
if err != nil {
fmt.Println(err)
fmt.Printf("Error loading configuration: %s\n", err)
os.Exit(1)
}
testing := chart.NewTesting(*configuration)
results, err := testing.InstallCharts()
if err != nil {
fmt.Println("Error installing charts:", err)
fmt.Printf("Error installing charts: %s\n", err)
} else {
fmt.Println("All charts installed successfully")
}

4
app/cmd/lint.go
View File

@@ -78,14 +78,14 @@ func lint(cmd *cobra.Command, args []string) {
configuration, err := config.LoadConfiguration(cfgFile, cmd, bindRootFlags, bindLintFlags)
if err != nil {
fmt.Println(err)
fmt.Printf("Error loading configuration: %s\n", err)
os.Exit(1)
}
testing := chart.NewTesting(*configuration)
results, err := testing.LintCharts()
if err != nil {
fmt.Println("Error linting charts")
fmt.Printf("Error linting charts: %s\n", err)
} else {
fmt.Println("All charts linted successfully")
}

4
app/cmd/lintAndInstall.go
View File

@@ -45,14 +45,14 @@ func lintAndInstall(cmd *cobra.Command, args []string) {
configuration, err := config.LoadConfiguration(cfgFile, cmd, bindRootFlags, bindLintFlags, bindInstallFlags)
if err != nil {
fmt.Println(err)
fmt.Printf("Error loading configuration: %s\n", err)
os.Exit(1)
}
testing := chart.NewTesting(*configuration)
results, err := testing.LintAndInstallCharts()
if err != nil {
fmt.Println("Error linting and installing charts")
fmt.Printf("Error linting and installing charts: %s\n", err)
} else {
fmt.Println("All charts linted and installed successfully")
}

4
pkg/chart/chart.go
View File

@@ -419,11 +419,11 @@ func (t *Testing) ComputeChangedChartDirectories() ([]string, error) {
mergeBase, err := t.git.MergeBase(fmt.Sprintf("%s/%s", cfg.Remote, cfg.TargetBranch), "HEAD")
if err != nil {
return nil, errors.Wrap(err, "Could not determine changed charts: Error identifying merge base.")
return nil, errors.Wrap(err, "Error identifying merge base")
}
allChangedChartFiles, err := t.git.ListChangedFilesInDirs(mergeBase, cfg.ChartDirs...)
if err != nil {
return nil, errors.Wrap(err, "Could not determine changed charts: Error creating diff.")
return nil, errors.Wrap(err, "Error creating diff")
}
var changedChartDirs []string

2
pkg/tool/git.go
View File

@@ -51,7 +51,7 @@ func (g Git) ListChangedFilesInDirs(commit string, dirs ...string) ([]string, er
changedChartFilesString, err :=
g.exec.RunProcessAndCaptureOutput("git", "diff", "--find-renames", "--name-only", commit, "--", dirs)
if err != nil {
return nil, errors.Wrap(err, "Could not determined changed charts: Error creating diff.")
return nil, errors.Wrap(err, "Error creating diff")
}
if changedChartFilesString == "" {
return nil, nil