pkg:utils unit test

added unit test for pkgs/utils

Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>

pkg/utils/maps_test.go

@@ -0,0 +1,35 @@
+package utils
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestMergeStringMaps(t *testing.T) {
+	map1 := map[string]string{
+		"a": "a",
+		"b": "b",
+		"c": "c",
+		"d": "d",
+	}
+	map2 := map[string]string{
+		"a": "a",
+		"b": "b",
+		"c": "c",
+		"d": "d",
+	}
+
+	mergedmap := MergeStringMaps(map1, map2)
+	assert.Equal(t, mergedmap, map1)
+
+	map2 = map[string]string{
+		"e": "e",
+		"f": "f",
+		"g": "g",
+		"h": "h",
+	}
+
+	mergedmap = MergeStringMaps(map1, map2)
+	assert.Equal(t, len(mergedmap), 8)
+}

pkg/utils/mutex_test.go

@@ -0,0 +1,16 @@
+package utils
+
+import "testing"
+import "github.com/stretchr/testify/assert"
+
+func TestTryLock(t *testing.T) {
+	lock := MutexWithTry{}
+	defer lock.Unlock()
+
+	l := lock.TryLock()
+	assert.True(t, l)
+
+	l = lock.TryLock()
+	assert.False(t, l)
+
+}

pkg/utils/peerutils_test.go

@@ -0,0 +1,29 @@
+package utils
+
+import (
+	"testing"
+
+	config "github.com/spf13/viper"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestIsPeerAddressSame(t *testing.T) {
+	resp := IsPeerAddressSame("192.167.1.1:8080", "192.167.1.1:8080")
+	assert.True(t, resp)
+
+	resp = IsPeerAddressSame("192.167.1.1:8080", "192.167.1.1:8081")
+	assert.False(t, resp)
+}
+
+func TestFormRemotePeerAddress(t *testing.T) {
+	peer, err := FormRemotePeerAddress("192.168.1.1:8080")
+	assert.Nil(t, err)
+
+	config.SetDefault("defaultpeerport", "80")
+	peer, err = FormRemotePeerAddress("192.168.1.1")
+	assert.Equal(t, peer, "192.168.1.1:80")
+
+	peer, err = FormRemotePeerAddress(":8080")
+	assert.Contains(t, err.Error(), "Invalid peer address")
+
+}

pkg/utils/statedump_test.go

@@ -0,0 +1,24 @@
+package utils
+
+import (
+	"fmt"
+	"os"
+	"strconv"
+	"testing"
+	"time"
+
+	config "github.com/spf13/viper"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestWriteStatedump(t *testing.T) {
+	filename := fmt.Sprintf("glusterd2.%s.dump.%s",
+		strconv.Itoa(os.Getpid()), strconv.Itoa(int(time.Now().Unix())))
+	WriteStatedump()
+	assert.FileExists(t, filename)
+	os.Remove(filename)
+
+	config.Set("rundir", "/abc")
+	WriteStatedump()
+}

pkg/utils/types_test.go

@@ -0,0 +1,14 @@
+package utils
+
+import (
+	"testing"
+
+	"github.com/gluster/glusterd2/pkg/api"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetTypeString(t *testing.T) {
+	resp := GetTypeString((*api.PeerGetResp)(nil))
+	assert.Equal(t, resp, "api.PeerGetResp")
+
+}

pkg/utils/utils_test.go

@@ -88,6 +88,13 @@ func TestIsAddressSame(t *testing.T) {
 
 	resp = IsAddressSame("192.169.1.2", "192.168.1.1")
 	assert.False(t, resp)
+
+	resp = IsAddressSame("192.169.1.2", "192.168.1")
+	assert.False(t, resp)
+
+	resp = IsAddressSame("192.169.1", "192.168.1.1")
+	assert.False(t, resp)
+
 }
 
 func TestGetLocalIP(t *testing.T) {

pkg/utils/volumeutils_test.go

@@ -0,0 +1,24 @@
+package utils
+
+import (
+	"testing"
+	//"github.com/stretchr/testify/assert"
+	config "github.com/spf13/viper"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetVolumeDir(t *testing.T) {
+	config.Set("localstatedir", "/var/lib/glusterd2")
+
+	resp := GetVolumeDir("testvolume")
+	assert.Equal(t, resp, "/var/lib/glusterd2/vols/testvolume")
+
+}
+
+func TestGetSnapshotDir(t *testing.T) {
+	config.Set("localstatedir", "/var/lib/glusterd2")
+
+	resp := GetSnapshotDir("testvolume")
+	assert.Equal(t, resp, "/var/lib/glusterd2/snaps/testvolume")
+
+}