etcd-io/etcd
1
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2026-02-05 06:46:49 +01:00
Code Issues Releases Activity

pkg/featuregate: Return MutableFeatureGate interface in New function

Browse Source 
Avoid returning an unexported struct in the exported New function,
instead return the MutableFeatureGate interface.

Signed-off-by: Ivan Valdes <ivan@vald.es>
This commit is contained in:
Ivan Valdes
2025-04-25 23:14:08 -07:00
parent aa8238f511
commit 491199f4f0
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/featuregate/feature_gate.go
View File

@@ -166,7 +166,7 @@ func setUnsetBetaGates(known map[Feature]FeatureSpec, enabled map[Feature]bool,
// Set, String, and Type implement pflag.Value
var _ pflag.Value = &featureGate{}
func New(name string, lg *zap.Logger) *featureGate {
func New(name string, lg *zap.Logger) MutableFeatureGate {
if lg == nil {
lg = zap.NewNop()
}

2
pkg/featuregate/feature_gate_test.go
View File

@@ -219,7 +219,7 @@ func TestFeatureGateFlag(t *testing.T) {
t.Errorf("%d: Parse() Expected nil, Got %v", i, err)
}
for k, v := range test.expect {
actual := f.enabled.Load().(map[Feature]bool)[k]
actual := f.Enabled(k)
assert.Equalf(t, actual, v, "%d: expected %s=%v, Got %v", i, k, v, actual)
}
})