coreos/coreos-assembler
1
0
Fork 0
mirror of https://github.com/coreos/coreos-assembler.git synced 2026-02-05 18:44:56 +01:00
Code Issues Releases Activity

kola/azure: correct default vm size

Browse Source 
I mistakenly thought that Standard_D2_v3 was compatible with
Hyper-V Gen2, but this is incorrect. Instead, let's use Standard_D2s_v3
which does support Gen2.

Fixes: 083029fc9b
This commit is contained in:
Michael Armijo
2025-05-30 13:22:16 -06:00
committed by Dusty Mabe
parent 083029fc9b
commit 7fe8cd4acc
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
docs/kola.md
View File

@@ -247,8 +247,8 @@ In order to see the logs for these tests you must enter the `tmp/kola/name_of_th
- `gcp-json-key` is using a service account's JSON key for authentication, how to create service account keys refer to https://github.com/coreos/coreos-assembler/blob/main/docs/mantle/credentials.md#gcp.
- `gcp-project` is meant for testing in the specified project, or it will use the same as `<GCP Image Project>`.
`cosa kola run --arch=x86_64 -p=azure --azure-credentials azureCreds.json --azure-disk-uri ${ImageId} basic` This will run the basic tests on Azure using default machine type `Standard_D2_v3`.
`cosa kola run --arch=x86_64 -p=azure --azure-credentials azureCreds.json --azure-disk-uri ${ImageId} basic` This will run the basic tests on Azure using default machine type `Standard_D2s_v3`.
- `azure-credentials` is a JSON file generated by hand to pass authentication to our mantle code that will then use it to authenticate with azure services, how to create credentials refer to https://github.com/coreos/coreos-assembler/blob/main/docs/mantle/credentials.md#azure
- `azure-disk-uri` is Azure disk uri of the custom image, this could be a gallery image version if you are using Azure Compute Gallery, refer to https://learn.microsoft.com/en-us/azure/virtual-machines/azure-compute-gallery. For example, get gallery image id via command: `galleryImageId=$(az sig image-version show --gallery-image-definition "${gallery_image_definition}" --gallery-image-version "${gallery_image_version}" --gallery-name "${gallery_name}" --resource-group $az_resource_group | jq -r .id)`.
- `azure-location` specifies Azure location if you want to use custom location, by default is `westus`.
- `azure-size` specifies Azure machine size if you want to use custom size, by default is `Standard_D2_v3`.
- `azure-size` specifies Azure machine size if you want to use custom size, by default is `Standard_D2s_v3`.

2
mantle/cmd/kola/options.go
View File

@@ -99,7 +99,7 @@ func init() {
sv(&kola.AzureOptions.Sku, "azure-sku", "alpha", "Azure image sku/channel (default \"alpha\"")
sv(&kola.AzureOptions.Version, "azure-version", "", "Azure image version")
sv(&kola.AzureOptions.Location, "azure-location", "westus", "Azure location (default \"westus\"")
sv(&kola.AzureOptions.Size, "azure-size", "Standard_D2_v3", "Azure machine size (default \"Standard_D2_v3\")")
sv(&kola.AzureOptions.Size, "azure-size", "Standard_D2s_v3", "Azure machine size (default \"Standard_D2s_v3\")")
sv(&kola.AzureOptions.AvailabilityZone, "azure-availability-zone", "1", "Azure Availability Zone (default \"1\")")
// do-specific options