2021-04-08 10:38:16 -04:00
###
### Makefile Navigation
###
#
# This file is organized based on approximate end-to-end workflow:
#
# 1. Variables and common definitions are located at the top
# to make finding them quicker.
# 2. Main entry-point targets, like "default", "all", and "help"
# 3. Targets for code formatting and validation
# 4. Primary build targets, like podman and podman-remote
# 5. Secondary build targets, shell completions, static and multi-arch.
# 6. Targets that format and build documentation
# 7. Testing targets
# 8. Release and package-building targets
# 9. Targets that install tools, utilities, binaries and packages
# 10. Uninstall / Cleanup targets
#
###
### Variables & Definitions
###
2023-01-31 16:43:11 -05:00
# Default shell `/bin/sh` has different meanings depending on the platform.
2023-06-09 13:27:21 +01:00
SHELL := $( shell command -v bash; )
2017-11-01 11:24:59 -04:00
GO ?= go
2021-09-23 14:25:02 +02:00
GO_LDFLAGS := $( shell if $( GO) version| grep -q gccgo ; then echo "-gccgoflags" ; else echo "-ldflags" ; fi )
2021-09-09 13:46:21 -04:00
GOCMD = CGO_ENABLED = $( CGO_ENABLED) GOOS = $( GOOS) GOARCH = $( GOARCH) $( GO)
2020-07-21 14:54:57 +02:00
COVERAGE_PATH ?= .coverage
2019-06-07 00:46:41 -05:00
DESTDIR ?=
2021-06-30 11:39:19 -04:00
EPOCH_TEST_COMMIT ?= $( shell git merge-base $$ { DEST_BRANCH:-main} HEAD)
2017-11-03 14:37:22 -05:00
HEAD ?= HEAD
2020-07-28 08:23:45 -04:00
PROJECT := github.com/containers/podman
2021-06-30 11:39:19 -04:00
GIT_BASE_BRANCH ?= origin/main
2017-11-02 15:31:21 -04:00
LIBPOD_INSTANCE := libpod_dev
2019-06-07 00:46:41 -05:00
PREFIX ?= /usr/local
2023-06-30 16:35:53 +01:00
RELEASE_PREFIX = /usr
2017-11-01 11:24:59 -04:00
BINDIR ?= ${ PREFIX } /bin
LIBEXECDIR ?= ${ PREFIX } /libexec
2021-09-02 14:14:59 +02:00
LIBEXECPODMAN ?= ${ LIBEXECDIR } /podman
2017-11-01 11:24:59 -04:00
MANDIR ?= ${ PREFIX } /share/man
2018-03-01 15:33:04 -05:00
SHAREDIR_CONTAINERS ?= ${ PREFIX } /share/containers
2023-04-18 16:14:02 +02:00
ETCDIR ?= /etc
2023-03-18 22:49:25 +00:00
LIBDIR ?= ${ PREFIX } /lib
TMPFILESDIR ?= ${ LIBDIR } /tmpfiles.d
2022-08-24 14:52:40 +09:00
USERTMPFILESDIR ?= ${ PREFIX } /share/user-tmpfiles.d
2023-03-18 22:49:25 +00:00
MODULESLOADDIR ?= ${ LIBDIR } /modules-load.d
SYSTEMDDIR ?= ${ LIBDIR } /systemd/system
USERSYSTEMDDIR ?= ${ LIBDIR } /systemd/user
SYSTEMDGENERATORSDIR ?= ${ LIBDIR } /systemd/system-generators
USERSYSTEMDGENERATORSDIR ?= ${ LIBDIR } /systemd/user-generators
2020-06-03 09:33:52 -04:00
REMOTETAGS ?= remote exclude_graphdriver_btrfs btrfs_noversion exclude_graphdriver_devicemapper containers_image_openpgp
2019-05-08 08:49:08 +02:00
BUILDTAGS ?= \
$( shell hack/apparmor_tag.sh) \
$( shell hack/btrfs_installed_tag.sh) \
$( shell hack/btrfs_tag.sh) \
$( shell hack/selinux_tag.sh) \
$( shell hack/systemd_tag.sh) \
2021-08-27 08:12:56 -04:00
$( shell hack/libsubid_tag.sh) \
2019-05-08 08:49:08 +02:00
exclude_graphdriver_devicemapper \
2020-05-29 14:38:33 -04:00
seccomp
2023-06-21 14:54:16 -04:00
# N/B: This value is managed by Renovate, manual changes are
# possible, as long as they don't disturb the formatting
# (i.e. DO NOT ADD A 'v' prefix!)
GOLANGCI_LINT_VERSION := 1.53.3
2020-01-07 20:46:18 +00:00
PYTHON ?= $( shell command -v python3 python| head -n1)
2019-11-29 10:00:13 +00:00
PKG_MANAGER ?= $( shell command -v dnf yum| head -n1)
2020-01-07 20:46:18 +00:00
# ~/.local/bin is not in PATH on all systems
PRE_COMMIT = $( shell command -v bin/venv/bin/pre-commit ~/.local/bin/pre-commit pre-commit | head -n1)
2022-06-28 08:03:48 +01:00
i f e q ( $( shell uname -s ) , F r e e B S D )
SED = gsed
2023-06-12 10:12:01 +01:00
GREP = ggrep
2022-06-28 08:03:48 +01:00
e l s e
SED = sed
2023-06-12 10:12:01 +01:00
GREP = grep
2022-06-28 08:03:48 +01:00
e n d i f
2019-11-29 10:00:13 +00:00
Makefile: make bin/* real targets!
Backstory: every time you run 'make podman' or even
just 'make', you get a full recompile. This is sub-ideal.
Cause: I don't really know. It looks complicated. #5017
introduced a .PHONY for bin/podman, for reasons not
explained in the PR. Then, much later, #5880 well-
intentionedly but improperly tweaked the 'find'
command used in defining SOURCES, adding a -prune
but without the corresponding and required -print.
Let's just say, it was an unfortunate cascade of events.
This PR fixes the SOURCES definition and removes the
highly-undesired .PHONY from podman & podman-remote,
making it so you can type 'make' and, oh joy, not
build anything if it's current. The way 'make' is
supposed to work.
Why fix this now? Because my PR (#9209) was failing in CI,
in the Validate step:
Can't exec "./bin/podman": No such file or directory at hack/xref-helpmsgs-manpages line 223.
It failed even on Re-run, and only passed once I force-pushed
the PR (with no changes, just a new commit SHA). I have no idea
why bin/podman wasn't built, and I have zero interest in pursuing
that right now, but the proper solution is to add bin/podman as
a Makefile dependency for that particular test. So done.
While I'm at it, fix what is pretty clearly a typo in a .PHONY
And, finally, fix a go-md2man warning introduced in #9189
[NO TESTS NEEDED]
Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-02-02 16:10:54 -07:00
# This isn't what we actually build; it's a superset, used for target
2021-11-09 13:40:18 +11:00
# dependencies. Basically: all *.go and *.c files, except *_test.go,
# and except anything in a dot subdirectory. If any of these files is
# newer than our target (bin/podman{,-remote}), a rebuild is
# triggered.
SOURCES = $( shell find . -path './.*' -prune -o \( \( -name '*.go' -o -name '*.c' \) -a ! -name '*_test.go' \) -print)
2019-05-08 08:49:08 +02:00
2020-06-03 09:33:52 -04:00
BUILDTAGS_CROSS ?= containers_image_openpgp exclude_graphdriver_btrfs exclude_graphdriver_devicemapper exclude_graphdriver_overlay
2018-11-03 00:28:31 +01:00
CONTAINER_RUNTIME := $( shell command -v podman 2> /dev/null || echo docker)
2019-02-05 14:52:03 +01:00
OCI_RUNTIME ?= ""
2018-06-22 08:56:08 -05:00
2022-08-02 06:02:04 -06:00
# The 'sort' below is crucial: without it, 'make docs' behaves differently
# on the first run than on subsequent ones, because the generated .md
MANPAGES_SOURCE_DIR = docs/source/markdown
MANPAGES_MD_IN ?= $( wildcard $( MANPAGES_SOURCE_DIR) /*.md.in)
MANPAGES_MD_GENERATED ?= $( MANPAGES_MD_IN:%.md.in= %.md)
MANPAGES_MD ?= $( sort $( wildcard $( MANPAGES_SOURCE_DIR) /*.md) $( MANPAGES_MD_GENERATED) )
2021-04-08 10:38:16 -04:00
MANPAGES ?= $( MANPAGES_MD:%.md= %)
MANPAGES_DEST ?= $( subst markdown,man, $( subst source,build,$( MANPAGES) ) )
2017-11-01 11:24:59 -04:00
BASHINSTALLDIR = ${ PREFIX } /share/bash-completion/completions
2019-03-01 15:39:51 -07:00
ZSHINSTALLDIR = ${ PREFIX } /share/zsh/site-functions
2020-11-08 21:50:51 +01:00
FISHINSTALLDIR = ${ PREFIX } /share/fish/vendor_completions.d
2017-11-01 11:24:59 -04:00
SELINUXOPT ?= $( shell test -x /usr/sbin/selinuxenabled && selinuxenabled && echo -Z)
Makefile: Use ?= for shell variables (ISODATE, etc.)
Previously, Make would execute these shell commands even if we didn't
need the resulting variable. With ?='s recursive expansion [1], we
only expand the variable when it's consumed. For example, the ISODATE
variable is only needed in the recipe for the changelog target, so
most Make invocations won't need the value, and the computation is
just making whatever Make actually is doing slower.
I've shifted the GIT_COMMIT and BUILD_INFO values over to
LDFLAGS_PODMAN, because the test/*/* targets don't care about those.
I've also moved the Go-specific -ldflags from the variables into the
recipes themselves, because callers probably expect C semantics for
LDFLAGS and not Go's wrapper. That means that there's no longer a
need for the LDFLAGS/BASE_LDFLAGS separation, so I'm just using
LDFLAGS (and LDFLAGS_PODMAN) now. That reduces the declared variables
to just LDFLAGS_PODMAN, so I've shifted that declaration up to get it
closer to its GIT_COMMIT and BUILD_INFO precursors.
[1]: https://www.gnu.org/software/make/manual/html_node/Setting.html
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #777
Approved by: rhatdan
2018-05-15 16:27:07 -07:00
COMMIT_NO ?= $( shell git rev-parse HEAD 2> /dev/null || true )
2022-05-31 11:48:46 -04:00
GIT_COMMIT ?= $( if $( shell git status --porcelain --untracked-files= no) ,$( call err_if_empty,COMMIT_NO) -dirty,$( COMMIT_NO) )
2019-06-20 23:14:18 +02:00
DATE_FMT = %s
i f d e f S O U R C E _ D A T E _ E P O C H
2022-05-31 11:48:46 -04:00
BUILD_INFO ?= $( shell date -u -d " @ $( call err_if_empty,SOURCE_DATE_EPOCH) " " + $( DATE_FMT) " 2>/dev/null || date -u -r " $( SOURCE_DATE_EPOCH) " " + $( DATE_FMT) " 2>/dev/null || date -u " + $( DATE_FMT) " )
2019-06-20 23:14:18 +02:00
e l s e
BUILD_INFO ?= $( shell date " + $( DATE_FMT) " )
e n d i f
2022-01-18 10:14:48 +01:00
LIBPOD := ${ PROJECT } /v4/libpod
2021-08-09 20:10:18 +02:00
GOFLAGS ?= -trimpath
2019-12-12 17:09:00 +01:00
LDFLAGS_PODMAN ?= \
2022-05-31 11:48:46 -04:00
$( if $( GIT_COMMIT) ,-X $( LIBPOD) /define.gitCommit= $( GIT_COMMIT) ,) \
$( if $( BUILD_INFO) ,-X $( LIBPOD) /define.buildInfo= $( BUILD_INFO) ,) \
2021-06-14 14:53:47 -04:00
-X $( LIBPOD) /config._installPrefix= $( PREFIX) \
-X $( LIBPOD) /config._etcDir= $( ETCDIR) \
2022-12-13 14:10:07 +01:00
-X $( PROJECT) /v4/pkg/systemd/quadlet._binDir= $( BINDIR) \
2022-02-28 09:54:15 -05:00
-X github.com/containers/common/pkg/config.additionalHelperBinariesDir= $( HELPER_BINARIES_DIR) \
2021-06-14 14:53:47 -04:00
$( EXTRA_LDFLAGS)
LDFLAGS_PODMAN_STATIC ?= \
$( LDFLAGS_PODMAN) \
-extldflags= -static
2019-02-01 11:26:15 +09:00
#Update to LIBSECCOMP_COMMIT should reflect in Dockerfile too.
2020-01-09 14:20:51 -05:00
LIBSECCOMP_COMMIT := v2.3.3
2019-02-05 13:22:42 -05:00
# Rarely if ever should integration tests take more than 50min,
# caller may override in special circumstances if needed.
2019-03-04 13:18:10 -05:00
GINKGOTIMEOUT ?= -timeout= 90m
2022-06-30 12:13:45 -04:00
# By default, run test/e2e
GINKGOWHAT ?= test/e2e/.
2023-05-02 12:30:18 +02:00
GINKGO_PARALLEL = y
2022-11-24 18:27:10 +01:00
GINKGO ?= ./test/tools/build/ginkgo
2023-05-04 08:18:30 -06:00
# ginkgo json output is only useful in CI, not on developer runs
GINKGO_JSON ?= $( if $( CI) ,--json-report ginkgo-e2e.json,)
2019-02-05 13:22:42 -05:00
2021-09-16 16:15:28 -04:00
# Conditional required to produce empty-output if binary not built yet.
RELEASE_VERSION = $( shell if test -x test/version/version; then test/version/version; fi )
2022-05-31 11:48:46 -04:00
RELEASE_NUMBER = $( shell echo " $( call err_if_empty,RELEASE_VERSION) " | sed -e 's/^v\(.*\)/\1/' )
2019-07-01 14:52:55 -04:00
WIP: Enable (and disable) remote testing
podman-remote has not been tested. A principal part of the
problem was #5387 - the YAML I wrote did not have the
intended effect, it did not set TEST_REMOTE_CLIENT=true
and because of my multiple iterations I did not catch this
during testing.
Part 1 of this PR is to fix .cirrus.yml to enable remote tests.
Part 2 -- what I had first noticed and tried to fix -- is that
rootless_test.sh was never running remote because, of course,
envariables are not sent via ssh. I reworked integration_test.sh
and rootless_test.sh to use a command-line decision instead.
Part 3, sigh, is to disable one failing integration test
and *all* system tests, because so many of the latter are
failing. Addressing those failures needs to be done in
subsequent PRs. Issues #6538, #6539, #6540 are filed for
some of the problems I isolated. There will be more.
Also, minor, fixed some stale references to varlink.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-06-08 14:57:37 -06:00
# If non-empty, logs all output from server during remote system testing
PODMAN_SERVER_LOG ?=
2019-10-08 14:20:44 -04:00
2022-04-13 17:13:45 -07:00
# Ensure GOBIN is not set so the default (`go env GOPATH`/bin) is used.
o v e r r i d e u n d e f i n e G O B I N
2022-05-03 13:59:00 -04:00
# This must never include the 'hack' directory
2022-04-13 17:13:45 -07:00
export PATH := $( shell $( GO) env GOPATH) /bin:$( PATH)
2021-01-19 10:27:01 +01:00
2022-05-04 14:17:02 +02:00
GOMD2MAN ?= $( shell command -v go-md2man || echo './test/tools/build/go-md2man' )
2017-11-01 11:24:59 -04:00
2018-06-29 14:47:53 -07:00
CROSS_BUILD_TARGETS := \
2020-03-10 13:45:31 -05:00
bin/podman.cross.linux.amd64 \
bin/podman.cross.linux.ppc64le \
2020-09-08 08:32:10 -04:00
bin/podman.cross.linux.arm \
bin/podman.cross.linux.arm64 \
bin/podman.cross.linux.386 \
2021-01-07 14:51:17 +01:00
bin/podman.cross.linux.s390x \
bin/podman.cross.linux.mips \
bin/podman.cross.linux.mipsle \
bin/podman.cross.linux.mips64 \
2022-08-17 15:07:35 +01:00
bin/podman.cross.linux.mips64le \
bin/podman.cross.freebsd.amd64 \
bin/podman.cross.freebsd.arm64
2018-06-29 14:47:53 -07:00
2021-04-08 10:38:16 -04:00
# Dereference variable $(1), return value if non-empty, otherwise raise an error.
err_if_empty = $( if $( strip $( $( 1) ) ) ,$( strip $( $( 1) ) ) ,$( error Required variable $( 1) value is undefined, whitespace, or empty) )
2022-07-18 07:53:39 -06:00
# Podman does not work w/o CGO_ENABLED, except in some very specific cases.
# Windows and Mac (both podman-remote client only) require CGO_ENABLED=0.
2021-04-08 14:30:40 -04:00
CGO_ENABLED ?= 1
2021-04-21 05:38:34 -04:00
# Default to the native OS type and architecture unless otherwise specified
2021-09-09 13:46:21 -04:00
NATIVE_GOOS := $( shell env -u GOOS $( GO) env GOOS)
2022-05-31 11:48:46 -04:00
GOOS ?= $( call err_if_empty,NATIVE_GOOS)
2021-09-09 13:46:21 -04:00
# Default to the native architecture type
NATIVE_GOARCH := $( shell env -u GOARCH $( GO) env GOARCH)
GOARCH ?= $( NATIVE_GOARCH)
2021-04-08 14:30:40 -04:00
i f e q ( $( call err_if_empty ,GOOS ) , w i n d o w s )
BINSFX := .exe
SRCBINDIR := bin/windows
2022-07-18 07:53:39 -06:00
CGO_ENABLED := 0
2021-04-08 14:30:40 -04:00
e l s e i f e q ( $( GOOS ) , d a r w i n )
BINSFX :=
SRCBINDIR := bin/darwin
2022-07-18 07:53:39 -06:00
CGO_ENABLED := 0
2023-06-30 16:35:53 +01:00
e l s e i f e q ( $( GOOS ) , f r e e b s d )
BINSFX := -remote
SRCBINDIR := bin
RELEASE_PREFIX = /usr/local
2021-04-08 14:30:40 -04:00
e l s e
BINSFX := -remote
SRCBINDIR := bin
e n d i f
# Necessary for nested-$(MAKE) calls and docs/remote-docs.sh
2021-09-09 13:46:21 -04:00
export GOOS GOARCH CGO_ENABLED BINSFX SRCBINDIR
2021-04-08 14:30:40 -04:00
2021-10-14 10:03:26 -07:00
# Need to use CGO for mDNS resolution, but cross builds need CGO disabled
# See https://github.com/golang/go/issues/12524 for details
DARWIN_GCO := 0
2022-05-31 11:48:46 -04:00
i f e q ( $( call err_if_empty ,NATIVE_GOOS ) , d a r w i n )
2021-10-14 10:03:26 -07:00
i f d e f H O M E B R E W _ P R E F I X
DARWIN_GCO := 1
e n d i f
e n d i f
2022-01-18 14:39:48 -06:00
# win-sshproxy is checked out manually to keep from pulling in gvisor and it's transitive
# dependencies. This is only used for the Windows installer task (podman.msi), which must
# include this lightweight helper binary.
#
2022-03-15 17:33:34 +01:00
GV_GITURL = https://github.com/containers/gvisor-tap-vsock.git
2023-04-20 14:23:44 -05:00
GV_SHA = 407efb5dcdb0f4445935f7360535800b60447544
2022-01-18 14:39:48 -06:00
2021-04-08 10:38:16 -04:00
###
### Primary entry-point targets
###
Simplify Makefile help target
An in-line Python script, while flexible, is arguably
more complex and less stable than the long-lived `grep`,
`awk`, and `printf`. Make use of these simple tools
to display a column-aligned table of target and description
help output.
Also, the first target that appears in a Makefile is considered
the default (when no target is specified on the command-line).
However, despite it's name, the `default` target was not listed
first. Fix this, and redefine "default" target to "all" as
intended, instead of "help".
Lastly, add a small workaround for a vim syntax-hilighting bug.
Signed-off-by: Chris Evich <cevich@redhat.com>
2021-04-08 08:55:56 -04:00
.PHONY : default
default : all
2020-01-29 19:15:24 +01:00
.PHONY : all
2017-11-01 11:29:12 -04:00
all : binaries docs
2017-11-01 11:24:59 -04:00
2021-04-08 10:38:16 -04:00
.PHONY : binaries
2022-06-28 08:15:13 +01:00
i f e q ( $( shell uname -s ) , F r e e B S D )
binaries : podman podman -remote ## Build podman and podman-remote binaries
2023-06-05 17:59:47 +03:00
e l s e i f n e q ( , $( findstring $ ( GOOS ) ,darwin windows ) )
binaries : podman -remote ## Build podman-remote (client) only binaries
2022-06-28 08:15:13 +01:00
e l s e
2023-06-14 14:49:08 -04:00
binaries : podman podman -remote podmansh rootlessport quadlet ## Build podman, podman-remote and rootlessport binaries quadlet
2022-06-28 08:15:13 +01:00
e n d i f
2020-02-03 11:58:38 -05:00
Simplify Makefile help target
An in-line Python script, while flexible, is arguably
more complex and less stable than the long-lived `grep`,
`awk`, and `printf`. Make use of these simple tools
to display a column-aligned table of target and description
help output.
Also, the first target that appears in a Makefile is considered
the default (when no target is specified on the command-line).
However, despite it's name, the `default` target was not listed
first. Fix this, and redefine "default" target to "all" as
intended, instead of "help".
Lastly, add a small workaround for a vim syntax-hilighting bug.
Signed-off-by: Chris Evich <cevich@redhat.com>
2021-04-08 08:55:56 -04:00
# Extract text following double-# for targets, as their description for
# the `help` target. Otherwise These simple-substitutions are resolved
# at reference-time (due to `=` and not `=:`).
_HLP_TGTS_RX = '^[[:print:]]+:.*?\#\# .*$$'
2023-06-12 10:12:01 +01:00
_HLP_TGTS_CMD = $( GREP) -E $( _HLP_TGTS_RX) $( MAKEFILE_LIST)
2023-06-05 17:59:47 +03:00
_HLP_TGTS_LEN = $( shell $( call err_if_empty,_HLP_TGTS_CMD) | cut -d : -f 1 | wc -L 2>/dev/null || echo "PARSING_ERROR" )
# Separated condition for Darwin
i f e q ( $( shell uname -s ) $( _HLP_TGTS_LEN ) , D a r w i n P A R S I N G _ E R R O R )
i f n e q ( , $( wildcard /usr /local /bin /gwc ) )
_HLP_TGTS_LEN = $( shell $( call err_if_empty,_HLP_TGTS_CMD) | cut -d : -f 1 | gwc -L)
e l s e
$( warning On Darwin ( MacOS ) installed coreutils is necessary )
$( warning Use 'brew install coreutils ' command to install coreutils on your system )
e n d i f
e n d i f
2022-05-31 11:48:46 -04:00
_HLPFMT = " %- $( call err_if_empty,_HLP_TGTS_LEN) s %s\n "
2020-01-29 19:15:24 +01:00
.PHONY : help
Simplify Makefile help target
An in-line Python script, while flexible, is arguably
more complex and less stable than the long-lived `grep`,
`awk`, and `printf`. Make use of these simple tools
to display a column-aligned table of target and description
help output.
Also, the first target that appears in a Makefile is considered
the default (when no target is specified on the command-line).
However, despite it's name, the `default` target was not listed
first. Fix this, and redefine "default" target to "all" as
intended, instead of "help".
Lastly, add a small workaround for a vim syntax-hilighting bug.
Signed-off-by: Chris Evich <cevich@redhat.com>
2021-04-08 08:55:56 -04:00
help : ## (Default) Print listing of key targets with their descriptions
@printf $( _HLPFMT) "Target:" "Description:"
@printf $( _HLPFMT) "--------------" "--------------------"
@$( _HLP_TGTS_CMD) | sort | \
awk ' BEGIN { FS = ":(.*)?## " } ; \
{ printf $( _HLPFMT) , $$ 1, $$ 2} '
2017-11-01 11:24:59 -04:00
2021-04-08 10:38:16 -04:00
###
### Linting/Formatting/Code Validation targets
###
.PHONY : .gitvalidation
2022-04-13 16:31:49 -07:00
.gitvalidation :
2021-04-08 10:38:16 -04:00
@echo " Validating vs commit ' $( call err_if_empty,EPOCH_TEST_COMMIT) ' "
2023-06-23 07:55:12 -04:00
GIT_CHECK_EXCLUDE = "./vendor:./test/tools/vendor:docs/make.bat:test/buildah-bud/buildah-tests.diff:test/e2e/quadlet/remap-keep-id2.container" ./test/tools/build/git-validation -run DCO,short-subject,dangling-whitespace -range $( EPOCH_TEST_COMMIT) ..$( HEAD)
2021-04-08 10:38:16 -04:00
2020-01-29 19:15:24 +01:00
.PHONY : lint
2020-01-13 11:13:59 +01:00
lint : golangci -lint
2020-02-03 11:58:38 -05:00
@echo " Linting vs commit ' $( call err_if_empty,EPOCH_TEST_COMMIT) ' "
2020-01-07 20:46:18 +00:00
i f e q ( $( PRE_COMMIT ) , )
2020-02-18 09:28:47 -05:00
@echo "FATAL: pre-commit was not found, make .install.pre-commit to installing it." >& 2
2020-01-07 20:46:18 +00:00
@exit 2
e n d i f
$( PRE_COMMIT) run -a
2017-11-01 11:24:59 -04:00
2020-01-29 19:15:24 +01:00
.PHONY : golangci -lint
2022-04-13 16:31:49 -07:00
golangci-lint : .install .golangci -lint
2020-04-02 15:58:23 -07:00
hack/golangci-lint.sh run
2019-07-22 13:08:06 -05:00
2020-01-29 19:15:24 +01:00
.PHONY : test /checkseccomp /checkseccomp
2022-04-13 16:31:49 -07:00
test/checkseccomp/checkseccomp : $( wildcard test /checkseccomp /*.go )
2021-09-23 14:25:02 +02:00
$( GOCMD) build $( BUILDFLAGS) $( GO_LDFLAGS) '$(LDFLAGS_PODMAN)' -tags " $( BUILDTAGS) " -o $@ ./test/checkseccomp
2017-11-01 11:24:59 -04:00
2021-01-11 16:14:07 -05:00
.PHONY : test /testvol /testvol
2022-04-13 16:31:49 -07:00
test/testvol/testvol : $( wildcard test /testvol /*.go )
2022-06-22 14:34:32 +02:00
$( GOCMD) build -o $@ ./test/testvol
2021-01-11 16:14:07 -05:00
2022-06-22 13:21:45 +02:00
.PHONY : volume -plugin -test -img
2021-01-11 16:14:07 -05:00
volume-plugin-test-img :
2022-06-22 13:33:37 +02:00
./bin/podman build --network none -t quay.io/libpod/volume-plugin-test-img:$$ ( date +%Y%m%d) -f ./test/testvol/Containerfile .
2021-01-11 16:14:07 -05:00
2020-12-21 17:48:43 -05:00
.PHONY : test /goecho /goecho
2022-04-13 16:31:49 -07:00
test/goecho/goecho : $( wildcard test /goecho /*.go )
2021-09-23 14:25:02 +02:00
$( GOCMD) build $( BUILDFLAGS) $( GO_LDFLAGS) '$(LDFLAGS_PODMAN)' -o $@ ./test/goecho
2018-10-29 14:56:07 +08:00
2022-11-21 14:13:31 -05:00
# The ./test/version/version binary is executed in other make steps
# so we have to make sure the version binary is built for NATIVE_GOARCH.
2022-04-13 16:31:49 -07:00
test/version/version : version /version .go
2022-11-21 14:13:31 -05:00
GOARCH = $( NATIVE_GOARCH) $( GO) build -o $@ ./test/version/
2021-09-16 16:15:28 -04:00
2021-04-08 10:38:16 -04:00
.PHONY : codespell
codespell :
2023-03-21 14:46:14 -04:00
codespell -S bin,vendor,.git,go.sum,.cirrus.yml,"RELEASE_NOTES.md,*.xz,*.gz,*.ps1,*.tar,swagger.yaml,*.tgz,bin2img,*ico,*.png,*.1,*.5,copyimg,*.orig,apidoc.go" -L passt,bu,hastable,te,clos,ans,pullrequest,uint,iff,od,seeked,splitted,marge,erro,hist,ether,specif -w
2021-04-08 10:38:16 -04:00
.PHONY : validate
2022-07-25 09:00:36 -06:00
validate : lint .gitvalidation validate .completions man -page -check swagger -check tests -included tests -expect -exit pr -removes -fixed -skips
2021-04-08 10:38:16 -04:00
.PHONY : build -all -new -commits
build-all-new-commits :
# Validate that all the commits build on top of $(GIT_BASE_BRANCH)
2022-05-31 11:48:46 -04:00
git rebase $( call err_if_empty,GIT_BASE_BRANCH) -x " $( MAKE) "
2021-04-08 10:38:16 -04:00
.PHONY : vendor
vendor :
2023-07-12 10:33:32 +02:00
$( GO) mod tidy
2022-04-13 17:32:15 -07:00
$( GO) mod vendor
$( GO) mod verify
2021-04-08 10:38:16 -04:00
2022-11-24 17:12:22 +01:00
# We define *-in-container targets for the following make targets. This allow the targets to be run in a container.
# Note that the PODMANCMD can also be overridden to allow a different container CLI to be used on systems where podman is not already available.
IN_CONTAINER_TARGETS = vendor validate
PODMANCMD ?= podman
IN_CONTAINER = $( patsubst %,%-in-container,$( IN_CONTAINER_TARGETS) )
.PHONY : $( IN_CONTAINER )
$(IN_CONTAINER) : %-in -container :
$( PODMANCMD) run --rm --env HOME = /root \
2021-04-08 10:38:16 -04:00
-v $( CURDIR) :/src -w /src \
2022-08-25 10:56:41 +02:00
--security-opt label = disable \
2022-11-16 10:43:23 +01:00
docker.io/library/golang:1.18 \
2022-11-24 17:12:22 +01:00
make $( *)
2021-04-08 10:38:16 -04:00
###
### Primary binary-build targets
###
2020-01-29 17:09:01 +01:00
# Make sure to warn in case we're building without the systemd buildtag.
2022-04-13 16:31:49 -07:00
bin/podman : $( SOURCES ) go .mod go .sum
2020-01-29 17:09:01 +01:00
i f e q ( , $( findstring systemd ,$ ( BUILDTAGS ) ) )
2021-04-08 10:38:16 -04:00
@echo " Podman is being compiled without the systemd build tag. \
Install libsystemd on Ubuntu or systemd-devel on rpm based \
distro for journald support."
2020-01-29 17:09:01 +01:00
e n d i f
2021-09-09 13:46:21 -04:00
$( GOCMD) build \
2021-04-08 10:38:16 -04:00
$( BUILDFLAGS) \
2021-09-23 14:25:02 +02:00
$( GO_LDFLAGS) '$(LDFLAGS_PODMAN)' \
2021-04-08 10:38:16 -04:00
-tags " $( BUILDTAGS) " \
-o $@ ./cmd/podman
2017-11-01 11:24:59 -04:00
2021-04-08 14:30:40 -04:00
# Disambiguate Linux vs Darwin/Windows platform binaries under distinct "bin" dirs
$(SRCBINDIR) :
mkdir -p $( SRCBINDIR)
2019-12-29 21:04:56 +01:00
2022-07-18 07:53:39 -06:00
# '|' is to ignore SRCBINDIR mtime; see: info make 'Types of Prerequisites'
$(SRCBINDIR)/podman$(BINSFX) : $( SOURCES ) go .mod go .sum | $( SRCBINDIR )
2021-09-09 13:46:21 -04:00
$( GOCMD) build \
2021-04-08 14:30:40 -04:00
$( BUILDFLAGS) \
2021-09-23 14:25:02 +02:00
$( GO_LDFLAGS) '$(LDFLAGS_PODMAN)' \
2021-04-08 14:30:40 -04:00
-tags " ${ REMOTETAGS } " \
-o $@ ./cmd/podman
2021-04-08 10:38:16 -04:00
2022-11-29 10:44:22 +01:00
$(SRCBINDIR)/podman-remote-static-linux_amd64 $(SRCBINDIR)/podman-remote-static-linux_arm64 : $( SRCBINDIR ) /podman -remote -static -linux_ %: $( SRCBINDIR ) $( SOURCES ) go .mod go .sum
2022-03-21 14:59:25 -04:00
CGO_ENABLED = 0 \
2022-06-01 15:38:01 +02:00
GOOS = linux \
2022-11-29 10:33:59 +01:00
GOARCH = $* \
2022-03-21 14:59:25 -04:00
$( GO) build \
2021-04-08 14:30:40 -04:00
$( BUILDFLAGS) \
2021-09-23 14:25:02 +02:00
$( GO_LDFLAGS) '$(LDFLAGS_PODMAN_STATIC)' \
2021-04-08 14:30:40 -04:00
-tags " ${ REMOTETAGS } " \
-o $@ ./cmd/podman
2020-05-05 17:41:13 -04:00
2021-04-08 14:30:40 -04:00
.PHONY : podman
podman : bin /podman
2019-12-29 21:04:56 +01:00
2022-07-18 07:53:39 -06:00
# This will map to the right thing on Linux, Windows, and Mac.
2021-04-08 14:30:40 -04:00
.PHONY : podman -remote
2022-07-18 07:53:39 -06:00
podman-remote : $( SRCBINDIR ) /podman $( BINSFX )
2021-04-08 14:30:40 -04:00
2022-10-03 12:12:39 +02:00
$(SRCBINDIR)/quadlet : $( SOURCES ) go .mod go .sum
$( GOCMD) build \
$( BUILDFLAGS) \
$( GO_LDFLAGS) '$(LDFLAGS_PODMAN)' \
-tags " ${ BUILDTAGS } " \
-o $@ ./cmd/quadlet
.PHONY : quadlet
quadlet : bin /quadlet
2022-11-29 10:44:22 +01:00
PHONY : podman -remote -static -linux_amd 64 podman -remote -static -linux_arm 64
podman-remote-static-linux_amd64 : $( SRCBINDIR ) /podman -remote -static -linux_amd 64
podman-remote-static-linux_arm64 : $( SRCBINDIR ) /podman -remote -static -linux_arm 64
2021-04-08 14:30:40 -04:00
2021-12-14 01:38:16 -06:00
.PHONY : podman -winpath
2022-04-13 16:31:49 -07:00
podman-winpath : $( SOURCES ) go .mod go .sum
2021-12-14 01:38:16 -06:00
CGO_ENABLED = 0 \
GOOS = windows \
$( GO) build \
$( BUILDFLAGS) \
-ldflags -H= windowsgui \
-o bin/windows/winpath.exe \
./cmd/winpath
2022-01-29 03:10:28 -06:00
.PHONY : podman -mac -helper
podman-mac-helper : ## Build podman-mac-helper for macOS
CGO_ENABLED = 0 \
GOOS = darwin \
GOARCH = $( GOARCH) \
$( GO) build \
$( BUILDFLAGS) \
-o bin/darwin/podman-mac-helper \
./cmd/podman-mac-helper
2022-04-13 16:31:49 -07:00
bin/rootlessport : $( SOURCES ) go .mod go .sum
2021-09-02 14:14:59 +02:00
CGO_ENABLED = $( CGO_ENABLED) \
$( GO) build \
$( BUILDFLAGS) \
-o $@ ./cmd/rootlessport
.PHONY : rootlessport
rootlessport : bin /rootlessport
2023-06-14 14:49:08 -04:00
# podmansh calls `podman exec` into the `podmansh` container when used as
# os.Args[0] and is intended to be set as a login shell for users.
# Run: `man 1 podmansh` for details.
podmansh : bin /podman
if [ ! -f bin/podmansh ] ; then ln -s podman bin/podmansh; fi
2021-04-08 10:38:16 -04:00
###
### Secondary binary-build targets
###
.PHONY : generate -bindings
generate-bindings :
2021-04-08 14:30:40 -04:00
i f n e q ( $( GOOS ) , d a r w i n )
2022-04-13 17:32:15 -07:00
$( GOCMD) generate ./pkg/bindings/... ;
2021-04-08 10:38:16 -04:00
e n d i f
2018-06-29 14:47:53 -07:00
2021-04-08 14:30:40 -04:00
# DO NOT USE: use local-cross instead
2022-04-13 16:31:49 -07:00
bin/podman.cross.% :
2018-06-29 14:47:53 -07:00
TARGET = " $* " ; \
2021-04-08 14:30:40 -04:00
GOOS = " $$ {TARGET%%.*} " ; \
GOARCH = " $$ {TARGET##*.} " ; \
CGO_ENABLED = 0 \
$( GO) build \
$( BUILDFLAGS) \
2021-09-23 14:25:02 +02:00
$( GO_LDFLAGS) '$(LDFLAGS_PODMAN)' \
2021-04-08 14:30:40 -04:00
-tags '$(BUILDTAGS_CROSS)' \
-o " $@ " ./cmd/podman
2018-06-20 13:23:24 -05:00
2021-04-08 10:38:16 -04:00
.PHONY : local -cross
local-cross : $( CROSS_BUILD_TARGETS ) ## Cross compile podman binary for multiple architectures
2021-05-20 16:09:40 -04:00
.PHONY : cross
cross : local -cross
2021-04-08 10:38:16 -04:00
.PHONY : completions
completions : podman podman -remote
# key = shell, value = completion filename
declare -A outfiles = ( [ bash] = %s [ zsh] = _%s [ fish] = %s.fish [ powershell] = %s.ps1) ; \
for shell in $$ { !outfiles[ *] } ; do \
for remote in "" "-remote" ; do \
2021-09-27 14:52:45 -04:00
podman = " podman $$ remote " ; \
outfile = $$ ( printf " completions/ $$ shell/ $$ {outfiles[ $$ shell]} " $$ podman) ; \
./bin/$$ podman completion $$ shell >| $$ outfile; \
2021-04-08 10:38:16 -04:00
done ; \
done
###
### Documentation targets
###
Initial commit on compatible API
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Create service command
Use cd cmd/service && go build .
$ systemd-socket-activate -l 8081 cmd/service/service &
$ curl http://localhost:8081/v1.24/images/json
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Correct Makefile
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Two more stragglers
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Report errors back as http headers
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Split out handlers, updated output
Output aligned to docker structures
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Refactored routing, added more endpoints and types
* Encapsulated all the routing information in the handler_* files.
* Added more serviceapi/types, including podman additions. See Info
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Cleaned up code, implemented info content
* Move Content-Type check into serviceHandler
* Custom 404 handler showing the url, mostly for debugging
* Refactored images: better method names and explicit http codes
* Added content to /info
* Added podman fields to Info struct
* Added Container struct
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Add a bunch of endpoints
containers: stop, pause, unpause, wait, rm
images: tag, rmi, create (pull only)
Signed-off-by: baude <bbaude@redhat.com>
Add even more handlers
* Add serviceapi/Error() to improve error handling
* Better support for API return payloads
* Renamed unimplemented to unsupported these are generic endpoints
we don't intend to ever support. Swarm broken out since it uses
different HTTP codes to signal that the node is not in a swarm.
* Added more types
* API Version broken out so it can be validated in the future
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Refactor to introduce ServiceWriter
Signed-off-by: Jhon Honce <jhonce@redhat.com>
populate pods endpoints
/libpod/pods/..
exists, kill, pause, prune, restart, remove, start, stop, unpause
Signed-off-by: baude <bbaude@redhat.com>
Add components to Version, fix Error body
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Add images pull output, fix swarm routes
* docker-py tests/integration/api_client_test.py pass 100%
* docker-py tests/integration/api_image_test.py pass 4/16
+ Test failures include services podman does not support
Signed-off-by: Jhon Honce <jhonce@redhat.com>
pods endpoint submission 2
add create and others; only top and stats is left.
Signed-off-by: baude <bbaude@redhat.com>
Update pull image to work from empty registry
Signed-off-by: Jhon Honce <jhonce@redhat.com>
pod create and container create
first pass at pod and container create. the container create does not
quite work yet but it is very close. pod create needs a partial
rewrite. also broken off the DELETE (rm/rmi) to specific handler funcs.
Signed-off-by: baude <bbaude@redhat.com>
Add docker-py demos, GET .../containers/json
* Update serviceapi/types to reflect libpod not podman
* Refactored removeImage() to provide non-streaming return
Signed-off-by: Jhon Honce <jhonce@redhat.com>
create container part2
finished minimal config needed for create container. started demo.py
for upcoming talk
Signed-off-by: baude <bbaude@redhat.com>
Stop server after honoring request
* Remove casting for method calls
* Improve WriteResponse()
* Update Container API type to match docker API
Signed-off-by: Jhon Honce <jhonce@redhat.com>
fix namespace assumptions
cleaned up namespace issues with libpod.
Signed-off-by: baude <bbaude@redhat.com>
wip
Signed-off-by: baude <bbaude@redhat.com>
Add sliding window when shutting down server
* Added a Timeout rather than closing down service on each call
* Added gorilla/schema dependency for Decode'ing query parameters
* Improved error handling
* Container logs returned and multiplexed for stdout and stderr
* .../containers/{name}/logs?stdout=True&stderr=True
* Container stats
* .../containers/{name}/stats
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Improve error handling
* Add check for at least one std stream required for /containers/{id}/logs
* Add check for state in /containers/{id}/top
* Fill in more fields for /info
* Fixed error checking in service start code
Signed-off-by: Jhon Honce <jhonce@redhat.com>
get rest of image tests for pass
Signed-off-by: baude <bbaude@redhat.com>
linting our content
Signed-off-by: baude <bbaude@redhat.com>
more linting
Signed-off-by: baude <bbaude@redhat.com>
more linting
Signed-off-by: baude <bbaude@redhat.com>
pruning
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]apiv2 pods
migrate from using args in the url to using a json struct in body for
pod create.
Signed-off-by: baude <bbaude@redhat.com>
fix handler_images prune
prune's api changed slightly to deal with filters.
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]enabled base container create tests
enabling the base container create tests which allow us to get more into
the stop, kill, etc tests. many new tests now pass.
Signed-off-by: baude <bbaude@redhat.com>
serviceapi errors: append error message to API message
I dearly hope this is not breaking any other tests but debugging
"Internal Server Error" is not helpful to any user. In case, it
breaks tests, we can rever the commit - that's why it's a small one.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
serviceAPI: add containers/prune endpoint
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
add `service` make target
Also remove the non-functional sub-Makefile.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
add make targets for testing the service
* `sudo make run-service` for running the service.
* `DOCKERPY_TEST="tests/integration/api_container_test.py::ListContainersTest" \
make run-docker-py-tests`
for running a specific tests. Run all tests by leaving the env
variable empty.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Split handlers and server packages
The files were split to help contain bloat. The api/server package will
contain all code related to the functioning of the server while
api/handlers will have all the code related to implementing the end
points.
api/server/register_* will contain the methods for registering
endpoints. Additionally, they will have the comments for generating the
swagger spec file.
See api/handlers/version.go for a small example handler,
api/handlers/containers.go contains much more complex handlers.
Signed-off-by: Jhon Honce <jhonce@redhat.com>
[CI:DOCS]enabled more tests
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]libpod endpoints
small refactor for libpod inclusion and began adding endpoints.
Signed-off-by: baude <bbaude@redhat.com>
Implement /build and /events
* Include crypto libraries for future ssh work
Signed-off-by: Jhon Honce <jhonce@redhat.com>
[CI:DOCS]more image implementations
convert from using for to query structs among other changes including
new endpoints.
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]add bindings for golang
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]add volume endpoints for libpod
create, inspect, ls, prune, and rm
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]apiv2 healthcheck enablement
wire up container healthchecks for the api.
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]Add mount endpoints
via the api, allow ability to mount a container and list container
mounts.
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]Add search endpoint
add search endpoint with golang bindings
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]more apiv2 development
misc population of methods, etc
Signed-off-by: baude <bbaude@redhat.com>
rebase cleanup and epoch reset
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]add more network endpoints
also, add some initial error handling and convenience functions for
standard endpoints.
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]use helper funcs for bindings
use the methods developed to make writing bindings less duplicative and
easier to use.
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]add return info for prereview
begin to add return info and status codes for errors so that we can
review the apiv2
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]first pass at adding swagger docs for api
Signed-off-by: baude <bbaude@redhat.com>
2019-11-01 13:03:34 -07:00
2022-04-13 16:31:49 -07:00
pkg/api/swagger.yaml :
2020-01-17 09:41:40 -06:00
make -C pkg/api
2022-08-02 06:02:04 -06:00
$(MANPAGES_MD_GENERATED) : %.md : %.md .in $( MANPAGES_SOURCE_DIR ) /options /*.md
2022-10-20 09:42:18 -06:00
hack/markdown-preprocess
2021-06-01 22:56:27 +02:00
2022-08-02 06:02:04 -06:00
$(MANPAGES) : %: %.md .install .md 2man docdir
2021-06-01 22:56:27 +02:00
2022-08-02 06:02:04 -06:00
# This does a bunch of filtering needed for man pages:
# 1. Strip markdown link targets like '[podman(1)](podman.1.md)'
# to just '[podman(1)]', because man pages have no link mechanism;
# 2. Then remove the brackets: '[podman(1)]' -> 'podman(1)';
# 3. Then do the same for all other markdown links,
# like '[cgroups(7)](https://.....)' -> just 'cgroups(7)';
# 4. Remove HTML-ish stuff like '<sup>..</sup>' and '<a>..</a>'
# 5. Replace "\" (backslash) at EOL with two spaces (no idea why)
@$( SED) -e 's/\((podman[^)]*\.md\(#.*\)\?)\)//g' \
-e 's/\[\(podman[^]]*\)\]/\1/g' \
-e 's/\[\([^]]*\)](http[^)]\+)/\1/g' \
-e 's;<\(/\)\?\(a\|a\s\+[^>]*\|sup\)>;;g' \
-e 's/\\$$/ /g' $< | \
2022-12-02 11:21:05 +02:00
$( GOMD2MAN) -out $( subst source/markdown,build/man,$@ )
2023-02-20 05:52:24 -07:00
@if grep 'included file options/' docs/build/man/*; then \
echo "FATAL: man pages must not contain ^^^^" ; exit 1; \
fi
2021-04-08 10:38:16 -04:00
.PHONY : docdir
docdir :
mkdir -p docs/build/man
.PHONY : docs
docs : $( MANPAGES ) ## Generate documentation
2023-04-26 11:41:30 -04:00
@ln -sf $( CURDIR) /docs/source/markdown/links/* docs/build/man/
2021-04-08 10:38:16 -04:00
2021-04-08 14:30:40 -04:00
# docs/remote-docs.sh requires a locally executable 'podman-remote' binary
2022-07-18 07:53:39 -06:00
# in addition to the target-architecture binary (if different). That's
# what the NATIVE_GOOS make does in the first line.
podman-remote-%-docs : podman -remote
2023-02-05 13:42:25 +08:00
$( MAKE) clean-binaries
$( MAKE) podman-remote GOOS = $( NATIVE_GOOS) GOARCH = $( NATIVE_GOARCH)
2021-09-09 13:46:21 -04:00
$( eval GOOS := $* )
$( MAKE) docs $( MANPAGES)
2021-04-08 10:38:16 -04:00
rm -rf docs/build/remote
mkdir -p docs/build/remote
ln -sf $( CURDIR) /docs/source/markdown/links docs/build/man/
docs/remote-docs.sh \
2021-09-09 13:46:21 -04:00
$( GOOS) \
2021-04-08 10:38:16 -04:00
docs/build/remote/$* \
$( if $( findstring windows,$* ) ,docs/source/markdown,docs/build/man)
.PHONY : man -page -check
man-page-check : bin /podman
hack/man-page-checker
hack/xref-helpmsgs-manpages
2023-05-24 11:21:48 -06:00
hack/man-page-table-check
2021-04-08 10:38:16 -04:00
.PHONY : swagger -check
swagger-check :
hack/swagger-check
2020-01-17 09:41:40 -06:00
.PHONY : swagger
swagger : pkg /api /swagger .yaml
2021-04-08 10:38:16 -04:00
.PHONY : docker -docs
docker-docs : docs
( cd docs; ./dckrman.sh ./build/man/*.1)
# Workaround vim syntax highlighting bug: "
###
### Utility and Testing targets
###
.PHONY : validate .completions
validate.completions : SHELL :=/usr /bin /env bash # Set shell to bash for this target
validate.completions :
# Check if the files can be loaded by the shell
. completions/bash/podman
if [ -x /bin/zsh ] ; then /bin/zsh completions/zsh/_podman; fi
if [ -x /bin/fish ] ; then /bin/fish completions/fish/podman.fish; fi
2021-08-09 15:04:31 -04:00
# Note: Assumes test/python/requirements.txt is installed & available
2021-04-08 10:38:16 -04:00
.PHONY : run -docker -py -tests
run-docker-py-tests :
2021-08-09 15:04:31 -04:00
touch test/__init__.py
2022-02-28 16:26:43 -07:00
env CONTAINERS_CONF = $( CURDIR) /test/apiv2/containers.conf pytest --disable-warnings test/python/docker/
2022-03-02 09:50:48 -07:00
rm -f test/__init__.py
2017-11-01 11:24:59 -04:00
2020-01-29 19:15:24 +01:00
.PHONY : localunit
2021-09-16 16:15:28 -04:00
localunit : test /goecho /goecho test /version /version
2020-07-21 14:54:57 +02:00
rm -rf ${ COVERAGE_PATH } && mkdir -p ${ COVERAGE_PATH }
2022-11-24 18:27:10 +01:00
UNIT = 1 $( GINKGO) \
2019-04-03 12:32:49 +02:00
-r \
2019-12-16 13:52:22 +01:00
$( TESTFLAGS) \
2023-04-12 15:56:09 +02:00
--skip-package test/e2e,pkg/bindings,hack,pkg/machine/e2e \
2019-04-03 12:32:49 +02:00
--cover \
--covermode atomic \
2020-07-21 14:54:57 +02:00
--coverprofile coverprofile \
2023-04-12 15:56:09 +02:00
--output-dir ${ COVERAGE_PATH } \
2019-04-03 12:32:49 +02:00
--tags " $( BUILDTAGS) " \
--succinct
2020-07-21 14:54:57 +02:00
$( GO) tool cover -html= ${ COVERAGE_PATH } /coverprofile -o ${ COVERAGE_PATH } /coverage.html
$( GO) tool cover -func= ${ COVERAGE_PATH } /coverprofile > ${ COVERAGE_PATH } /functions
cat ${ COVERAGE_PATH } /functions | sed -n 's/\(total:\).*\([0-9][0-9].[0-9]\)/\1 \2/p'
2017-11-01 11:24:59 -04:00
2020-09-14 11:43:11 -04:00
.PHONY : test
test : localunit localintegration remoteintegration localsystem remotesystem ## Run unit, integration, and system tests.
2021-02-02 08:58:21 -07:00
.PHONY : ginkgo -run
2022-11-24 18:27:10 +01:00
ginkgo-run : .install .ginkgo
2023-04-12 15:56:09 +02:00
$( GINKGO) version
2023-05-16 11:38:45 +02:00
$( GINKGO) -vv $( TESTFLAGS) --tags " $( TAGS) remote " $( GINKGOTIMEOUT) --flake-attempts 3 --trace --no-color \
$( GINKGO_JSON) $( if $( findstring y,$( GINKGO_PARALLEL) ) ,-p,) $( if $( FOCUS) ,--focus " $( FOCUS) " ,) \
$( if $( FOCUS_FILE) ,--focus-file " $( FOCUS_FILE) " ,) $( GINKGOWHAT) $( HACK)
2021-02-02 08:58:21 -07:00
2020-01-29 19:15:24 +01:00
.PHONY : ginkgo
2018-01-24 08:45:55 -06:00
ginkgo :
2021-02-02 08:58:21 -07:00
$( MAKE) ginkgo-run TAGS = " $( BUILDTAGS) " HACK = hack/.
2018-01-24 08:45:55 -06:00
2020-01-29 19:15:24 +01:00
.PHONY : ginkgo -remote
2019-01-14 13:23:13 -06:00
ginkgo-remote :
2022-10-27 15:16:19 +02:00
$( MAKE) ginkgo-run TAGS = " $( REMOTETAGS) remote_testing " HACK =
2019-01-14 13:23:13 -06:00
2022-12-20 15:59:43 +01:00
.PHONY : testbindings
testbindings : .install .ginkgo
2023-04-12 15:56:09 +02:00
$( GINKGO) -v $( TESTFLAGS) --tags " $( TAGS) remote " $( GINKGOTIMEOUT) --trace --no-color --timeout 30m -v -r ./pkg/bindings/test
2022-12-20 15:59:43 +01:00
2020-01-29 19:15:24 +01:00
.PHONY : localintegration
2020-11-18 16:12:33 -05:00
localintegration : test -binaries ginkgo
2019-05-08 15:21:33 -05:00
2020-01-29 19:15:24 +01:00
.PHONY : remoteintegration
2020-11-18 16:12:33 -05:00
remoteintegration : test -binaries ginkgo -remote
2018-05-14 18:01:08 -07:00
2022-06-30 12:13:45 -04:00
.PHONY : localmachine
2022-11-08 14:00:00 -05:00
localmachine : test -binaries .install .ginkgo
2023-05-02 12:30:18 +02:00
$( MAKE) ginkgo-run GINKGO_PARALLEL = n GINKGOWHAT = pkg/machine/e2e/. HACK =
2022-06-30 12:13:45 -04:00
2020-01-29 19:15:24 +01:00
.PHONY : localsystem
2019-04-15 12:49:53 -06:00
localsystem :
2019-07-09 12:03:35 -06:00
# Wipe existing config, database, and cache: start with clean slate.
$( RM) -rf ${ HOME } /.local/share/containers ${ HOME } /.config/containers
2022-12-13 14:14:50 +01:00
if timeout -v 1 true; then PODMAN = $( CURDIR) /bin/podman QUADLET = $( CURDIR) /bin/quadlet bats test/system/; else echo " Skipping $@ : 'timeout -v' unavailable' " ; fi
2019-04-15 12:49:53 -06:00
2020-01-29 19:15:24 +01:00
.PHONY : remotesystem
2019-04-15 12:49:53 -06:00
remotesystem :
2019-08-07 14:24:23 -06:00
# Wipe existing config, database, and cache: start with clean slate.
$( RM) -rf ${ HOME } /.local/share/containers ${ HOME } /.config/containers
WIP: Enable (and disable) remote testing
podman-remote has not been tested. A principal part of the
problem was #5387 - the YAML I wrote did not have the
intended effect, it did not set TEST_REMOTE_CLIENT=true
and because of my multiple iterations I did not catch this
during testing.
Part 1 of this PR is to fix .cirrus.yml to enable remote tests.
Part 2 -- what I had first noticed and tried to fix -- is that
rootless_test.sh was never running remote because, of course,
envariables are not sent via ssh. I reworked integration_test.sh
and rootless_test.sh to use a command-line decision instead.
Part 3, sigh, is to disable one failing integration test
and *all* system tests, because so many of the latter are
failing. Addressing those failures needs to be done in
subsequent PRs. Issues #6538, #6539, #6540 are filed for
some of the problems I isolated. There will be more.
Also, minor, fixed some stale references to varlink.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-06-08 14:57:37 -06:00
# Start podman server using tmp socket; loop-wait for it;
2019-08-07 14:24:23 -06:00
# test podman-remote; kill server, clean up tmp socket file.
WIP: Enable (and disable) remote testing
podman-remote has not been tested. A principal part of the
problem was #5387 - the YAML I wrote did not have the
intended effect, it did not set TEST_REMOTE_CLIENT=true
and because of my multiple iterations I did not catch this
during testing.
Part 1 of this PR is to fix .cirrus.yml to enable remote tests.
Part 2 -- what I had first noticed and tried to fix -- is that
rootless_test.sh was never running remote because, of course,
envariables are not sent via ssh. I reworked integration_test.sh
and rootless_test.sh to use a command-line decision instead.
Part 3, sigh, is to disable one failing integration test
and *all* system tests, because so many of the latter are
failing. Addressing those failures needs to be done in
subsequent PRs. Issues #6538, #6539, #6540 are filed for
some of the problems I isolated. There will be more.
Also, minor, fixed some stale references to varlink.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-06-08 14:57:37 -06:00
# podman server spews copious unhelpful output; ignore it.
2019-08-07 14:24:23 -06:00
rc = 0; \
if timeout -v 1 true; then \
2021-04-08 14:30:40 -04:00
SOCK_FILE = $( shell mktemp --dry-run --tmpdir podman_tmp_XXXX) ; \
WIP: Enable (and disable) remote testing
podman-remote has not been tested. A principal part of the
problem was #5387 - the YAML I wrote did not have the
intended effect, it did not set TEST_REMOTE_CLIENT=true
and because of my multiple iterations I did not catch this
during testing.
Part 1 of this PR is to fix .cirrus.yml to enable remote tests.
Part 2 -- what I had first noticed and tried to fix -- is that
rootless_test.sh was never running remote because, of course,
envariables are not sent via ssh. I reworked integration_test.sh
and rootless_test.sh to use a command-line decision instead.
Part 3, sigh, is to disable one failing integration test
and *all* system tests, because so many of the latter are
failing. Addressing those failures needs to be done in
subsequent PRs. Issues #6538, #6539, #6540 are filed for
some of the problems I isolated. There will be more.
Also, minor, fixed some stale references to varlink.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-06-08 14:57:37 -06:00
export PODMAN_SOCKET = unix:$$ SOCK_FILE; \
2020-07-28 08:36:52 -06:00
./bin/podman system service --timeout= 0 $$ PODMAN_SOCKET > $( if $( PODMAN_SERVER_LOG) ,$( PODMAN_SERVER_LOG) ,/dev/null) 2>& 1 & \
2019-08-07 14:24:23 -06:00
retry = 5; \
2020-07-28 08:36:52 -06:00
while [ $$ retry -ge 0 ] ; do \
2020-05-11 12:07:42 -05:00
echo Waiting for server...; \
2019-08-07 14:24:23 -06:00
sleep 1; \
2020-07-28 08:36:52 -06:00
./bin/podman-remote --url $$ PODMAN_SOCKET info >/dev/null 2>& 1 && break; \
2019-08-07 14:24:23 -06:00
retry = $$ ( expr $$ retry - 1) ; \
done ; \
2020-07-28 08:36:52 -06:00
if [ $$ retry -lt 0 ] ; then \
WIP: Enable (and disable) remote testing
podman-remote has not been tested. A principal part of the
problem was #5387 - the YAML I wrote did not have the
intended effect, it did not set TEST_REMOTE_CLIENT=true
and because of my multiple iterations I did not catch this
during testing.
Part 1 of this PR is to fix .cirrus.yml to enable remote tests.
Part 2 -- what I had first noticed and tried to fix -- is that
rootless_test.sh was never running remote because, of course,
envariables are not sent via ssh. I reworked integration_test.sh
and rootless_test.sh to use a command-line decision instead.
Part 3, sigh, is to disable one failing integration test
and *all* system tests, because so many of the latter are
failing. Addressing those failures needs to be done in
subsequent PRs. Issues #6538, #6539, #6540 are filed for
some of the problems I isolated. There will be more.
Also, minor, fixed some stale references to varlink.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-06-08 14:57:37 -06:00
echo " Error: ./bin/podman system service did not come up on $$ SOCK_FILE " >& 2; \
exit 1; \
fi ; \
2021-04-08 08:47:19 -04:00
env PODMAN = " $( CURDIR) /bin/podman-remote --url $$ PODMAN_SOCKET " bats test/system/ ; \
2019-08-07 14:24:23 -06:00
rc = $$ ?; \
kill %1; \
rm -f $$ SOCK_FILE; \
else \
echo " Skipping $@ : 'timeout -v' unavailable' " ; \
fi ; \
exit $$ rc
2018-10-29 14:56:23 +08:00
2022-04-06 17:03:46 -04:00
.PHONY : localapiv 2-bash
localapiv2-bash :
2022-03-02 09:50:48 -07:00
env PODMAN = ./bin/podman stdbuf -o0 -e0 ./test/apiv2/test-apiv2
2022-04-06 17:03:46 -04:00
.PHONY : localapiv 2-python
localapiv2-python :
2022-03-02 09:50:48 -07:00
env CONTAINERS_CONF = $( CURDIR) /test/apiv2/containers.conf PODMAN = ./bin/podman \
2022-04-06 17:03:46 -04:00
pytest --verbose --disable-warnings ./test/apiv2/python
2022-03-02 09:50:48 -07:00
touch test/__init__.py
env CONTAINERS_CONF = $( CURDIR) /test/apiv2/containers.conf PODMAN = ./bin/podman \
2022-04-06 17:03:46 -04:00
pytest --verbose --disable-warnings ./test/python/docker
2022-03-02 09:50:48 -07:00
rm -f test/__init__.py
2020-02-26 09:17:13 -07:00
2022-04-06 17:03:46 -04:00
# Order is important running python tests first causes the bash tests
# to fail, see 12-imagesMore. FIXME order of tests should not matter
.PHONY : localapiv 2
localapiv2 : localapiv 2-bash localapiv 2-python
2020-02-26 09:17:13 -07:00
.PHONY : remoteapiv 2
remoteapiv2 :
true
2020-01-29 19:15:24 +01:00
.PHONY : system .test -binary
2019-02-06 11:57:46 -07:00
system.test-binary : .install .ginkgo
2018-11-16 11:19:37 +08:00
$( GO) test -c ./test/system
2020-01-29 19:15:24 +01:00
.PHONY : test -binaries
2021-09-16 16:15:28 -04:00
test-binaries : test /checkseccomp /checkseccomp test /goecho /goecho install .catatonit test /version /version
@echo " Canonical source version: $( call err_if_empty,RELEASE_VERSION) "
2017-11-01 11:24:59 -04:00
CI: smoke test: insist on adding tests on PRs
On each PR (with a few exceptions), check the list of git-touched
files, and abort if no tests are added. Include instructions
on how to bypass the check if tests really aren't needed.
Include a hardcoded exception list for PRs that only touch a
well-known subset of "safe" files: docs, .cirrus.yml, vendor,
version, hack, contrib, or *.md. This list is likely to need
tuning over time.
Add a test suite, but not one recognized by the new script
(because it's a "*.t" file), so: [NO TESTS NEEDED]
Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-01-07 13:57:35 -07:00
.PHONY : tests -included
tests-included :
contrib/cirrus/pr-should-include-tests
2021-07-20 10:42:57 -06:00
.PHONY : tests -expect -exit
tests-expect-exit :
2023-05-03 07:19:35 -06:00
@if grep -E --line-number 'Expect.*ExitCode' test/e2e/*.go | grep -E -v ', ".*"\)' ; then \
2021-07-20 10:42:57 -06:00
echo "^^^ Unhelpful use of Expect(ExitCode())" ; \
echo " Please use '.Should(Exit(...))' pattern instead." ; \
echo " If that's not possible, please add an annotation (description) to your assertion:" ; \
echo " Expect(...).To(..., \"Friendly explanation of this check\")" ; \
exit 1; \
fi
2022-07-25 09:00:36 -06:00
.PHONY : pr -removes -fixed -skips
pr-removes-fixed-skips :
contrib/cirrus/pr-removes-fixed-skips
2021-04-08 10:38:16 -04:00
###
### Release/Packaging targets
###
2020-01-08 09:06:52 -05:00
2021-09-09 13:46:21 -04:00
.PHONY : podman -release
podman-release : podman -release -$( GOARCH ) .tar .gz # Build all Linux binaries for $GOARCH, docs., and installation tree, into a tarball.
# The following two targets are nuanced and complex:
# Cross-building the podman-remote documentation requires a functional
# native architecture executable. However `make` only deals with
# files/timestamps, it doesn't understand if an existing binary will
# function on the system or not. This makes building cross-platform
# releases incredibly accident-prone and fragile. The only practical
# way to deal with this, is via multiple conditional (nested) `make`
# calls along with careful manipulation of `$GOOS` and `$GOARCH`.
podman-release-%.tar.gz : test /version /version
2021-04-08 14:30:40 -04:00
$( eval TMPDIR := $( shell mktemp -d podman_tmp_XXXX) )
2021-09-16 16:15:28 -04:00
$( eval SUBDIR := podman-v$( call err_if_empty,RELEASE_NUMBER) )
2023-06-30 16:35:53 +01:00
$( eval _DSTARGS := " DESTDIR= $( TMPDIR) / $( SUBDIR) " " PREFIX= $( RELEASE_PREFIX) " )
2021-09-09 13:46:21 -04:00
$( eval GOARCH := $* )
2022-05-31 11:48:46 -04:00
mkdir -p " $( call err_if_empty,TMPDIR) / $( SUBDIR) "
2021-09-09 13:46:21 -04:00
$( MAKE) GOOS = $( GOOS) GOARCH = $( NATIVE_GOARCH) \
clean-binaries docs podman-remote-$( GOOS) -docs
if [ [ " $( GOARCH) " != " $( NATIVE_GOARCH) " ] ] ; then \
$( MAKE) CGO_ENABLED = 0 GOOS = $( GOOS) GOARCH = $( GOARCH) \
BUILDTAGS = " $( BUILDTAGS_CROSS) " clean-binaries binaries; \
else \
$( MAKE) GOOS = $( GOOS) GOARCH = $( GOARCH) binaries; \
fi
2022-01-25 08:09:05 -05:00
$( MAKE) $( _DSTARGS) install.bin install.remote install.man install.systemd
2021-02-18 16:08:01 -05:00
tar -czvf $@ --xattrs -C " $( TMPDIR) " " ./ $( SUBDIR) "
2021-09-09 13:46:21 -04:00
if [ [ " $( GOARCH) " != " $( NATIVE_GOARCH) " ] ] ; then $( MAKE) clean-binaries; fi
2019-08-01 07:31:04 -04:00
-rm -rf " $( TMPDIR) "
2021-09-09 13:46:21 -04:00
podman-remote-release-%.zip : test /version /version ## Build podman-remote for %=$GOOS_$GOARCH, and docs. into an installation zip.
2021-04-08 14:30:40 -04:00
$( eval TMPDIR := $( shell mktemp -d podman_tmp_XXXX) )
2021-09-16 16:15:28 -04:00
$( eval SUBDIR := podman-$( call err_if_empty,RELEASE_NUMBER) )
2023-06-30 16:35:53 +01:00
$( eval _DSTARGS := " DESTDIR= $( TMPDIR) / $( SUBDIR) " " PREFIX= $( RELEASE_PREFIX) " )
2021-09-09 13:46:21 -04:00
$( eval GOOS := $( firstword $( subst _, ,$* ) ) )
$( eval GOARCH := $( lastword $( subst _, ,$* ) ) )
$( eval _GOPLAT := GOOS = $( call err_if_empty,GOOS) GOARCH = $( call err_if_empty,GOARCH) )
2022-05-31 11:48:46 -04:00
mkdir -p " $( call err_if_empty,TMPDIR) / $( SUBDIR) "
2022-12-02 12:43:57 +02:00
$( MAKE) GOOS = $( GOOS) GOARCH = $( GOARCH) \
2021-09-09 13:46:21 -04:00
clean-binaries podman-remote-$( GOOS) -docs
if [ [ " $( GOARCH) " != " $( NATIVE_GOARCH) " ] ] ; then \
$( MAKE) CGO_ENABLED = 0 $( GOPLAT) BUILDTAGS = " $( BUILDTAGS_CROSS) " \
2022-07-18 07:53:39 -06:00
clean-binaries podman-remote; \
2021-09-09 13:46:21 -04:00
else \
2022-07-18 07:53:39 -06:00
$( MAKE) $( GOPLAT) podman-remote; \
2021-09-09 13:46:21 -04:00
fi
2022-08-30 16:27:41 -05:00
if [ [ " $( GOOS) " = = "windows" ] ] ; then \
2022-12-02 11:21:05 +02:00
$( MAKE) $( GOPLAT) TMPDIR = "" win-gvproxy; \
2022-08-30 16:27:41 -05:00
fi
2022-12-06 15:14:34 -05:00
if [ [ " $( GOOS) " = = "darwin" ] ] ; then \
$( MAKE) $( GOPLAT) podman-mac-helper; \
fi
2021-09-09 13:46:21 -04:00
cp -r ./docs/build/remote/$( GOOS) " $( TMPDIR) / $( SUBDIR) /docs/ "
2020-06-24 09:47:24 -04:00
cp ./contrib/remote/containers.conf " $( TMPDIR) / $( SUBDIR) / "
2022-01-25 08:09:05 -05:00
$( MAKE) $( GOPLAT) $( _DSTARGS) SELINUXOPT = "" install.remote
2021-04-08 14:30:40 -04:00
cd " $( TMPDIR) " && \
2022-12-06 15:14:34 -05:00
zip --recurse-paths " $( CURDIR) / $@ " " ./ $( SUBDIR) "
2021-09-09 13:46:21 -04:00
if [ [ " $( GOARCH) " != " $( NATIVE_GOARCH) " ] ] ; then $( MAKE) clean-binaries; fi
2019-08-01 07:31:04 -04:00
-rm -rf " $( TMPDIR) "
2021-09-16 16:15:28 -04:00
podman.msi : test /version /version ## Build podman-remote, package for installation on Windows
2022-05-31 11:48:46 -04:00
$( MAKE) podman-v$( call err_if_empty,RELEASE_NUMBER) .msi
2022-11-29 12:12:32 -05:00
cp podman-v$( call err_if_empty,RELEASE_NUMBER) .msi podman.msi
2022-12-02 12:43:57 +02:00
podman-v%.msi : test /version /version
# Passing explicitly OS and ARCH, because ARM is not supported by wixl https://gitlab.gnome.org/GNOME/msitools/-/blob/master/tools/wixl/builder.vala#L3
$( MAKE) GOOS = windows GOARCH = amd64 podman-remote-windows-docs
2022-12-02 11:21:05 +02:00
$( MAKE) GOOS = windows GOARCH = amd64 clean-binaries podman-remote podman-winpath win-gvproxy
2021-04-08 10:38:16 -04:00
$( eval DOCFILE := docs/build/remote/windows)
find $( DOCFILE) -print | \
wixl-heat --var var.ManSourceDir --component-group ManFiles \
--directory-ref INSTALLDIR --prefix $( DOCFILE) / > \
$( DOCFILE) /pages.wsx
2021-09-16 16:15:28 -04:00
wixl -D VERSION = $( call err_if_empty,RELEASE_VERSION) -D ManSourceDir = $( DOCFILE) \
2021-09-27 17:05:21 +00:00
-o $@ contrib/msi/podman.wxs $( DOCFILE) /pages.wsx --arch x64
2020-12-18 16:46:09 +01:00
2022-01-18 14:39:48 -06:00
# Checks out and builds win-sshproxy helper. See comment on GV_GITURL declaration
2022-12-02 11:21:05 +02:00
.PHONY : win -gvproxy
win-gvproxy : test /version /version
2022-01-18 14:39:48 -06:00
rm -rf tmp-gv; mkdir tmp-gv
( cd tmp-gv; \
git init; \
git remote add origin $( GV_GITURL) ; \
git fetch --depth 1 origin $( GV_SHA) ; \
2022-12-02 11:21:05 +02:00
git checkout FETCH_HEAD; make win-gvproxy win-sshproxy)
2022-01-18 14:39:48 -06:00
mkdir -p bin/windows/
cp tmp-gv/bin/win-sshproxy.exe bin/windows/
2022-12-02 11:21:05 +02:00
cp tmp-gv/bin/gvproxy.exe bin/windows/
2022-01-18 14:39:48 -06:00
rm -rf tmp-gv
2023-07-13 08:45:02 -04:00
.PHONY : rpm
rpm : ## Build rpm packages
2023-05-23 09:15:03 -04:00
$( MAKE) -C rpm
2018-01-11 10:54:39 -05:00
2021-04-08 10:38:16 -04:00
###
### Installation targets
###
2018-03-17 15:52:54 +01:00
2021-04-08 10:38:16 -04:00
# Remember that rpms install exec to /usr/bin/podman while a `make install`
# installs them to /usr/local/bin/podman which is likely before. Always use
# a full path to test installed podman or you risk to call another executable.
2023-07-13 08:45:02 -04:00
.PHONY : rpm -install
rpm-install : package ## Install rpm packages
$( call err_if_empty,PKG_MANAGER) -y install rpm/RPMS/*/*.rpm
2021-04-08 10:38:16 -04:00
/usr/bin/podman version
/usr/bin/podman info # will catch a broken conmon
Simplify Makefile help target
An in-line Python script, while flexible, is arguably
more complex and less stable than the long-lived `grep`,
`awk`, and `printf`. Make use of these simple tools
to display a column-aligned table of target and description
help output.
Also, the first target that appears in a Makefile is considered
the default (when no target is specified on the command-line).
However, despite it's name, the `default` target was not listed
first. Fix this, and redefine "default" target to "all" as
intended, instead of "help".
Lastly, add a small workaround for a vim syntax-hilighting bug.
Signed-off-by: Chris Evich <cevich@redhat.com>
2021-04-08 08:55:56 -04:00
2020-01-29 19:15:24 +01:00
.PHONY : install
2022-04-13 16:31:49 -07:00
install : install .bin install .remote install .man install .systemd ## Install binaries to system locations
2019-05-17 11:40:45 -04:00
2021-04-08 10:38:16 -04:00
.PHONY : install .catatonit
install.catatonit :
./hack/install_catatonit.sh
2022-01-25 08:09:05 -05:00
.PHONY : install .remote
install.remote :
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( BINDIR)
2021-04-08 14:30:40 -04:00
install ${ SELINUXOPT } -m 755 $( SRCBINDIR) /podman$( BINSFX) \
$( DESTDIR) $( BINDIR) /podman$( BINSFX)
2022-08-30 16:27:41 -05:00
test " ${ GOOS } " != "windows" || \
install -m 755 $( SRCBINDIR) /win-sshproxy.exe $( DESTDIR) $( BINDIR)
2022-12-02 11:21:05 +02:00
test " ${ GOOS } " != "windows" || \
install -m 755 $( SRCBINDIR) /gvproxy.exe $( DESTDIR) $( BINDIR)
2022-12-06 15:14:34 -05:00
test " ${ GOOS } " != "darwin" || \
install -m 755 $( SRCBINDIR) /podman-mac-helper $( DESTDIR) $( BINDIR)
2021-04-08 14:30:40 -04:00
test -z " ${ SELINUXOPT } " || \
chcon --verbose --reference= $( DESTDIR) $( BINDIR) /podman-remote \
bin/podman-remote
2017-11-01 11:24:59 -04:00
2022-01-25 08:09:05 -05:00
.PHONY : install .bin
install.bin :
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( BINDIR)
install ${ SELINUXOPT } -m 755 bin/podman $( DESTDIR) $( BINDIR) /podman
2023-06-30 08:20:48 +01:00
ln -sf podman $( DESTDIR) $( BINDIR) /podmansh
2019-06-07 00:46:41 -05:00
test -z " ${ SELINUXOPT } " || chcon --verbose --reference= $( DESTDIR) $( BINDIR) /podman bin/podman
2021-09-02 14:14:59 +02:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( LIBEXECPODMAN)
2022-06-28 08:15:13 +01:00
i f n e q ( $( shell uname -s ) , F r e e B S D )
2021-09-02 14:14:59 +02:00
install ${ SELINUXOPT } -m 755 bin/rootlessport $( DESTDIR) $( LIBEXECPODMAN) /rootlessport
test -z " ${ SELINUXOPT } " || chcon --verbose --reference= $( DESTDIR) $( LIBEXECPODMAN) /rootlessport bin/rootlessport
2022-10-03 12:12:39 +02:00
install ${ SELINUXOPT } -m 755 bin/quadlet $( DESTDIR) $( LIBEXECPODMAN) /quadlet
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( SYSTEMDGENERATORSDIR)
ln -sfr $( DESTDIR) $( LIBEXECPODMAN) /quadlet $( DESTDIR) $( SYSTEMDGENERATORSDIR) /podman-system-generator
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( USERSYSTEMDGENERATORSDIR)
ln -sfr $( DESTDIR) $( LIBEXECPODMAN) /quadlet $( DESTDIR) $( USERSYSTEMDGENERATORSDIR) /podman-user-generator
2020-11-04 09:51:26 -05:00
install ${ SELINUXOPT } -m 755 -d ${ DESTDIR } ${ TMPFILESDIR }
install ${ SELINUXOPT } -m 644 contrib/tmpfile/podman.conf ${ DESTDIR } ${ TMPFILESDIR } /podman.conf
2022-11-06 11:07:58 +00:00
e n d i f
2017-11-01 11:24:59 -04:00
2022-02-23 15:34:41 +01:00
.PHONY : install .modules -load
install.modules-load : # This should only be used by distros which might use iptables-legacy, this is not needed on RHEL
install ${ SELINUXOPT } -m 755 -d ${ DESTDIR } ${ MODULESLOADDIR }
install ${ SELINUXOPT } -m 644 contrib/modules-load.d/podman-iptables.conf ${ DESTDIR } ${ MODULESLOADDIR } /podman-iptables.conf
2022-01-25 08:09:05 -05:00
.PHONY : install .man
install.man :
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( MANDIR) /man1
2023-02-03 05:04:13 -06:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( MANDIR) /man5
2022-06-28 08:14:44 +01:00
install ${ SELINUXOPT } -m 644 $( filter %.1,$( MANPAGES_DEST) ) $( DESTDIR) $( MANDIR) /man1
install ${ SELINUXOPT } -m 644 docs/source/markdown/links/*1 $( DESTDIR) $( MANDIR) /man1
2023-02-03 05:04:13 -06:00
install ${ SELINUXOPT } -m 644 $( filter %.5,$( MANPAGES_DEST) ) $( DESTDIR) $( MANDIR) /man5
install ${ SELINUXOPT } -m 644 docs/source/markdown/links/*5 $( DESTDIR) $( MANDIR) /man5
2017-11-01 11:24:59 -04:00
2020-01-29 19:15:24 +01:00
.PHONY : install .completions
2017-11-01 11:24:59 -04:00
install.completions :
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -d -m 755 ${ DESTDIR } ${ BASHINSTALLDIR }
install ${ SELINUXOPT } -m 644 completions/bash/podman ${ DESTDIR } ${ BASHINSTALLDIR }
2020-11-08 21:50:51 +01:00
install ${ SELINUXOPT } -m 644 completions/bash/podman-remote ${ DESTDIR } ${ BASHINSTALLDIR }
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -d -m 755 ${ DESTDIR } ${ ZSHINSTALLDIR }
install ${ SELINUXOPT } -m 644 completions/zsh/_podman ${ DESTDIR } ${ ZSHINSTALLDIR }
2020-11-08 21:50:51 +01:00
install ${ SELINUXOPT } -m 644 completions/zsh/_podman-remote ${ DESTDIR } ${ ZSHINSTALLDIR }
install ${ SELINUXOPT } -d -m 755 ${ DESTDIR } ${ FISHINSTALLDIR }
install ${ SELINUXOPT } -m 644 completions/fish/podman.fish ${ DESTDIR } ${ FISHINSTALLDIR }
install ${ SELINUXOPT } -m 644 completions/fish/podman-remote.fish ${ DESTDIR } ${ FISHINSTALLDIR }
2021-02-10 17:57:11 +01:00
# There is no common location for powershell files so do not install them. Users have to source the file from their powershell profile.
2017-11-01 11:24:59 -04:00
2020-01-29 19:15:24 +01:00
.PHONY : install .docker
2021-03-01 15:02:27 +01:00
install.docker :
2021-03-31 00:33:46 +02:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( BINDIR)
2023-03-31 10:06:17 +11:00
$( eval INTERPOLATED_DOCKER_SCRIPT := $( shell mktemp) )
env BINDIR = ${ BINDIR } ETCDIR = ${ ETCDIR } envsubst < docker.in > ${ INTERPOLATED_DOCKER_SCRIPT }
install ${ SELINUXOPT } -m 755 ${ INTERPOLATED_DOCKER_SCRIPT } $( DESTDIR) $( BINDIR) /docker
rm ${ INTERPOLATED_DOCKER_SCRIPT }
2022-08-24 14:52:40 +09:00
install ${ SELINUXOPT } -m 755 -d ${ DESTDIR } ${ SYSTEMDDIR } ${ DESTDIR } ${ USERSYSTEMDDIR } ${ DESTDIR } ${ TMPFILESDIR } ${ DESTDIR } ${ USERTMPFILESDIR }
2020-01-27 09:52:11 -05:00
install ${ SELINUXOPT } -m 644 contrib/systemd/system/podman-docker.conf -t ${ DESTDIR } ${ TMPFILESDIR }
2022-08-24 14:52:40 +09:00
install ${ SELINUXOPT } -m 644 contrib/systemd/system/podman-docker.conf -t ${ DESTDIR } ${ USERTMPFILESDIR }
2018-01-11 10:54:39 -05:00
2022-01-25 08:09:05 -05:00
.PHONY : install .docker -docs
install.docker-docs :
2021-03-31 00:33:46 +02:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( MANDIR) /man1
2021-03-01 15:02:27 +01:00
install ${ SELINUXOPT } -m 644 docs/build/man/docker*.1 -t $( DESTDIR) $( MANDIR) /man1
2021-09-27 14:52:45 -04:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( MANDIR) /man5
install ${ SELINUXOPT } -m 644 docs/build/man/docker*.5 -t $( DESTDIR) $( MANDIR) /man5
2021-03-01 15:02:27 +01:00
2021-11-08 14:16:13 +01:00
.PHONY : install .docker -full
install.docker-full : install .docker install .docker -docs
2021-03-31 00:35:26 +02:00
2020-05-29 14:38:33 -04:00
.PHONY : install .systemd
2021-03-02 13:27:15 +01:00
i f n e q ( , $( findstring systemd ,$ ( BUILDTAGS ) ) )
2021-10-07 08:10:41 -06:00
PODMAN_UNIT_FILES = contrib/systemd/auto-update/podman-auto-update.service \
contrib/systemd/system/podman.service \
2022-05-11 15:02:06 +02:00
contrib/systemd/system/podman-restart.service \
2022-12-20 10:24:25 +01:00
contrib/systemd/system/podman-kube@.service \
contrib/systemd/system/podman-clean-transient.service
2021-10-07 08:10:41 -06:00
%.service : %.service .in
sed -e 's;@@PODMAN@@;$(BINDIR)/podman;g' $< >$@ .tmp.$$ \
&& mv -f $@ .tmp.$$ $@
install.systemd : $( PODMAN_UNIT_FILES )
2020-06-17 15:58:11 -04:00
install ${ SELINUXOPT } -m 755 -d ${ DESTDIR } ${ SYSTEMDDIR } ${ DESTDIR } ${ USERSYSTEMDDIR }
2020-08-03 13:11:36 +02:00
# User services
install ${ SELINUXOPT } -m 644 contrib/systemd/auto-update/podman-auto-update.service ${ DESTDIR } ${ USERSYSTEMDDIR } /podman-auto-update.service
install ${ SELINUXOPT } -m 644 contrib/systemd/auto-update/podman-auto-update.timer ${ DESTDIR } ${ USERSYSTEMDDIR } /podman-auto-update.timer
2021-10-07 08:10:41 -06:00
install ${ SELINUXOPT } -m 644 contrib/systemd/system/podman.socket ${ DESTDIR } ${ USERSYSTEMDDIR } /podman.socket
install ${ SELINUXOPT } -m 644 contrib/systemd/system/podman.service ${ DESTDIR } ${ USERSYSTEMDDIR } /podman.service
install ${ SELINUXOPT } -m 644 contrib/systemd/system/podman-restart.service ${ DESTDIR } ${ USERSYSTEMDDIR } /podman-restart.service
2022-06-30 15:32:03 +02:00
install ${ SELINUXOPT } -m 644 contrib/systemd/system/podman-kube@.service ${ DESTDIR } ${ USERSYSTEMDDIR } /podman-kube@.service
2020-08-03 13:11:36 +02:00
# System services
2020-07-07 16:56:56 +01:00
install ${ SELINUXOPT } -m 644 contrib/systemd/auto-update/podman-auto-update.service ${ DESTDIR } ${ SYSTEMDDIR } /podman-auto-update.service
install ${ SELINUXOPT } -m 644 contrib/systemd/auto-update/podman-auto-update.timer ${ DESTDIR } ${ SYSTEMDDIR } /podman-auto-update.timer
2020-03-20 06:45:45 -04:00
install ${ SELINUXOPT } -m 644 contrib/systemd/system/podman.socket ${ DESTDIR } ${ SYSTEMDDIR } /podman.socket
install ${ SELINUXOPT } -m 644 contrib/systemd/system/podman.service ${ DESTDIR } ${ SYSTEMDDIR } /podman.service
2021-06-08 00:41:10 +03:00
install ${ SELINUXOPT } -m 644 contrib/systemd/system/podman-restart.service ${ DESTDIR } ${ SYSTEMDDIR } /podman-restart.service
2022-06-30 15:32:03 +02:00
install ${ SELINUXOPT } -m 644 contrib/systemd/system/podman-kube@.service ${ DESTDIR } ${ SYSTEMDDIR } /podman-kube@.service
2022-12-20 10:24:25 +01:00
install ${ SELINUXOPT } -m 644 contrib/systemd/system/podman-clean-transient.service ${ DESTDIR } ${ SYSTEMDDIR } /podman-clean-transient.service
2021-10-07 08:10:41 -06:00
rm -f $( PODMAN_UNIT_FILES)
2021-03-02 13:27:15 +01:00
e l s e
install.systemd :
e n d i f
2018-03-26 09:39:14 -05:00
2017-11-01 11:24:59 -04:00
.PHONY : install .tools
2023-01-12 15:35:42 +01:00
install.tools : .install .golangci -lint ## Install needed tools
2022-09-21 14:33:18 -06:00
$( MAKE) -C test/tools
.PHONY : .install .goimports
.install.goimports :
$( MAKE) -C test/tools build/goimports
2020-12-18 16:46:09 +01:00
2020-01-29 19:15:24 +01:00
.PHONY : .install .ginkgo
2022-04-13 16:31:49 -07:00
.install.ginkgo :
2022-11-24 18:27:10 +01:00
$( MAKE) -C test/tools build/ginkgo
2017-11-01 11:24:59 -04:00
2022-09-21 14:33:18 -06:00
.PHONY : .install .gitvalidation
.install.gitvalidation :
$( MAKE) -C test/tools build/git-validation
2020-01-29 19:15:24 +01:00
.PHONY : .install .golangci -lint
2022-04-13 16:31:49 -07:00
.install.golangci-lint :
2023-06-21 14:54:16 -04:00
VERSION = $( GOLANGCI_LINT_VERSION) ./hack/install_golangci.sh
2019-07-22 13:08:06 -05:00
2022-10-13 12:58:21 -04:00
.PHONY : .install .swagger
.install.swagger :
env VERSION = 0.30.3 \
BINDIR = $( BINDIR) \
GOOS = $( GOOS) \
GOARCH = $( GOARCH) \
./hack/install_swagger.sh
2022-05-04 14:17:02 +02:00
.PHONY : .install .md 2man
.install.md2man :
if [ ! -x " $( GOMD2MAN) " ] ; then \
2022-09-21 14:33:18 -06:00
$( MAKE) -C test/tools build/go-md2man ; \
2022-05-04 14:17:02 +02:00
fi
2020-02-18 09:28:47 -05:00
.PHONY : .install .pre -commit
.install.pre-commit :
if [ -z " $( PRE_COMMIT) " ] ; then \
2022-12-22 23:32:01 +02:00
$( PYTHON) -m pip install --user pre-commit; \
2020-02-18 09:28:47 -05:00
fi
2023-04-17 14:40:55 -04:00
.PHONY : release -artifacts
release-artifacts : clean -binaries
mkdir -p release/
$( MAKE) podman-remote-release-darwin_amd64.zip
mv podman-remote-release-darwin_amd64.zip release/
$( MAKE) podman-remote-release-darwin_arm64.zip
mv podman-remote-release-darwin_arm64.zip release/
$( MAKE) podman-remote-release-windows_amd64.zip
mv podman-remote-release-windows_amd64.zip release/
$( MAKE) podman-remote-static-linux_amd64
tar -cvzf podman-remote-static-linux_amd64.tar.gz bin/podman-remote-static-linux_amd64
$( MAKE) podman-remote-static-linux_arm64
tar -cvzf podman-remote-static-linux_arm64.tar.gz bin/podman-remote-static-linux_arm64
mv podman-remote-static-linux*.tar.gz release/
$( MAKE) podman.msi
mv podman-v*.msi release/
cd release/; sha256sum *.zip *.tar.gz *.msi > shasums
2021-04-08 10:38:16 -04:00
.PHONY : uninstall
uninstall :
for i in $( filter %.1,$( MANPAGES_DEST) ) ; do \
rm -f $( DESTDIR) $( MANDIR) /man1/$$ ( basename $$ { i} ) ; \
done ; \
for i in $( filter %.5,$( MANPAGES_DEST) ) ; do \
rm -f $( DESTDIR) $( MANDIR) /man5/$$ ( basename $$ { i} ) ; \
2021-02-01 13:37:05 -07:00
done
2021-04-08 10:38:16 -04:00
# Remove podman and remote bin
rm -f $( DESTDIR) $( BINDIR) /podman
rm -f $( DESTDIR) $( BINDIR) /podman-remote
# Remove related config files
rm -f ${ DESTDIR } ${ ETCDIR } /cni/net.d/87-podman-bridge.conflist
rm -f ${ DESTDIR } ${ TMPFILESDIR } /podman.conf
rm -f ${ DESTDIR } ${ SYSTEMDDIR } /io.podman.socket
rm -f ${ DESTDIR } ${ USERSYSTEMDDIR } /io.podman.socket
rm -f ${ DESTDIR } ${ SYSTEMDDIR } /io.podman.service
rm -f ${ DESTDIR } ${ SYSTEMDDIR } /podman.service
rm -f ${ DESTDIR } ${ SYSTEMDDIR } /podman.socket
rm -f ${ DESTDIR } ${ USERSYSTEMDDIR } /podman.socket
rm -f ${ DESTDIR } ${ USERSYSTEMDDIR } /podman.service
2021-02-01 13:37:05 -07:00
2021-09-09 13:46:21 -04:00
.PHONY : clean -binaries
clean-binaries : ## Remove platform/architecture specific binary files
rm -rf \
2021-09-30 13:39:53 -04:00
bin
2021-09-09 13:46:21 -04:00
2021-04-08 10:38:16 -04:00
.PHONY : clean
2021-09-09 13:46:21 -04:00
clean : clean -binaries ## Clean all make artifacts
2021-04-08 10:38:16 -04:00
rm -rf \
_output \
2021-04-08 14:30:40 -04:00
$( wildcard podman-*.msi) \
2021-04-08 10:38:16 -04:00
$( wildcard podman-remote*.zip) \
2021-04-08 14:30:40 -04:00
$( wildcard podman_tmp_*) \
2021-04-08 10:38:16 -04:00
$( wildcard podman*.tar.gz) \
build \
test/checkseccomp/checkseccomp \
test/goecho/goecho \
2021-09-16 16:15:28 -04:00
test/version/version \
2021-08-09 15:04:31 -04:00
test/__init__.py \
2021-04-08 10:38:16 -04:00
test/testdata/redis-image \
libpod/container_ffjson.go \
libpod/pod_ffjson.go \
libpod/container_easyjson.go \
libpod/pod_easyjson.go \
2021-08-09 15:04:31 -04:00
docs/build \
2022-03-02 09:50:48 -07:00
.venv
2021-04-08 10:38:16 -04:00
make -C docs clean