2019-06-27 16:24:16 +02:00
export GO111MODULE = off
2019-08-30 10:32:29 +02:00
export GOPROXY = https://proxy.golang.org
2019-06-27 16:24:16 +02:00
2017-11-01 11:24:59 -04:00
GO ?= go
2019-06-07 00:46:41 -05:00
DESTDIR ?=
2020-01-06 17:18:18 -05:00
EPOCH_TEST_COMMIT ?= $( shell git merge-base HEAD $$ { DEST_BRANCH:-master} )
2017-11-03 14:37:22 -05:00
HEAD ?= HEAD
2018-03-17 15:52:54 +01:00
CHANGELOG_BASE ?= HEAD~
CHANGELOG_TARGET ?= HEAD
2018-08-16 06:41:15 -04:00
PROJECT := github.com/containers/libpod
2018-12-12 13:57:18 +01:00
GIT_BASE_BRANCH ?= origin/master
Makefile: Use ?= for shell variables (ISODATE, etc.)
Previously, Make would execute these shell commands even if we didn't
need the resulting variable. With ?='s recursive expansion [1], we
only expand the variable when it's consumed. For example, the ISODATE
variable is only needed in the recipe for the changelog target, so
most Make invocations won't need the value, and the computation is
just making whatever Make actually is doing slower.
I've shifted the GIT_COMMIT and BUILD_INFO values over to
LDFLAGS_PODMAN, because the test/*/* targets don't care about those.
I've also moved the Go-specific -ldflags from the variables into the
recipes themselves, because callers probably expect C semantics for
LDFLAGS and not Go's wrapper. That means that there's no longer a
need for the LDFLAGS/BASE_LDFLAGS separation, so I'm just using
LDFLAGS (and LDFLAGS_PODMAN) now. That reduces the declared variables
to just LDFLAGS_PODMAN, so I've shifted that declaration up to get it
closer to its GIT_COMMIT and BUILD_INFO precursors.
[1]: https://www.gnu.org/software/make/manual/html_node/Setting.html
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #777
Approved by: rhatdan
2018-05-15 16:27:07 -07:00
GIT_BRANCH ?= $( shell git rev-parse --abbrev-ref HEAD 2>/dev/null)
GIT_BRANCH_CLEAN ?= $( shell echo $( GIT_BRANCH) | sed -e "s/[^[:alnum:]]/-/g" )
LIBPOD_IMAGE ?= libpod_dev$( if $( GIT_BRANCH_CLEAN) ,:$( GIT_BRANCH_CLEAN) )
2017-11-02 15:31:21 -04:00
LIBPOD_INSTANCE := libpod_dev
2019-06-07 00:46:41 -05:00
PREFIX ?= /usr/local
2017-11-01 11:24:59 -04:00
BINDIR ?= ${ PREFIX } /bin
LIBEXECDIR ?= ${ PREFIX } /libexec
MANDIR ?= ${ PREFIX } /share/man
2018-03-01 15:33:04 -05:00
SHAREDIR_CONTAINERS ?= ${ PREFIX } /share/containers
2019-06-07 00:46:41 -05:00
ETCDIR ?= /etc
2018-05-18 16:28:51 -04:00
TMPFILESDIR ?= ${ PREFIX } /lib/tmpfiles.d
2018-03-26 09:39:14 -05:00
SYSTEMDDIR ?= ${ PREFIX } /lib/systemd/system
2019-07-25 12:39:26 +02:00
USERSYSTEMDDIR ?= ${ PREFIX } /lib/systemd/user
2019-07-01 17:29:09 +02:00
BUILDFLAGS ?=
2019-05-08 08:49:08 +02:00
BUILDTAGS ?= \
$( shell hack/apparmor_tag.sh) \
$( shell hack/btrfs_installed_tag.sh) \
$( shell hack/btrfs_tag.sh) \
$( shell hack/selinux_tag.sh) \
$( shell hack/systemd_tag.sh) \
exclude_graphdriver_devicemapper \
seccomp \
varlink
2019-11-29 10:00:13 +00:00
PYTHON ?= $( shell command -v python python3| head -n1)
PKG_MANAGER ?= $( shell command -v dnf yum| head -n1)
2019-12-29 21:04:56 +01:00
SOURCES = $( shell find . -name "*.go" )
2019-05-08 08:49:08 +02:00
2019-08-01 13:28:40 +02:00
GO_BUILD = $( GO) build
# Go module support: set `-mod=vendor` to use the vendored sources
i f e q ( $( shell go help mod >/dev /null 2>&1 && echo true ) , t r u e )
GO_BUILD = GO111MODULE = on $( GO) build -mod= vendor
e n d i f
2019-05-08 08:49:08 +02:00
i f e q ( , $( findstring systemd ,$ ( BUILDTAGS ) ) )
$( warning \
Podman is being compiled without the systemd build tag.\
2019-12-16 16:12:14 +05:30
Install libsystemd on Ubuntu or systemd-devel on rpm based distro for journald support)
2019-05-08 08:49:08 +02:00
e n d i f
2019-10-30 10:43:10 +01:00
BUILDTAGS_CROSS ?= containers_image_openpgp exclude_graphdriver_btrfs exclude_graphdriver_devicemapper exclude_graphdriver_overlay
2018-06-22 08:56:08 -05:00
i f n e q ( , $( findstring varlink ,$ ( BUILDTAGS ) ) )
2018-08-02 08:58:59 -05:00
PODMAN_VARLINK_DEPENDENCIES = cmd/podman/varlink/iopodman.go
2018-06-22 08:56:08 -05:00
e n d i f
2018-11-03 00:28:31 +01:00
CONTAINER_RUNTIME := $( shell command -v podman 2> /dev/null || echo docker)
2019-02-05 14:52:03 +01:00
OCI_RUNTIME ?= ""
2018-06-22 08:56:08 -05:00
2017-11-01 11:24:59 -04:00
BASHINSTALLDIR = ${ PREFIX } /share/bash-completion/completions
2019-03-01 15:39:51 -07:00
ZSHINSTALLDIR = ${ PREFIX } /share/zsh/site-functions
2017-11-01 11:24:59 -04:00
SELINUXOPT ?= $( shell test -x /usr/sbin/selinuxenabled && selinuxenabled && echo -Z)
Makefile: Use ?= for shell variables (ISODATE, etc.)
Previously, Make would execute these shell commands even if we didn't
need the resulting variable. With ?='s recursive expansion [1], we
only expand the variable when it's consumed. For example, the ISODATE
variable is only needed in the recipe for the changelog target, so
most Make invocations won't need the value, and the computation is
just making whatever Make actually is doing slower.
I've shifted the GIT_COMMIT and BUILD_INFO values over to
LDFLAGS_PODMAN, because the test/*/* targets don't care about those.
I've also moved the Go-specific -ldflags from the variables into the
recipes themselves, because callers probably expect C semantics for
LDFLAGS and not Go's wrapper. That means that there's no longer a
need for the LDFLAGS/BASE_LDFLAGS separation, so I'm just using
LDFLAGS (and LDFLAGS_PODMAN) now. That reduces the declared variables
to just LDFLAGS_PODMAN, so I've shifted that declaration up to get it
closer to its GIT_COMMIT and BUILD_INFO precursors.
[1]: https://www.gnu.org/software/make/manual/html_node/Setting.html
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #777
Approved by: rhatdan
2018-05-15 16:27:07 -07:00
COMMIT_NO ?= $( shell git rev-parse HEAD 2> /dev/null || true )
2019-02-04 18:37:11 +01:00
GIT_COMMIT ?= $( if $( shell git status --porcelain --untracked-files= no) ,${ COMMIT_NO } -dirty,${ COMMIT_NO } )
2019-06-20 23:14:18 +02:00
DATE_FMT = %s
i f d e f S O U R C E _ D A T E _ E P O C H
BUILD_INFO ?= $( shell date -u -d " @ $( SOURCE_DATE_EPOCH) " " + $( DATE_FMT) " 2>/dev/null || date -u -r " $( SOURCE_DATE_EPOCH) " " + $( DATE_FMT) " 2>/dev/null || date -u " + $( DATE_FMT) " )
ISODATE ?= $( shell date -d " @ $( SOURCE_DATE_EPOCH) " --iso-8601)
e l s e
BUILD_INFO ?= $( shell date " + $( DATE_FMT) " )
ISODATE ?= $( shell date --iso-8601)
e n d i f
2018-10-30 23:55:48 +01:00
LIBPOD := ${ PROJECT } /libpod
2019-06-20 23:17:53 +02:00
GCFLAGS ?= all = -trimpath= ${ PWD }
ASMFLAGS ?= all = -trimpath= ${ PWD }
2019-12-12 17:09:00 +01:00
LDFLAGS_PODMAN ?= \
2019-10-29 23:56:34 +09:00
-X $( LIBPOD) /define.gitCommit= $( GIT_COMMIT) \
-X $( LIBPOD) /define.buildInfo= $( BUILD_INFO) \
2019-10-21 19:48:23 +02:00
-X $( LIBPOD) /config._installPrefix= $( PREFIX) \
2019-12-12 17:09:00 +01:00
-X $( LIBPOD) /config._etcDir= $( ETCDIR) \
-extldflags " $( LDFLAGS) "
2019-02-01 11:26:15 +09:00
#Update to LIBSECCOMP_COMMIT should reflect in Dockerfile too.
2020-01-09 14:20:51 -05:00
LIBSECCOMP_COMMIT := v2.3.3
2019-02-05 13:22:42 -05:00
# Rarely if ever should integration tests take more than 50min,
# caller may override in special circumstances if needed.
2019-03-04 13:18:10 -05:00
GINKGOTIMEOUT ?= -timeout= 90m
2019-02-05 13:22:42 -05:00
2019-08-01 07:31:04 -04:00
RELEASE_VERSION ?= $( shell hack/get_release_info.sh VERSION)
2019-09-12 09:35:54 -07:00
RELEASE_NUMBER ?= $( shell hack/get_release_info.sh NUMBER| sed -e 's/^v\(.*\)/\1/' )
2019-08-01 07:31:04 -04:00
RELEASE_DIST ?= $( shell hack/get_release_info.sh DIST)
RELEASE_DIST_VER ?= $( shell hack/get_release_info.sh DIST_VER)
RELEASE_ARCH ?= $( shell hack/get_release_info.sh ARCH)
RELEASE_BASENAME := $( shell hack/get_release_info.sh BASENAME)
2019-07-01 14:52:55 -04:00
2019-10-08 14:20:44 -04:00
# If non-empty, logs all output from varlink during remote system testing
VARLINK_LOG ?=
2017-11-01 11:24:59 -04:00
# If GOPATH not specified, use one in the local directory
i f e q ( $( GOPATH ) , )
export GOPATH := $( CURDIR) /_output
u n export GOBIN
e n d i f
Makefile: Respect GOBIN
And use 'go env GOBIN' to detect the user's existing preference. From
[1]:
> The bin directory holds compiled commands. Each command is named
> for its source directory, but only the final element, not the entire
> path. That is, the command with source in DIR/src/foo/quux is
> installed into DIR/bin/quux, not DIR/bin/foo/quux. The "foo/"
> prefix is stripped so that you can add DIR/bin to your PATH to get
> at the installed commands. If the GOBIN environment variable is
> set, commands are installed to the directory it names instead of
> DIR/bin. GOBIN must be an absolute path.
> ...
> Go searches each directory listed in GOPATH to find source code, but
> new packages are always downloaded into the first directory in the
> list.
So if GOBIN is set, it will be non-empty, and we can use $(GOBIN)/...
If GOBIN is unset, 'go env GOBIN' will return an empty string (as it
does on Travis [2]). In that case, I'm assuming that the package in
question is in the first directory in GOPATH and using the new
FIRST_GOPATH (firstword and subst are documented in [3]). That's
probably fairly safe, since our previous GOPATH handling assumed it
only contained a single path, and nobody was complaining about that.
Using ?= allows us to skip the 'dirname' call if we end up not needing
GOPKGBASEDIR [4] (e.g. for the 'help' target). The recursive
expansion could cause an issue if the result of the shell expansions
included a '$', but those seem unlikely in GOPKGBASEDIR, GOMD2MAN, or
the manpage paths. I haven't used ?= for GOBIN, because we'll always
need the expanded value for the if check.
Using GOMD2MAN allows us to collapse old ||-based recipe into a less
confusing invocation. And using a static pattern rule [5] for
$(MANPAGES) lets us write a single rule to handle both section 1 and
section 5.
While I was updating the GOPATH handling, I moved .gopathok from the
possibly-shared $(GOPATH)/.gopathok to the
definitely-specific-to-this-project .gopathok. That may cause some
issues if you rebuild after changing your GOPATH without calling
'clean', but I don't expect folks to change their GOPATH frequently.
And the old approach would fail if different consumers were also using
the same flag path to mean something else (as CRI-O does [6]).
As part of cleaning up .gopathok, I've also collapsed clean's rm calls
into a single invocation. That will give us the same results with
less process setup/teardown penalties.
[1]: https://golang.org/cmd/go/#hdr-GOPATH_environment_variable
[2]: https://travis-ci.org/projectatomic/libpod/jobs/379345071#L459
[3]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
[4]: https://www.gnu.org/software/make/manual/html_node/Setting.html
[5]: https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
[6]: https://github.com/kubernetes-incubator/cri-o/blob/v1.10.1/Makefile#L62
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #774
Approved by: mheon
2018-05-15 10:50:56 -07:00
FIRST_GOPATH := $( firstword $( subst :, ,$( GOPATH) ) )
GOPKGDIR := $( FIRST_GOPATH) /src/$( PROJECT)
GOPKGBASEDIR ?= $( shell dirname " $( GOPKGDIR) " )
2018-05-21 15:06:28 +00:00
GOBIN := $( shell $( GO) env GOBIN)
Makefile: Respect GOBIN
And use 'go env GOBIN' to detect the user's existing preference. From
[1]:
> The bin directory holds compiled commands. Each command is named
> for its source directory, but only the final element, not the entire
> path. That is, the command with source in DIR/src/foo/quux is
> installed into DIR/bin/quux, not DIR/bin/foo/quux. The "foo/"
> prefix is stripped so that you can add DIR/bin to your PATH to get
> at the installed commands. If the GOBIN environment variable is
> set, commands are installed to the directory it names instead of
> DIR/bin. GOBIN must be an absolute path.
> ...
> Go searches each directory listed in GOPATH to find source code, but
> new packages are always downloaded into the first directory in the
> list.
So if GOBIN is set, it will be non-empty, and we can use $(GOBIN)/...
If GOBIN is unset, 'go env GOBIN' will return an empty string (as it
does on Travis [2]). In that case, I'm assuming that the package in
question is in the first directory in GOPATH and using the new
FIRST_GOPATH (firstword and subst are documented in [3]). That's
probably fairly safe, since our previous GOPATH handling assumed it
only contained a single path, and nobody was complaining about that.
Using ?= allows us to skip the 'dirname' call if we end up not needing
GOPKGBASEDIR [4] (e.g. for the 'help' target). The recursive
expansion could cause an issue if the result of the shell expansions
included a '$', but those seem unlikely in GOPKGBASEDIR, GOMD2MAN, or
the manpage paths. I haven't used ?= for GOBIN, because we'll always
need the expanded value for the if check.
Using GOMD2MAN allows us to collapse old ||-based recipe into a less
confusing invocation. And using a static pattern rule [5] for
$(MANPAGES) lets us write a single rule to handle both section 1 and
section 5.
While I was updating the GOPATH handling, I moved .gopathok from the
possibly-shared $(GOPATH)/.gopathok to the
definitely-specific-to-this-project .gopathok. That may cause some
issues if you rebuild after changing your GOPATH without calling
'clean', but I don't expect folks to change their GOPATH frequently.
And the old approach would fail if different consumers were also using
the same flag path to mean something else (as CRI-O does [6]).
As part of cleaning up .gopathok, I've also collapsed clean's rm calls
into a single invocation. That will give us the same results with
less process setup/teardown penalties.
[1]: https://golang.org/cmd/go/#hdr-GOPATH_environment_variable
[2]: https://travis-ci.org/projectatomic/libpod/jobs/379345071#L459
[3]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
[4]: https://www.gnu.org/software/make/manual/html_node/Setting.html
[5]: https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
[6]: https://github.com/kubernetes-incubator/cri-o/blob/v1.10.1/Makefile#L62
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #774
Approved by: mheon
2018-05-15 10:50:56 -07:00
i f e q ( $( GOBIN ) , )
GOBIN := $( FIRST_GOPATH) /bin
e n d i f
GOMD2MAN ?= $( shell command -v go-md2man || echo '$(GOBIN)/go-md2man' )
2017-11-01 11:24:59 -04:00
2017-11-03 14:37:22 -05:00
BOX = "fedora_atomic"
2018-06-29 14:47:53 -07:00
CROSS_BUILD_TARGETS := \
bin/podman.cross.darwin.amd64 \
bin/podman.cross.linux.amd64
2017-11-01 11:29:12 -04:00
all : binaries docs
2017-11-01 11:24:59 -04:00
default : help
2019-02-06 18:27:00 +01:00
d e f i n e P R I N T _ H E L P _ P Y S C R I P T
i m p o r t r e , s y s
print("Usage : make <target >")
cmds = { }
for line in sys.stdin :
match = re.match( r'^([a-zA-Z_-]+):.*?## (.*)$$' , line)
if match:
target, help = match.groups( )
cmds.update( { target: help} )
for cmd in sorted(cmds) :
print( " * '%s' - %s" % ( cmd, cmds[ cmd] ) )
e n d e f
export PRINT_HELP_PYSCRIPT
2017-11-01 11:24:59 -04:00
help :
2019-11-27 19:26:56 +00:00
@$( PYTHON) -c " $$ PRINT_HELP_PYSCRIPT " < $( MAKEFILE_LIST)
2017-11-01 11:24:59 -04:00
.gopathok :
i f e q ( "$(wildcard $(GOPKGDIR))" , "" )
mkdir -p " $( GOPKGBASEDIR) "
2019-09-07 13:51:22 +02:00
ln -sfn " $( CURDIR) " " $( GOPKGDIR) "
ln -sfn " $( CURDIR) /vendor/github.com/varlink " " $( FIRST_GOPATH) /src/github.com/varlink "
2017-11-01 11:24:59 -04:00
e n d i f
Makefile: Respect GOBIN
And use 'go env GOBIN' to detect the user's existing preference. From
[1]:
> The bin directory holds compiled commands. Each command is named
> for its source directory, but only the final element, not the entire
> path. That is, the command with source in DIR/src/foo/quux is
> installed into DIR/bin/quux, not DIR/bin/foo/quux. The "foo/"
> prefix is stripped so that you can add DIR/bin to your PATH to get
> at the installed commands. If the GOBIN environment variable is
> set, commands are installed to the directory it names instead of
> DIR/bin. GOBIN must be an absolute path.
> ...
> Go searches each directory listed in GOPATH to find source code, but
> new packages are always downloaded into the first directory in the
> list.
So if GOBIN is set, it will be non-empty, and we can use $(GOBIN)/...
If GOBIN is unset, 'go env GOBIN' will return an empty string (as it
does on Travis [2]). In that case, I'm assuming that the package in
question is in the first directory in GOPATH and using the new
FIRST_GOPATH (firstword and subst are documented in [3]). That's
probably fairly safe, since our previous GOPATH handling assumed it
only contained a single path, and nobody was complaining about that.
Using ?= allows us to skip the 'dirname' call if we end up not needing
GOPKGBASEDIR [4] (e.g. for the 'help' target). The recursive
expansion could cause an issue if the result of the shell expansions
included a '$', but those seem unlikely in GOPKGBASEDIR, GOMD2MAN, or
the manpage paths. I haven't used ?= for GOBIN, because we'll always
need the expanded value for the if check.
Using GOMD2MAN allows us to collapse old ||-based recipe into a less
confusing invocation. And using a static pattern rule [5] for
$(MANPAGES) lets us write a single rule to handle both section 1 and
section 5.
While I was updating the GOPATH handling, I moved .gopathok from the
possibly-shared $(GOPATH)/.gopathok to the
definitely-specific-to-this-project .gopathok. That may cause some
issues if you rebuild after changing your GOPATH without calling
'clean', but I don't expect folks to change their GOPATH frequently.
And the old approach would fail if different consumers were also using
the same flag path to mean something else (as CRI-O does [6]).
As part of cleaning up .gopathok, I've also collapsed clean's rm calls
into a single invocation. That will give us the same results with
less process setup/teardown penalties.
[1]: https://golang.org/cmd/go/#hdr-GOPATH_environment_variable
[2]: https://travis-ci.org/projectatomic/libpod/jobs/379345071#L459
[3]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
[4]: https://www.gnu.org/software/make/manual/html_node/Setting.html
[5]: https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
[6]: https://github.com/kubernetes-incubator/cri-o/blob/v1.10.1/Makefile#L62
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #774
Approved by: mheon
2018-05-15 10:50:56 -07:00
touch $@
2017-11-01 11:24:59 -04:00
2020-01-13 11:13:59 +01:00
lint : golangci -lint
2017-11-01 11:24:59 -04:00
2019-07-22 13:08:06 -05:00
golangci-lint : .gopathok varlink_generate .install .golangci -lint
2020-01-09 14:18:09 -06:00
$( GOBIN) /golangci-lint run --tests= false --skip-files swagger.go
2019-07-22 13:08:06 -05:00
2019-02-06 18:27:00 +01:00
gofmt : ## Verify the source code gofmt
2018-07-02 08:45:06 -07:00
find . -name '*.go' ! -path './vendor/*' -exec gofmt -s -w { } \+
git diff --exit-code
2017-12-12 12:40:20 -06:00
2017-11-01 11:24:59 -04:00
test/checkseccomp/checkseccomp : .gopathok $( wildcard test /checkseccomp /*.go )
2019-12-12 17:09:00 +01:00
$( GO_BUILD) -ldflags '$(LDFLAGS_PODMAN)' -tags " $( BUILDTAGS) " -o $@ $( PROJECT) /test/checkseccomp
2017-11-01 11:24:59 -04:00
2018-10-29 14:56:07 +08:00
test/goecho/goecho : .gopathok $( wildcard test /goecho /*.go )
2019-12-12 17:09:00 +01:00
$( GO_BUILD) -ldflags '$(LDFLAGS_PODMAN)' -o $@ $( PROJECT) /test/goecho
2018-10-29 14:56:07 +08:00
2019-12-29 21:04:56 +01:00
bin/podman : .gopathok $( SOURCES ) go .mod go .sum $( PODMAN_VARLINK_DEPENDENCIES ) ## Build with podman
$( GO_BUILD) $( BUILDFLAGS) -gcflags '$(GCFLAGS)' -asmflags '$(ASMFLAGS)' -ldflags '$(LDFLAGS_PODMAN)' -tags " $( BUILDTAGS) " -o $@ $( PROJECT) /cmd/podman
2017-11-01 11:24:59 -04:00
2019-12-29 21:04:56 +01:00
podman : bin /podman
bin/podman-remote : .gopathok $( SOURCES ) go .mod go .sum $( PODMAN_VARLINK_DEPENDENCIES ) ## Build with podman on remote environment
$( GO_BUILD) $( BUILDFLAGS) -gcflags '$(GCFLAGS)' -asmflags '$(ASMFLAGS)' -ldflags '$(LDFLAGS_PODMAN)' -tags " $( BUILDTAGS) remoteclient " -o $@ $( PROJECT) /cmd/podman
podman-remote : bin /podman -remote
2019-01-02 14:56:19 -06:00
2019-09-11 14:35:18 -07:00
.PHONY : podman .msi
2019-10-29 17:27:12 -07:00
podman.msi : podman -remote podman -remote -windows install -podman -remote -windows -docs ## Will always rebuild exe as there is no podman-remote-windows.exe target to verify timestamp
$( eval DOCFILE := docs/build/remote/windows)
find $( DOCFILE) -print \
| wixl-heat --var var.ManSourceDir --component-group ManFiles --directory-ref INSTALLDIR --prefix $( DOCFILE) / >$( DOCFILE) /pages.wsx
wixl -D VERSION = $( RELEASE_NUMBER) -D ManSourceDir = $( DOCFILE) -o podman-v$( RELEASE_NUMBER) .msi contrib/msi/podman.wxs $( DOCFILE) /pages.wsx
2019-09-11 14:35:18 -07:00
2019-08-01 07:31:04 -04:00
podman-remote-% : .gopathok $( PODMAN_VARLINK_DEPENDENCIES ) ## Build podman for a specific GOOS
$( eval BINSFX := $( shell test " $* " != "windows" || echo ".exe" ) )
CGO_ENABLED = 0 GOOS = $* $( GO_BUILD) -gcflags '$(GCFLAGS)' -asmflags '$(ASMFLAGS)' -ldflags '$(LDFLAGS_PODMAN)' -tags "remoteclient containers_image_openpgp exclude_graphdriver_devicemapper" -o bin/$@ $( BINSFX) $( PROJECT) /cmd/podman
2019-04-22 16:01:31 -05:00
2019-02-06 18:27:00 +01:00
local-cross : $( CROSS_BUILD_TARGETS ) ## Cross local compilation
2018-06-29 14:47:53 -07:00
bin/podman.cross.% : .gopathok
TARGET = " $* " ; \
GOOS = " $$ {TARGET%%.*} " \
GOARCH = " $$ {TARGET##*.} " \
2019-08-01 13:28:40 +02:00
$( GO_BUILD) -gcflags '$(GCFLAGS)' -asmflags '$(ASMFLAGS)' -ldflags '$(LDFLAGS_PODMAN)' -tags '$(BUILDTAGS_CROSS)' -o " $@ " $( PROJECT) /cmd/podman
2018-06-20 13:23:24 -05:00
Initial commit on compatible API
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Create service command
Use cd cmd/service && go build .
$ systemd-socket-activate -l 8081 cmd/service/service &
$ curl http://localhost:8081/v1.24/images/json
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Correct Makefile
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Two more stragglers
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Report errors back as http headers
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Split out handlers, updated output
Output aligned to docker structures
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Refactored routing, added more endpoints and types
* Encapsulated all the routing information in the handler_* files.
* Added more serviceapi/types, including podman additions. See Info
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Cleaned up code, implemented info content
* Move Content-Type check into serviceHandler
* Custom 404 handler showing the url, mostly for debugging
* Refactored images: better method names and explicit http codes
* Added content to /info
* Added podman fields to Info struct
* Added Container struct
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Add a bunch of endpoints
containers: stop, pause, unpause, wait, rm
images: tag, rmi, create (pull only)
Signed-off-by: baude <bbaude@redhat.com>
Add even more handlers
* Add serviceapi/Error() to improve error handling
* Better support for API return payloads
* Renamed unimplemented to unsupported these are generic endpoints
we don't intend to ever support. Swarm broken out since it uses
different HTTP codes to signal that the node is not in a swarm.
* Added more types
* API Version broken out so it can be validated in the future
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Refactor to introduce ServiceWriter
Signed-off-by: Jhon Honce <jhonce@redhat.com>
populate pods endpoints
/libpod/pods/..
exists, kill, pause, prune, restart, remove, start, stop, unpause
Signed-off-by: baude <bbaude@redhat.com>
Add components to Version, fix Error body
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Add images pull output, fix swarm routes
* docker-py tests/integration/api_client_test.py pass 100%
* docker-py tests/integration/api_image_test.py pass 4/16
+ Test failures include services podman does not support
Signed-off-by: Jhon Honce <jhonce@redhat.com>
pods endpoint submission 2
add create and others; only top and stats is left.
Signed-off-by: baude <bbaude@redhat.com>
Update pull image to work from empty registry
Signed-off-by: Jhon Honce <jhonce@redhat.com>
pod create and container create
first pass at pod and container create. the container create does not
quite work yet but it is very close. pod create needs a partial
rewrite. also broken off the DELETE (rm/rmi) to specific handler funcs.
Signed-off-by: baude <bbaude@redhat.com>
Add docker-py demos, GET .../containers/json
* Update serviceapi/types to reflect libpod not podman
* Refactored removeImage() to provide non-streaming return
Signed-off-by: Jhon Honce <jhonce@redhat.com>
create container part2
finished minimal config needed for create container. started demo.py
for upcoming talk
Signed-off-by: baude <bbaude@redhat.com>
Stop server after honoring request
* Remove casting for method calls
* Improve WriteResponse()
* Update Container API type to match docker API
Signed-off-by: Jhon Honce <jhonce@redhat.com>
fix namespace assumptions
cleaned up namespace issues with libpod.
Signed-off-by: baude <bbaude@redhat.com>
wip
Signed-off-by: baude <bbaude@redhat.com>
Add sliding window when shutting down server
* Added a Timeout rather than closing down service on each call
* Added gorilla/schema dependency for Decode'ing query parameters
* Improved error handling
* Container logs returned and multiplexed for stdout and stderr
* .../containers/{name}/logs?stdout=True&stderr=True
* Container stats
* .../containers/{name}/stats
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Improve error handling
* Add check for at least one std stream required for /containers/{id}/logs
* Add check for state in /containers/{id}/top
* Fill in more fields for /info
* Fixed error checking in service start code
Signed-off-by: Jhon Honce <jhonce@redhat.com>
get rest of image tests for pass
Signed-off-by: baude <bbaude@redhat.com>
linting our content
Signed-off-by: baude <bbaude@redhat.com>
more linting
Signed-off-by: baude <bbaude@redhat.com>
more linting
Signed-off-by: baude <bbaude@redhat.com>
pruning
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]apiv2 pods
migrate from using args in the url to using a json struct in body for
pod create.
Signed-off-by: baude <bbaude@redhat.com>
fix handler_images prune
prune's api changed slightly to deal with filters.
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]enabled base container create tests
enabling the base container create tests which allow us to get more into
the stop, kill, etc tests. many new tests now pass.
Signed-off-by: baude <bbaude@redhat.com>
serviceapi errors: append error message to API message
I dearly hope this is not breaking any other tests but debugging
"Internal Server Error" is not helpful to any user. In case, it
breaks tests, we can rever the commit - that's why it's a small one.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
serviceAPI: add containers/prune endpoint
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
add `service` make target
Also remove the non-functional sub-Makefile.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
add make targets for testing the service
* `sudo make run-service` for running the service.
* `DOCKERPY_TEST="tests/integration/api_container_test.py::ListContainersTest" \
make run-docker-py-tests`
for running a specific tests. Run all tests by leaving the env
variable empty.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Split handlers and server packages
The files were split to help contain bloat. The api/server package will
contain all code related to the functioning of the server while
api/handlers will have all the code related to implementing the end
points.
api/server/register_* will contain the methods for registering
endpoints. Additionally, they will have the comments for generating the
swagger spec file.
See api/handlers/version.go for a small example handler,
api/handlers/containers.go contains much more complex handlers.
Signed-off-by: Jhon Honce <jhonce@redhat.com>
[CI:DOCS]enabled more tests
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]libpod endpoints
small refactor for libpod inclusion and began adding endpoints.
Signed-off-by: baude <bbaude@redhat.com>
Implement /build and /events
* Include crypto libraries for future ssh work
Signed-off-by: Jhon Honce <jhonce@redhat.com>
[CI:DOCS]more image implementations
convert from using for to query structs among other changes including
new endpoints.
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]add bindings for golang
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]add volume endpoints for libpod
create, inspect, ls, prune, and rm
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]apiv2 healthcheck enablement
wire up container healthchecks for the api.
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]Add mount endpoints
via the api, allow ability to mount a container and list container
mounts.
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]Add search endpoint
add search endpoint with golang bindings
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]more apiv2 development
misc population of methods, etc
Signed-off-by: baude <bbaude@redhat.com>
rebase cleanup and epoch reset
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]add more network endpoints
also, add some initial error handling and convenience functions for
standard endpoints.
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]use helper funcs for bindings
use the methods developed to make writing bindings less duplicative and
easier to use.
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]add return info for prereview
begin to add return info and status codes for errors so that we can
review the apiv2
Signed-off-by: baude <bbaude@redhat.com>
[CI:DOCS]first pass at adding swagger docs for api
Signed-off-by: baude <bbaude@redhat.com>
2019-11-01 13:03:34 -07:00
.PHONY : service
service : .gopathok
$( GO_BUILD) $( BUILDFLAGS) -gcflags '$(GCFLAGS)' -asmflags '$(ASMFLAGS)' -ldflags '$(LDFLAGS_PODMAN)' -tags " $( BUILDTAGS) " -o bin/$@ $( PROJECT) /cmd/service
.PHONY :
run-service :
systemd-socket-activate -l 8080 ./bin/service
.PHONY : run -docker -py -tests
run-docker-py-tests :
$( eval testLogs = $( shell mktemp) )
./bin/podman run --rm --security-opt label = disable --privileged -v $( testLogs) :/testLogs --net= host -e DOCKER_HOST = tcp://localhost:8080 $( DOCKERPY_IMAGE) sh -c " pytest $( DOCKERPY_TEST) "
2019-02-06 18:27:00 +01:00
clean : ## Clean artifacts
Makefile: Respect GOBIN
And use 'go env GOBIN' to detect the user's existing preference. From
[1]:
> The bin directory holds compiled commands. Each command is named
> for its source directory, but only the final element, not the entire
> path. That is, the command with source in DIR/src/foo/quux is
> installed into DIR/bin/quux, not DIR/bin/foo/quux. The "foo/"
> prefix is stripped so that you can add DIR/bin to your PATH to get
> at the installed commands. If the GOBIN environment variable is
> set, commands are installed to the directory it names instead of
> DIR/bin. GOBIN must be an absolute path.
> ...
> Go searches each directory listed in GOPATH to find source code, but
> new packages are always downloaded into the first directory in the
> list.
So if GOBIN is set, it will be non-empty, and we can use $(GOBIN)/...
If GOBIN is unset, 'go env GOBIN' will return an empty string (as it
does on Travis [2]). In that case, I'm assuming that the package in
question is in the first directory in GOPATH and using the new
FIRST_GOPATH (firstword and subst are documented in [3]). That's
probably fairly safe, since our previous GOPATH handling assumed it
only contained a single path, and nobody was complaining about that.
Using ?= allows us to skip the 'dirname' call if we end up not needing
GOPKGBASEDIR [4] (e.g. for the 'help' target). The recursive
expansion could cause an issue if the result of the shell expansions
included a '$', but those seem unlikely in GOPKGBASEDIR, GOMD2MAN, or
the manpage paths. I haven't used ?= for GOBIN, because we'll always
need the expanded value for the if check.
Using GOMD2MAN allows us to collapse old ||-based recipe into a less
confusing invocation. And using a static pattern rule [5] for
$(MANPAGES) lets us write a single rule to handle both section 1 and
section 5.
While I was updating the GOPATH handling, I moved .gopathok from the
possibly-shared $(GOPATH)/.gopathok to the
definitely-specific-to-this-project .gopathok. That may cause some
issues if you rebuild after changing your GOPATH without calling
'clean', but I don't expect folks to change their GOPATH frequently.
And the old approach would fail if different consumers were also using
the same flag path to mean something else (as CRI-O does [6]).
As part of cleaning up .gopathok, I've also collapsed clean's rm calls
into a single invocation. That will give us the same results with
less process setup/teardown penalties.
[1]: https://golang.org/cmd/go/#hdr-GOPATH_environment_variable
[2]: https://travis-ci.org/projectatomic/libpod/jobs/379345071#L459
[3]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
[4]: https://www.gnu.org/software/make/manual/html_node/Setting.html
[5]: https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
[6]: https://github.com/kubernetes-incubator/cri-o/blob/v1.10.1/Makefile#L62
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #774
Approved by: mheon
2018-05-15 10:50:56 -07:00
rm -rf \
.gopathok \
_output \
2019-09-26 18:11:26 -04:00
release.txt \
2019-08-01 07:31:04 -04:00
$( wildcard podman-remote*.zip) \
$( wildcard podman*.tar.gz) \
2018-06-29 14:47:53 -07:00
bin \
Makefile: Respect GOBIN
And use 'go env GOBIN' to detect the user's existing preference. From
[1]:
> The bin directory holds compiled commands. Each command is named
> for its source directory, but only the final element, not the entire
> path. That is, the command with source in DIR/src/foo/quux is
> installed into DIR/bin/quux, not DIR/bin/foo/quux. The "foo/"
> prefix is stripped so that you can add DIR/bin to your PATH to get
> at the installed commands. If the GOBIN environment variable is
> set, commands are installed to the directory it names instead of
> DIR/bin. GOBIN must be an absolute path.
> ...
> Go searches each directory listed in GOPATH to find source code, but
> new packages are always downloaded into the first directory in the
> list.
So if GOBIN is set, it will be non-empty, and we can use $(GOBIN)/...
If GOBIN is unset, 'go env GOBIN' will return an empty string (as it
does on Travis [2]). In that case, I'm assuming that the package in
question is in the first directory in GOPATH and using the new
FIRST_GOPATH (firstword and subst are documented in [3]). That's
probably fairly safe, since our previous GOPATH handling assumed it
only contained a single path, and nobody was complaining about that.
Using ?= allows us to skip the 'dirname' call if we end up not needing
GOPKGBASEDIR [4] (e.g. for the 'help' target). The recursive
expansion could cause an issue if the result of the shell expansions
included a '$', but those seem unlikely in GOPKGBASEDIR, GOMD2MAN, or
the manpage paths. I haven't used ?= for GOBIN, because we'll always
need the expanded value for the if check.
Using GOMD2MAN allows us to collapse old ||-based recipe into a less
confusing invocation. And using a static pattern rule [5] for
$(MANPAGES) lets us write a single rule to handle both section 1 and
section 5.
While I was updating the GOPATH handling, I moved .gopathok from the
possibly-shared $(GOPATH)/.gopathok to the
definitely-specific-to-this-project .gopathok. That may cause some
issues if you rebuild after changing your GOPATH without calling
'clean', but I don't expect folks to change their GOPATH frequently.
And the old approach would fail if different consumers were also using
the same flag path to mean something else (as CRI-O does [6]).
As part of cleaning up .gopathok, I've also collapsed clean's rm calls
into a single invocation. That will give us the same results with
less process setup/teardown penalties.
[1]: https://golang.org/cmd/go/#hdr-GOPATH_environment_variable
[2]: https://travis-ci.org/projectatomic/libpod/jobs/379345071#L459
[3]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
[4]: https://www.gnu.org/software/make/manual/html_node/Setting.html
[5]: https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
[6]: https://github.com/kubernetes-incubator/cri-o/blob/v1.10.1/Makefile#L62
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #774
Approved by: mheon
2018-05-15 10:50:56 -07:00
build \
test/checkseccomp/checkseccomp \
2018-10-29 14:56:07 +08:00
test/goecho/goecho \
Makefile: Respect GOBIN
And use 'go env GOBIN' to detect the user's existing preference. From
[1]:
> The bin directory holds compiled commands. Each command is named
> for its source directory, but only the final element, not the entire
> path. That is, the command with source in DIR/src/foo/quux is
> installed into DIR/bin/quux, not DIR/bin/foo/quux. The "foo/"
> prefix is stripped so that you can add DIR/bin to your PATH to get
> at the installed commands. If the GOBIN environment variable is
> set, commands are installed to the directory it names instead of
> DIR/bin. GOBIN must be an absolute path.
> ...
> Go searches each directory listed in GOPATH to find source code, but
> new packages are always downloaded into the first directory in the
> list.
So if GOBIN is set, it will be non-empty, and we can use $(GOBIN)/...
If GOBIN is unset, 'go env GOBIN' will return an empty string (as it
does on Travis [2]). In that case, I'm assuming that the package in
question is in the first directory in GOPATH and using the new
FIRST_GOPATH (firstword and subst are documented in [3]). That's
probably fairly safe, since our previous GOPATH handling assumed it
only contained a single path, and nobody was complaining about that.
Using ?= allows us to skip the 'dirname' call if we end up not needing
GOPKGBASEDIR [4] (e.g. for the 'help' target). The recursive
expansion could cause an issue if the result of the shell expansions
included a '$', but those seem unlikely in GOPKGBASEDIR, GOMD2MAN, or
the manpage paths. I haven't used ?= for GOBIN, because we'll always
need the expanded value for the if check.
Using GOMD2MAN allows us to collapse old ||-based recipe into a less
confusing invocation. And using a static pattern rule [5] for
$(MANPAGES) lets us write a single rule to handle both section 1 and
section 5.
While I was updating the GOPATH handling, I moved .gopathok from the
possibly-shared $(GOPATH)/.gopathok to the
definitely-specific-to-this-project .gopathok. That may cause some
issues if you rebuild after changing your GOPATH without calling
'clean', but I don't expect folks to change their GOPATH frequently.
And the old approach would fail if different consumers were also using
the same flag path to mean something else (as CRI-O does [6]).
As part of cleaning up .gopathok, I've also collapsed clean's rm calls
into a single invocation. That will give us the same results with
less process setup/teardown penalties.
[1]: https://golang.org/cmd/go/#hdr-GOPATH_environment_variable
[2]: https://travis-ci.org/projectatomic/libpod/jobs/379345071#L459
[3]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
[4]: https://www.gnu.org/software/make/manual/html_node/Setting.html
[5]: https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
[6]: https://github.com/kubernetes-incubator/cri-o/blob/v1.10.1/Makefile#L62
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #774
Approved by: mheon
2018-05-15 10:50:56 -07:00
test/testdata/redis-image \
2018-08-02 08:58:59 -05:00
cmd/podman/varlink/iopodman.go \
2018-08-20 14:56:22 -04:00
libpod/container_ffjson.go \
libpod/pod_ffjson.go \
2018-08-22 09:12:40 -04:00
libpod/container_easyjson.go \
libpod/pod_easyjson.go \
2019-10-24 14:54:57 -05:00
docs/build
2017-11-01 11:24:59 -04:00
2019-02-06 18:27:00 +01:00
libpodimage : ## Build the libpod image
2018-10-23 17:36:35 -04:00
${ CONTAINER_RUNTIME } build -t ${ LIBPOD_IMAGE } .
2017-11-01 11:24:59 -04:00
2017-11-02 15:31:21 -04:00
dbuild : libpodimage
2018-10-23 17:36:35 -04:00
${ CONTAINER_RUNTIME } run --name= ${ LIBPOD_INSTANCE } --privileged -v ${ PWD } :/go/src/${ PROJECT } --rm ${ LIBPOD_IMAGE } make all
2017-11-01 11:24:59 -04:00
2019-04-19 11:41:37 +09:00
dbuild-podman-remote : libpodimage
${ CONTAINER_RUNTIME } run --name= ${ LIBPOD_INSTANCE } --privileged -v ${ PWD } :/go/src/${ PROJECT } --rm ${ LIBPOD_IMAGE } go build -ldflags '$(LDFLAGS_PODMAN)' -tags " $( BUILDTAGS) remoteclient " -o bin/podman-remote $( PROJECT) /cmd/podman
dbuild-podman-remote-darwin : libpodimage
${ CONTAINER_RUNTIME } run --name= ${ LIBPOD_INSTANCE } --privileged -v ${ PWD } :/go/src/${ PROJECT } --rm ${ LIBPOD_IMAGE } env GOOS = darwin go build -ldflags '$(LDFLAGS_PODMAN)' -tags "remoteclient containers_image_openpgp exclude_graphdriver_devicemapper" -o bin/podman-remote-darwin $( PROJECT) /cmd/podman
2019-02-06 18:27:00 +01:00
test : libpodimage ## Run tests on built image
2019-02-05 14:52:03 +01:00
${ CONTAINER_RUNTIME } run -e STORAGE_OPTIONS = "--storage-driver=vfs" -e TESTFLAGS -e OCI_RUNTIME -e CGROUP_MANAGER = cgroupfs -e TRAVIS -t --privileged --rm -v ${ CURDIR } :/go/src/${ PROJECT } ${ LIBPOD_IMAGE } make clean all localunit install.catatonit localintegration
2018-03-07 10:14:17 -05:00
2019-02-06 18:27:00 +01:00
integration : libpodimage ## Execute integration tests
2019-02-05 14:52:03 +01:00
${ CONTAINER_RUNTIME } run -e STORAGE_OPTIONS = "--storage-driver=vfs" -e TESTFLAGS -e OCI_RUNTIME -e CGROUP_MANAGER = cgroupfs -e TRAVIS -t --privileged --rm -v ${ CURDIR } :/go/src/${ PROJECT } ${ LIBPOD_IMAGE } make clean all install.catatonit localintegration
2017-11-01 11:24:59 -04:00
2018-01-24 08:45:55 -06:00
integration.fedora :
DIST = Fedora sh .papr_prepare.sh
2018-02-09 12:31:47 -06:00
integration.centos :
DIST = CentOS sh .papr_prepare.sh
2019-02-06 18:27:00 +01:00
shell : libpodimage ## Run the built image and attach a shell
2019-02-05 14:52:03 +01:00
${ CONTAINER_RUNTIME } run -e STORAGE_OPTIONS = "--storage-driver=vfs" -e CGROUP_MANAGER = cgroupfs -e TESTFLAGS -e OCI_RUNTIME -e TRAVIS -it --privileged --rm -v ${ CURDIR } :/go/src/${ PROJECT } ${ LIBPOD_IMAGE } sh
2018-03-13 16:36:40 +01:00
2019-02-06 18:27:00 +01:00
testunit : libpodimage ## Run unittest on the built image
2019-02-05 14:52:03 +01:00
${ CONTAINER_RUNTIME } run -e STORAGE_OPTIONS = "--storage-driver=vfs" -e TESTFLAGS -e CGROUP_MANAGER = cgroupfs -e OCI_RUNTIME -e TRAVIS -t --privileged --rm -v ${ CURDIR } :/go/src/${ PROJECT } ${ LIBPOD_IMAGE } make localunit
2018-03-07 10:14:17 -05:00
2018-10-29 14:56:07 +08:00
localunit : test /goecho /goecho varlink_generate
2019-04-03 12:32:49 +02:00
ginkgo \
-r \
2019-12-16 13:52:22 +01:00
$( TESTFLAGS) \
2019-08-11 11:47:15 -05:00
--skipPackage test/e2e,pkg/apparmor,test/endpoint \
2019-04-03 12:32:49 +02:00
--cover \
--covermode atomic \
--tags " $( BUILDTAGS) " \
--succinct
2017-11-01 11:24:59 -04:00
2018-01-24 08:45:55 -06:00
ginkgo :
2019-12-16 13:52:22 +01:00
ginkgo -v $( TESTFLAGS) -tags " $( BUILDTAGS) " $( GINKGOTIMEOUT) -cover -flakeAttempts 3 -progress -trace -noColor -nodes 3 -debug test/e2e/.
2018-01-24 08:45:55 -06:00
2019-01-14 13:23:13 -06:00
ginkgo-remote :
2019-12-16 13:52:22 +01:00
ginkgo -v $( TESTFLAGS) -tags " $( BUILDTAGS) remoteclient " $( GINKGOTIMEOUT) -cover -flakeAttempts 3 -progress -trace -noColor test/e2e/.
2019-01-14 13:23:13 -06:00
2019-08-11 11:47:15 -05:00
endpoint :
2019-12-16 13:52:22 +01:00
ginkgo -v $( TESTFLAGS) -tags " $( BUILDTAGS) " $( GINKGOTIMEOUT) -cover -flakeAttempts 3 -progress -trace -noColor -debug test/endpoint/.
2019-08-11 11:47:15 -05:00
2019-05-08 15:21:33 -05:00
localintegration : varlink_generate test -binaries ginkgo
remoteintegration : varlink_generate test -binaries ginkgo -remote
2018-05-14 18:01:08 -07:00
2019-04-15 12:49:53 -06:00
localsystem :
2019-07-09 12:03:35 -06:00
# Wipe existing config, database, and cache: start with clean slate.
$( RM) -rf ${ HOME } /.local/share/containers ${ HOME } /.config/containers
2019-08-07 14:24:23 -06:00
if timeout -v 1 true; then PODMAN = ./bin/podman bats test/system/; else echo " Skipping $@ : 'timeout -v' unavailable' " ; fi
2019-04-15 12:49:53 -06:00
remotesystem :
2019-08-07 14:24:23 -06:00
# Wipe existing config, database, and cache: start with clean slate.
$( RM) -rf ${ HOME } /.local/share/containers ${ HOME } /.config/containers
# Start varlink server using tmp socket; loop-wait for it;
# test podman-remote; kill server, clean up tmp socket file.
# varlink server spews copious unhelpful output; ignore it.
rc = 0; \
if timeout -v 1 true; then \
SOCK_FILE = $( shell mktemp --dry-run --tmpdir io.podman.XXXXXX) ; \
export PODMAN_VARLINK_ADDRESS = unix:$$ SOCK_FILE; \
2019-10-08 14:20:44 -04:00
./bin/podman varlink --timeout= 0 $$ PODMAN_VARLINK_ADDRESS & > $( if $( VARLINK_LOG) ,$( VARLINK_LOG) ,/dev/null) & \
2019-08-07 14:24:23 -06:00
retry = 5; \
while [ [ $$ retry -ge 0 ] ] ; do \
echo Waiting for varlink server...; \
sleep 1; \
./bin/podman-remote info & >/dev/null && break; \
retry = $$ ( expr $$ retry - 1) ; \
done ; \
env PODMAN = ./bin/podman-remote bats test/system/ ; \
rc = $$ ?; \
kill %1; \
rm -f $$ SOCK_FILE; \
else \
echo " Skipping $@ : 'timeout -v' unavailable' " ; \
fi ; \
exit $$ rc
2018-10-29 14:56:23 +08:00
2019-02-06 11:57:46 -07:00
system.test-binary : .install .ginkgo
2018-11-16 11:19:37 +08:00
$( GO) test -c ./test/system
2017-11-03 14:37:22 -05:00
vagrant-check :
BOX = $( BOX) sh ./vagrant.sh
2019-02-06 18:27:00 +01:00
binaries : varlink_generate podman podman -remote ## Build podman
2017-11-02 15:31:21 -04:00
2018-12-22 14:59:43 +01:00
install.catatonit :
./hack/install_catatonit.sh
2019-02-08 20:09:04 -06:00
test-binaries : test /checkseccomp /checkseccomp test /goecho /goecho install .catatonit
2017-11-01 11:24:59 -04:00
2019-10-29 17:27:12 -07:00
MANPAGES_MD ?= $( wildcard docs/source/markdown/*.md pkg/*/docs/*.md)
Makefile: Respect GOBIN
And use 'go env GOBIN' to detect the user's existing preference. From
[1]:
> The bin directory holds compiled commands. Each command is named
> for its source directory, but only the final element, not the entire
> path. That is, the command with source in DIR/src/foo/quux is
> installed into DIR/bin/quux, not DIR/bin/foo/quux. The "foo/"
> prefix is stripped so that you can add DIR/bin to your PATH to get
> at the installed commands. If the GOBIN environment variable is
> set, commands are installed to the directory it names instead of
> DIR/bin. GOBIN must be an absolute path.
> ...
> Go searches each directory listed in GOPATH to find source code, but
> new packages are always downloaded into the first directory in the
> list.
So if GOBIN is set, it will be non-empty, and we can use $(GOBIN)/...
If GOBIN is unset, 'go env GOBIN' will return an empty string (as it
does on Travis [2]). In that case, I'm assuming that the package in
question is in the first directory in GOPATH and using the new
FIRST_GOPATH (firstword and subst are documented in [3]). That's
probably fairly safe, since our previous GOPATH handling assumed it
only contained a single path, and nobody was complaining about that.
Using ?= allows us to skip the 'dirname' call if we end up not needing
GOPKGBASEDIR [4] (e.g. for the 'help' target). The recursive
expansion could cause an issue if the result of the shell expansions
included a '$', but those seem unlikely in GOPKGBASEDIR, GOMD2MAN, or
the manpage paths. I haven't used ?= for GOBIN, because we'll always
need the expanded value for the if check.
Using GOMD2MAN allows us to collapse old ||-based recipe into a less
confusing invocation. And using a static pattern rule [5] for
$(MANPAGES) lets us write a single rule to handle both section 1 and
section 5.
While I was updating the GOPATH handling, I moved .gopathok from the
possibly-shared $(GOPATH)/.gopathok to the
definitely-specific-to-this-project .gopathok. That may cause some
issues if you rebuild after changing your GOPATH without calling
'clean', but I don't expect folks to change their GOPATH frequently.
And the old approach would fail if different consumers were also using
the same flag path to mean something else (as CRI-O does [6]).
As part of cleaning up .gopathok, I've also collapsed clean's rm calls
into a single invocation. That will give us the same results with
less process setup/teardown penalties.
[1]: https://golang.org/cmd/go/#hdr-GOPATH_environment_variable
[2]: https://travis-ci.org/projectatomic/libpod/jobs/379345071#L459
[3]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
[4]: https://www.gnu.org/software/make/manual/html_node/Setting.html
[5]: https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
[6]: https://github.com/kubernetes-incubator/cri-o/blob/v1.10.1/Makefile#L62
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #774
Approved by: mheon
2018-05-15 10:50:56 -07:00
MANPAGES ?= $( MANPAGES_MD:%.md= %)
2019-10-29 17:27:12 -07:00
MANPAGES_DEST ?= $( subst markdown,man, $( subst source,build,$( MANPAGES) ) )
2017-11-01 11:24:59 -04:00
Makefile: Respect GOBIN
And use 'go env GOBIN' to detect the user's existing preference. From
[1]:
> The bin directory holds compiled commands. Each command is named
> for its source directory, but only the final element, not the entire
> path. That is, the command with source in DIR/src/foo/quux is
> installed into DIR/bin/quux, not DIR/bin/foo/quux. The "foo/"
> prefix is stripped so that you can add DIR/bin to your PATH to get
> at the installed commands. If the GOBIN environment variable is
> set, commands are installed to the directory it names instead of
> DIR/bin. GOBIN must be an absolute path.
> ...
> Go searches each directory listed in GOPATH to find source code, but
> new packages are always downloaded into the first directory in the
> list.
So if GOBIN is set, it will be non-empty, and we can use $(GOBIN)/...
If GOBIN is unset, 'go env GOBIN' will return an empty string (as it
does on Travis [2]). In that case, I'm assuming that the package in
question is in the first directory in GOPATH and using the new
FIRST_GOPATH (firstword and subst are documented in [3]). That's
probably fairly safe, since our previous GOPATH handling assumed it
only contained a single path, and nobody was complaining about that.
Using ?= allows us to skip the 'dirname' call if we end up not needing
GOPKGBASEDIR [4] (e.g. for the 'help' target). The recursive
expansion could cause an issue if the result of the shell expansions
included a '$', but those seem unlikely in GOPKGBASEDIR, GOMD2MAN, or
the manpage paths. I haven't used ?= for GOBIN, because we'll always
need the expanded value for the if check.
Using GOMD2MAN allows us to collapse old ||-based recipe into a less
confusing invocation. And using a static pattern rule [5] for
$(MANPAGES) lets us write a single rule to handle both section 1 and
section 5.
While I was updating the GOPATH handling, I moved .gopathok from the
possibly-shared $(GOPATH)/.gopathok to the
definitely-specific-to-this-project .gopathok. That may cause some
issues if you rebuild after changing your GOPATH without calling
'clean', but I don't expect folks to change their GOPATH frequently.
And the old approach would fail if different consumers were also using
the same flag path to mean something else (as CRI-O does [6]).
As part of cleaning up .gopathok, I've also collapsed clean's rm calls
into a single invocation. That will give us the same results with
less process setup/teardown penalties.
[1]: https://golang.org/cmd/go/#hdr-GOPATH_environment_variable
[2]: https://travis-ci.org/projectatomic/libpod/jobs/379345071#L459
[3]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
[4]: https://www.gnu.org/software/make/manual/html_node/Setting.html
[5]: https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
[6]: https://github.com/kubernetes-incubator/cri-o/blob/v1.10.1/Makefile#L62
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #774
Approved by: mheon
2018-05-15 10:50:56 -07:00
$(MANPAGES) : %: %.md .gopathok
2019-10-29 17:27:12 -07:00
@sed -e 's/\((podman.*\.md)\)//' -e 's/\[\(podman.*\)\]/\1/' $< | $( GOMD2MAN) -in /dev/stdin -out $( subst source/markdown,build/man,$@ )
2018-04-18 20:19:53 -07:00
2019-10-24 14:54:57 -05:00
docdir :
mkdir -p docs/build/man
2017-11-01 11:24:59 -04:00
2019-12-02 16:45:11 +00:00
docs : .install .md 2man docdir $( MANPAGES ) ## Generate documentation
2017-11-01 11:24:59 -04:00
2019-10-29 17:27:12 -07:00
install-podman-remote-%-docs : podman -remote docs $( MANPAGES )
rm -rf docs/build/remote
mkdir -p docs/build/remote
ln -sf $( shell pwd ) /docs/source/markdown/links docs/build/man/
docs/remote-docs.sh $* docs/build/remote/$* $( if $( findstring windows,$* ) ,docs/source/markdown,docs/build/man)
2019-07-01 14:52:55 -04:00
2019-09-09 09:41:05 -05:00
man-page-check :
2019-10-29 17:27:12 -07:00
hack/man-page-checker
2019-09-09 09:41:05 -05:00
2020-01-08 09:06:52 -05:00
codespell :
codespell -S bin,vendor,.git,go.sum,changelog.txt,seccomp.json,.cirrus.yml,"*.xz,*.gz,*.tar,*.tgz,bin2img,*ico,*.png,*.1,*.5,copyimg,*.orig,apidoc.go" -L uint,iff,od,seeked
2019-08-01 07:31:04 -04:00
# When publishing releases include critical build-time details
.PHONY : release .txt
release.txt :
# X-RELEASE-INFO format depended upon by automated tooling
echo -n "X-RELEASE-INFO:" > " $@ "
for field in " $( RELEASE_BASENAME) " " $( RELEASE_VERSION) " \
" $( RELEASE_DIST) " " $( RELEASE_DIST_VER) " " $( RELEASE_ARCH) " ; do \
echo -n " $$ field " ; done >> " $@ "
echo "" >> " $@ "
2019-09-12 09:35:54 -07:00
podman-v$(RELEASE_NUMBER).tar.gz : binaries docs release .txt
2019-08-01 07:31:04 -04:00
$( eval TMPDIR := $( shell mktemp -d -p '' podman_XXXX) )
2019-09-12 09:35:54 -07:00
$( eval SUBDIR := podman-v$( RELEASE_NUMBER) )
2019-08-01 07:31:04 -04:00
mkdir -p " $( TMPDIR) / $( SUBDIR) "
$( MAKE) install.bin install.man install.cni install.systemd " DESTDIR= $( TMPDIR) / $( SUBDIR) " "PREFIX=/usr"
# release.txt location and content depended upon by automated tooling
cp release.txt " $( TMPDIR) / "
tar -czvf $@ --xattrs -C " $( TMPDIR) " "./release.txt" " ./ $( SUBDIR) "
-rm -rf " $( TMPDIR) "
# Must call make in-line: Dependency-spec. w/ wild-card also consumes variable value.
2019-09-12 09:35:54 -07:00
podman-remote-v$(RELEASE_NUMBER)-%.zip :
2019-10-29 17:27:12 -07:00
$( MAKE) podman-remote-$* install-podman-remote-$* -docs release.txt \
2019-08-01 07:31:04 -04:00
RELEASE_BASENAME = $( shell hack/get_release_info.sh REMOTENAME) \
RELEASE_DIST = $* RELEASE_DIST_VER = "-"
$( eval TMPDIR := $( shell mktemp -d -p '' $podman_remote_XXXX ) )
$( eval SUBDIR := podman-$( RELEASE_VERSION) )
$( eval BINSFX := $( shell test " $* " != "windows" || echo ".exe" ) )
mkdir -p " $( TMPDIR) / $( SUBDIR) "
# release.txt location and content depended upon by automated tooling
cp release.txt " $( TMPDIR) / "
cp ./bin/podman-remote-$* $( BINSFX) " $( TMPDIR) / $( SUBDIR) /podman $( BINSFX) "
2019-10-29 17:27:12 -07:00
cp -r ./docs/build/remote/$* " $( TMPDIR) / $( SUBDIR) /docs/ "
2019-08-01 07:31:04 -04:00
cd " $( TMPDIR) " && \
zip --recurse-paths " $( CURDIR) / $@ " "./release.txt" "./"
-rm -rf " $( TMPDIR) "
.PHONY : podman -release
podman-release :
rm -f release.txt
2019-09-12 09:35:54 -07:00
$( MAKE) podman-v$( RELEASE_NUMBER) .tar.gz
2019-07-01 14:52:55 -04:00
2019-08-01 07:31:04 -04:00
.PHONY : podman -remote -%-release
podman-remote-%-release :
rm -f release.txt
2019-09-12 09:35:54 -07:00
$( MAKE) podman-remote-v$( RELEASE_NUMBER) -$* .zip
2019-07-01 14:52:55 -04:00
2018-01-11 10:54:39 -05:00
docker-docs : docs
2019-11-02 12:58:38 +01:00
( cd docs; ./dckrman.sh ./build/man/*.1)
2018-01-11 10:54:39 -05:00
2019-02-06 18:27:00 +01:00
changelog : ## Generate changelog
2018-03-17 15:52:54 +01:00
@echo " Creating changelog from $( CHANGELOG_BASE) to $( CHANGELOG_TARGET) "
$( eval TMPFILE := $( shell mktemp) )
$( shell cat changelog.txt > $( TMPFILE) )
$( shell echo " - Changelog for $( CHANGELOG_TARGET) ( $( ISODATE) ): " > changelog.txt)
$( shell git log --no-merges --format= " * %s" $( CHANGELOG_BASE) ..$( CHANGELOG_TARGET) >> changelog.txt)
$( shell echo "" >> changelog.txt)
$( shell cat $( TMPFILE) >> changelog.txt)
$( shell rm $( TMPFILE) )
2019-05-17 11:40:45 -04:00
install : .gopathok install .bin install .remote install .man install .cni install .systemd ## Install binaries to system locations
2019-08-07 14:27:49 -04:00
install.remote : podman -remote
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( BINDIR)
install ${ SELINUXOPT } -m 755 bin/podman-remote $( DESTDIR) $( BINDIR) /podman-remote
test -z " ${ SELINUXOPT } " || chcon --verbose --reference= $( DESTDIR) $( BINDIR) /podman bin/podman-remote
2017-11-01 11:24:59 -04:00
2019-08-07 14:27:49 -04:00
install.bin : podman
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( BINDIR)
install ${ SELINUXOPT } -m 755 bin/podman $( DESTDIR) $( BINDIR) /podman
test -z " ${ SELINUXOPT } " || chcon --verbose --reference= $( DESTDIR) $( BINDIR) /podman bin/podman
2017-11-01 11:24:59 -04:00
2018-01-11 10:54:39 -05:00
install.man : docs
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( MANDIR) /man1
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( MANDIR) /man5
2019-10-24 14:54:57 -05:00
install ${ SELINUXOPT } -m 644 $( filter %.1,$( MANPAGES_DEST) ) -t $( DESTDIR) $( MANDIR) /man1
install ${ SELINUXOPT } -m 644 $( filter %.5,$( MANPAGES_DEST) ) -t $( DESTDIR) $( MANDIR) /man5
2019-10-29 17:27:12 -07:00
install ${ SELINUXOPT } -m 644 docs/source/markdown/links/*1 -t $( DESTDIR) $( MANDIR) /man1
2017-11-01 11:24:59 -04:00
install.config :
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( SHAREDIR_CONTAINERS)
install ${ SELINUXOPT } -m 644 libpod.conf $( DESTDIR) $( SHAREDIR_CONTAINERS) /libpod.conf
2019-11-10 13:42:29 -05:00
install.seccomp :
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( SHAREDIR_CONTAINERS)
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -m 644 seccomp.json $( DESTDIR) $( SHAREDIR_CONTAINERS) /seccomp.json
2017-11-01 11:24:59 -04:00
install.completions :
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -d -m 755 ${ DESTDIR } ${ BASHINSTALLDIR }
install ${ SELINUXOPT } -m 644 completions/bash/podman ${ DESTDIR } ${ BASHINSTALLDIR }
install ${ SELINUXOPT } -d -m 755 ${ DESTDIR } ${ ZSHINSTALLDIR }
install ${ SELINUXOPT } -m 644 completions/zsh/_podman ${ DESTDIR } ${ ZSHINSTALLDIR }
2017-11-01 11:24:59 -04:00
2017-12-20 15:13:52 -06:00
install.cni :
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -d -m 755 ${ DESTDIR } ${ ETCDIR } /cni/net.d/
install ${ SELINUXOPT } -m 644 cni/87-podman-bridge.conflist ${ DESTDIR } ${ ETCDIR } /cni/net.d/87-podman-bridge.conflist
2017-12-20 15:13:52 -06:00
2018-01-11 10:54:39 -05:00
install.docker : docker -docs
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -d -m 755 $( DESTDIR) $( BINDIR) $( DESTDIR) $( MANDIR) /man1
install ${ SELINUXOPT } -m 755 docker $( DESTDIR) $( BINDIR) /docker
2019-11-02 12:58:38 +01:00
install ${ SELINUXOPT } -m 644 docs/build/man/docker*.1 -t $( DESTDIR) $( MANDIR) /man1
2018-01-11 10:54:39 -05:00
2018-03-26 09:39:14 -05:00
install.systemd :
2019-07-25 12:39:26 +02:00
install ${ SELINUXOPT } -m 755 -d ${ DESTDIR } ${ SYSTEMDDIR } ${ DESTDIR } ${ USERSYSTEMDDIR } ${ DESTDIR } ${ TMPFILESDIR }
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -m 644 contrib/varlink/io.podman.socket ${ DESTDIR } ${ SYSTEMDDIR } /io.podman.socket
2019-07-25 12:39:26 +02:00
install ${ SELINUXOPT } -m 644 contrib/varlink/io.podman.socket ${ DESTDIR } ${ USERSYSTEMDDIR } /io.podman.socket
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -m 644 contrib/varlink/io.podman.service ${ DESTDIR } ${ SYSTEMDDIR } /io.podman.service
2019-10-10 19:24:28 +00:00
install ${ SELINUXOPT } -d ${ DESTDIR } ${ USERSYSTEMDDIR }
# User units are ordered differently, we can't make the *system* multi-user.target depend on a user unit.
# For user units the default.target that's the default is fine.
sed -e 's,^WantedBy=.*,WantedBy=default.target,' < contrib/varlink/io.podman.service > ${ DESTDIR } ${ USERSYSTEMDDIR } /io.podman.service
2019-06-07 00:46:41 -05:00
install ${ SELINUXOPT } -m 644 contrib/varlink/podman.conf ${ DESTDIR } ${ TMPFILESDIR } /podman.conf
2018-03-26 09:39:14 -05:00
2017-11-01 11:24:59 -04:00
uninstall :
2019-10-24 14:54:57 -05:00
for i in $( filter %.1,$( MANPAGES_DEST) ) ; do \
2019-06-07 00:46:41 -05:00
rm -f $( DESTDIR) $( MANDIR) /man1/$$ ( basename $$ { i} ) ; \
2018-04-18 20:19:53 -07:00
done ; \
2019-10-24 14:54:57 -05:00
for i in $( filter %.5,$( MANPAGES_DEST) ) ; do \
2019-06-07 00:46:41 -05:00
rm -f $( DESTDIR) $( MANDIR) /man5/$$ ( basename $$ { i} ) ; \
2017-11-01 11:24:59 -04:00
done
2019-12-28 02:26:38 +01:00
# Remove podman and remote bin
rm -f $( DESTDIR) $( BINDIR) /podman
rm -f $( DESTDIR) $( BINDIR) /podman-remote
# Remove related config files
rm -f ${ DESTDIR } ${ ETCDIR } /cni/net.d/87-podman-bridge.conflist
rm -f ${ DESTDIR } ${ TMPFILESDIR } /podman.conf
rm -f ${ DESTDIR } ${ SYSTEMDDIR } /io.podman.socket
rm -f ${ DESTDIR } ${ USERSYSTEMDDIR } /io.podman.socket
rm -f ${ DESTDIR } ${ SYSTEMDDIR } /io.podman.service
2017-11-01 11:24:59 -04:00
.PHONY : .gitvalidation
.gitvalidation : .gopathok
2020-01-06 17:18:18 -05:00
GIT_CHECK_EXCLUDE = "./vendor:docs/make.bat" $( GOBIN) /git-validation -run DCO,short-subject,dangling-whitespace -range $( EPOCH_TEST_COMMIT) ..$( HEAD)
2017-11-01 11:24:59 -04:00
.PHONY : install .tools
2019-07-22 13:08:06 -05:00
install.tools : .install .gitvalidation .install .gometalinter .install .md 2man .install .ginkgo .install .golangci -lint ## Install needed tools
2018-09-13 14:12:04 -05:00
2019-06-24 11:15:31 +02:00
d e f i n e g o - g e t
env GO111MODULE = off \
$( GO) get -u ${ 1 }
e n d e f
2018-09-13 14:12:04 -05:00
.install.ginkgo : .gopathok
if [ ! -x " $( GOBIN) /ginkgo " ] ; then \
2019-08-01 13:28:40 +02:00
$( GO_BUILD) -o ${ GOPATH } /bin/ginkgo ./vendor/github.com/onsi/ginkgo/ginkgo ; \
2018-09-13 14:12:04 -05:00
fi
2017-11-01 11:24:59 -04:00
.install.gitvalidation : .gopathok
Makefile: Respect GOBIN
And use 'go env GOBIN' to detect the user's existing preference. From
[1]:
> The bin directory holds compiled commands. Each command is named
> for its source directory, but only the final element, not the entire
> path. That is, the command with source in DIR/src/foo/quux is
> installed into DIR/bin/quux, not DIR/bin/foo/quux. The "foo/"
> prefix is stripped so that you can add DIR/bin to your PATH to get
> at the installed commands. If the GOBIN environment variable is
> set, commands are installed to the directory it names instead of
> DIR/bin. GOBIN must be an absolute path.
> ...
> Go searches each directory listed in GOPATH to find source code, but
> new packages are always downloaded into the first directory in the
> list.
So if GOBIN is set, it will be non-empty, and we can use $(GOBIN)/...
If GOBIN is unset, 'go env GOBIN' will return an empty string (as it
does on Travis [2]). In that case, I'm assuming that the package in
question is in the first directory in GOPATH and using the new
FIRST_GOPATH (firstword and subst are documented in [3]). That's
probably fairly safe, since our previous GOPATH handling assumed it
only contained a single path, and nobody was complaining about that.
Using ?= allows us to skip the 'dirname' call if we end up not needing
GOPKGBASEDIR [4] (e.g. for the 'help' target). The recursive
expansion could cause an issue if the result of the shell expansions
included a '$', but those seem unlikely in GOPKGBASEDIR, GOMD2MAN, or
the manpage paths. I haven't used ?= for GOBIN, because we'll always
need the expanded value for the if check.
Using GOMD2MAN allows us to collapse old ||-based recipe into a less
confusing invocation. And using a static pattern rule [5] for
$(MANPAGES) lets us write a single rule to handle both section 1 and
section 5.
While I was updating the GOPATH handling, I moved .gopathok from the
possibly-shared $(GOPATH)/.gopathok to the
definitely-specific-to-this-project .gopathok. That may cause some
issues if you rebuild after changing your GOPATH without calling
'clean', but I don't expect folks to change their GOPATH frequently.
And the old approach would fail if different consumers were also using
the same flag path to mean something else (as CRI-O does [6]).
As part of cleaning up .gopathok, I've also collapsed clean's rm calls
into a single invocation. That will give us the same results with
less process setup/teardown penalties.
[1]: https://golang.org/cmd/go/#hdr-GOPATH_environment_variable
[2]: https://travis-ci.org/projectatomic/libpod/jobs/379345071#L459
[3]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
[4]: https://www.gnu.org/software/make/manual/html_node/Setting.html
[5]: https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
[6]: https://github.com/kubernetes-incubator/cri-o/blob/v1.10.1/Makefile#L62
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #774
Approved by: mheon
2018-05-15 10:50:56 -07:00
if [ ! -x " $( GOBIN) /git-validation " ] ; then \
2019-06-24 11:15:31 +02:00
$( call go-get,github.com/vbatts/git-validation) ; \
2017-11-01 11:24:59 -04:00
fi
.install.gometalinter : .gopathok
Makefile: Respect GOBIN
And use 'go env GOBIN' to detect the user's existing preference. From
[1]:
> The bin directory holds compiled commands. Each command is named
> for its source directory, but only the final element, not the entire
> path. That is, the command with source in DIR/src/foo/quux is
> installed into DIR/bin/quux, not DIR/bin/foo/quux. The "foo/"
> prefix is stripped so that you can add DIR/bin to your PATH to get
> at the installed commands. If the GOBIN environment variable is
> set, commands are installed to the directory it names instead of
> DIR/bin. GOBIN must be an absolute path.
> ...
> Go searches each directory listed in GOPATH to find source code, but
> new packages are always downloaded into the first directory in the
> list.
So if GOBIN is set, it will be non-empty, and we can use $(GOBIN)/...
If GOBIN is unset, 'go env GOBIN' will return an empty string (as it
does on Travis [2]). In that case, I'm assuming that the package in
question is in the first directory in GOPATH and using the new
FIRST_GOPATH (firstword and subst are documented in [3]). That's
probably fairly safe, since our previous GOPATH handling assumed it
only contained a single path, and nobody was complaining about that.
Using ?= allows us to skip the 'dirname' call if we end up not needing
GOPKGBASEDIR [4] (e.g. for the 'help' target). The recursive
expansion could cause an issue if the result of the shell expansions
included a '$', but those seem unlikely in GOPKGBASEDIR, GOMD2MAN, or
the manpage paths. I haven't used ?= for GOBIN, because we'll always
need the expanded value for the if check.
Using GOMD2MAN allows us to collapse old ||-based recipe into a less
confusing invocation. And using a static pattern rule [5] for
$(MANPAGES) lets us write a single rule to handle both section 1 and
section 5.
While I was updating the GOPATH handling, I moved .gopathok from the
possibly-shared $(GOPATH)/.gopathok to the
definitely-specific-to-this-project .gopathok. That may cause some
issues if you rebuild after changing your GOPATH without calling
'clean', but I don't expect folks to change their GOPATH frequently.
And the old approach would fail if different consumers were also using
the same flag path to mean something else (as CRI-O does [6]).
As part of cleaning up .gopathok, I've also collapsed clean's rm calls
into a single invocation. That will give us the same results with
less process setup/teardown penalties.
[1]: https://golang.org/cmd/go/#hdr-GOPATH_environment_variable
[2]: https://travis-ci.org/projectatomic/libpod/jobs/379345071#L459
[3]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
[4]: https://www.gnu.org/software/make/manual/html_node/Setting.html
[5]: https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
[6]: https://github.com/kubernetes-incubator/cri-o/blob/v1.10.1/Makefile#L62
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #774
Approved by: mheon
2018-05-15 10:50:56 -07:00
if [ ! -x " $( GOBIN) /gometalinter " ] ; then \
2019-06-24 11:15:31 +02:00
$( call go-get,github.com/alecthomas/gometalinter) ; \
Makefile: Respect GOBIN
And use 'go env GOBIN' to detect the user's existing preference. From
[1]:
> The bin directory holds compiled commands. Each command is named
> for its source directory, but only the final element, not the entire
> path. That is, the command with source in DIR/src/foo/quux is
> installed into DIR/bin/quux, not DIR/bin/foo/quux. The "foo/"
> prefix is stripped so that you can add DIR/bin to your PATH to get
> at the installed commands. If the GOBIN environment variable is
> set, commands are installed to the directory it names instead of
> DIR/bin. GOBIN must be an absolute path.
> ...
> Go searches each directory listed in GOPATH to find source code, but
> new packages are always downloaded into the first directory in the
> list.
So if GOBIN is set, it will be non-empty, and we can use $(GOBIN)/...
If GOBIN is unset, 'go env GOBIN' will return an empty string (as it
does on Travis [2]). In that case, I'm assuming that the package in
question is in the first directory in GOPATH and using the new
FIRST_GOPATH (firstword and subst are documented in [3]). That's
probably fairly safe, since our previous GOPATH handling assumed it
only contained a single path, and nobody was complaining about that.
Using ?= allows us to skip the 'dirname' call if we end up not needing
GOPKGBASEDIR [4] (e.g. for the 'help' target). The recursive
expansion could cause an issue if the result of the shell expansions
included a '$', but those seem unlikely in GOPKGBASEDIR, GOMD2MAN, or
the manpage paths. I haven't used ?= for GOBIN, because we'll always
need the expanded value for the if check.
Using GOMD2MAN allows us to collapse old ||-based recipe into a less
confusing invocation. And using a static pattern rule [5] for
$(MANPAGES) lets us write a single rule to handle both section 1 and
section 5.
While I was updating the GOPATH handling, I moved .gopathok from the
possibly-shared $(GOPATH)/.gopathok to the
definitely-specific-to-this-project .gopathok. That may cause some
issues if you rebuild after changing your GOPATH without calling
'clean', but I don't expect folks to change their GOPATH frequently.
And the old approach would fail if different consumers were also using
the same flag path to mean something else (as CRI-O does [6]).
As part of cleaning up .gopathok, I've also collapsed clean's rm calls
into a single invocation. That will give us the same results with
less process setup/teardown penalties.
[1]: https://golang.org/cmd/go/#hdr-GOPATH_environment_variable
[2]: https://travis-ci.org/projectatomic/libpod/jobs/379345071#L459
[3]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
[4]: https://www.gnu.org/software/make/manual/html_node/Setting.html
[5]: https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
[6]: https://github.com/kubernetes-incubator/cri-o/blob/v1.10.1/Makefile#L62
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #774
Approved by: mheon
2018-05-15 10:50:56 -07:00
cd $( FIRST_GOPATH) /src/github.com/alecthomas/gometalinter; \
2019-12-04 10:11:31 +00:00
git checkout --detach e8d801238da6f0dfd14078d68f9b53fa50a7eeb5; \
2018-05-21 15:06:28 +00:00
$( GO) install github.com/alecthomas/gometalinter; \
Makefile: Respect GOBIN
And use 'go env GOBIN' to detect the user's existing preference. From
[1]:
> The bin directory holds compiled commands. Each command is named
> for its source directory, but only the final element, not the entire
> path. That is, the command with source in DIR/src/foo/quux is
> installed into DIR/bin/quux, not DIR/bin/foo/quux. The "foo/"
> prefix is stripped so that you can add DIR/bin to your PATH to get
> at the installed commands. If the GOBIN environment variable is
> set, commands are installed to the directory it names instead of
> DIR/bin. GOBIN must be an absolute path.
> ...
> Go searches each directory listed in GOPATH to find source code, but
> new packages are always downloaded into the first directory in the
> list.
So if GOBIN is set, it will be non-empty, and we can use $(GOBIN)/...
If GOBIN is unset, 'go env GOBIN' will return an empty string (as it
does on Travis [2]). In that case, I'm assuming that the package in
question is in the first directory in GOPATH and using the new
FIRST_GOPATH (firstword and subst are documented in [3]). That's
probably fairly safe, since our previous GOPATH handling assumed it
only contained a single path, and nobody was complaining about that.
Using ?= allows us to skip the 'dirname' call if we end up not needing
GOPKGBASEDIR [4] (e.g. for the 'help' target). The recursive
expansion could cause an issue if the result of the shell expansions
included a '$', but those seem unlikely in GOPKGBASEDIR, GOMD2MAN, or
the manpage paths. I haven't used ?= for GOBIN, because we'll always
need the expanded value for the if check.
Using GOMD2MAN allows us to collapse old ||-based recipe into a less
confusing invocation. And using a static pattern rule [5] for
$(MANPAGES) lets us write a single rule to handle both section 1 and
section 5.
While I was updating the GOPATH handling, I moved .gopathok from the
possibly-shared $(GOPATH)/.gopathok to the
definitely-specific-to-this-project .gopathok. That may cause some
issues if you rebuild after changing your GOPATH without calling
'clean', but I don't expect folks to change their GOPATH frequently.
And the old approach would fail if different consumers were also using
the same flag path to mean something else (as CRI-O does [6]).
As part of cleaning up .gopathok, I've also collapsed clean's rm calls
into a single invocation. That will give us the same results with
less process setup/teardown penalties.
[1]: https://golang.org/cmd/go/#hdr-GOPATH_environment_variable
[2]: https://travis-ci.org/projectatomic/libpod/jobs/379345071#L459
[3]: https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
[4]: https://www.gnu.org/software/make/manual/html_node/Setting.html
[5]: https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
[6]: https://github.com/kubernetes-incubator/cri-o/blob/v1.10.1/Makefile#L62
Signed-off-by: W. Trevor King <wking@tremily.us>
Closes: #774
Approved by: mheon
2018-05-15 10:50:56 -07:00
$( GOBIN) /gometalinter --install; \
2017-11-01 11:24:59 -04:00
fi
2019-07-22 13:08:06 -05:00
.install.golangci-lint : .gopathok
if [ ! -x " $( GOBIN) /golangci-lint " ] ; then \
2020-01-13 12:00:08 +01:00
curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $( GOBIN) / v1.18.0; \
2019-07-22 13:08:06 -05:00
fi
2017-11-01 11:24:59 -04:00
.install.md2man : .gopathok
2019-12-03 19:47:33 +00:00
if [ ! -x " $( GOMD2MAN) " ] ; then \
$( call go-get,github.com/cpuguy83/go-md2man) ; \
2017-11-01 11:24:59 -04:00
fi
2019-02-07 09:32:51 +01:00
varlink_generate : .gopathok cmd /podman /varlink /iopodman .go ## Generate varlink
2018-05-07 17:09:11 -05:00
varlink_api_generate : .gopathok API .md
2018-03-26 09:39:14 -05:00
2018-04-28 11:45:51 -05:00
.PHONY : install .libseccomp .sudo
install.libseccomp.sudo :
2018-04-25 13:26:52 -05:00
rm -rf ../../seccomp/libseccomp
git clone https://github.com/seccomp/libseccomp ../../seccomp/libseccomp
2019-12-04 10:11:31 +00:00
cd ../../seccomp/libseccomp && git checkout --detach $( LIBSECCOMP_COMMIT) && ./autogen.sh && ./configure --prefix= /usr && make all && make install
2018-04-25 13:26:52 -05:00
2020-01-11 13:50:45 +01:00
cmd/podman/varlink/iopodman.go : .gopathok cmd /podman /varlink /io .podman .varlink
2019-07-03 15:37:17 -05:00
GO111MODULE = off $( GO) generate ./cmd/podman/varlink/...
2018-03-26 09:39:14 -05:00
2018-08-02 08:58:59 -05:00
API.md : cmd /podman /varlink /io .podman .varlink
2018-05-07 17:09:11 -05:00
$( GO) generate ./docs/...
2019-01-07 09:56:00 -05:00
validate.completions : completions /bash /podman
. completions/bash/podman
2019-03-01 15:39:51 -07:00
if [ -x /bin/zsh ] ; then /bin/zsh completions/zsh/_podman; fi
2019-01-07 09:56:00 -05:00
2019-09-09 09:41:05 -05:00
validate : gofmt .gitvalidation validate .completions golangci -lint man -page -check
2018-04-03 12:06:12 -05:00
2018-12-12 13:57:18 +01:00
build-all-new-commits :
# Validate that all the commits build on top of $(GIT_BASE_BRANCH)
git rebase $( GIT_BASE_BRANCH) -x make
2019-06-29 22:30:57 +02:00
build-no-cgo :
2019-10-30 10:43:10 +01:00
env BUILDTAGS = "containers_image_openpgp exclude_graphdriver_btrfs exclude_graphdriver_devicemapper exclude_disk_quota" CGO_ENABLED = 0 $( MAKE)
2019-06-29 22:30:57 +02:00
2019-06-24 11:29:13 +02:00
vendor :
export GO111MODULE = on \
$( GO) mod tidy && \
$( GO) mod vendor && \
$( GO) mod verify
2019-01-08 18:00:18 +01:00
2019-11-05 17:40:33 +01:00
vendor-in-container :
2019-11-07 14:57:23 -05:00
podman run --privileged --rm --env HOME = /root -v ` pwd ` :/src -w /src docker.io/library/golang:1.13 make vendor
2019-11-05 17:40:33 +01:00
2017-11-01 11:24:59 -04:00
.PHONY : \
binaries \
2019-12-02 16:45:11 +00:00
changelog \
2017-11-01 11:24:59 -04:00
clean \
default \
docs \
gofmt \
2019-12-02 16:45:11 +00:00
golangci-lint \
2017-11-01 11:24:59 -04:00
help \
install \
2019-12-02 16:45:11 +00:00
install.libseccomp.sudo \
2017-11-01 11:24:59 -04:00
lint \
pause \
2019-11-29 10:00:13 +00:00
package \
package-install \
2018-03-17 15:52:54 +01:00
shell \
2019-12-02 16:45:11 +00:00
uninstall \
2018-04-25 13:26:52 -05:00
validate \
2019-12-02 16:45:11 +00:00
validate.completions \
2019-01-08 18:00:18 +01:00
vendor
2019-12-02 16:45:11 +00:00
2019-11-29 10:00:13 +00:00
package : ## Build rpm packages
## TODO(ssbarnea): make version number predictable, it should not change
## on each execution, producing duplicates.
2020-01-06 10:57:49 +00:00
rm -rf build/* *.src.rpm ~/rpmbuild/RPMS/*
2019-12-02 16:45:11 +00:00
./contrib/build_rpm.sh
2019-11-29 10:00:13 +00:00
2020-01-06 10:57:49 +00:00
# Remember that rpms install exec to /usr/bin/podman while a `make install`
# installs them to /usr/local/bin/podman which is likely before. Always use
# a full path to test installed podman or you risk to call another executable.
2019-11-29 10:00:13 +00:00
package-install : package ## Install rpm packages
2019-12-29 21:04:56 +01:00
sudo ${ PKG_MANAGER } -y install ${ HOME } /rpmbuild/RPMS/*/*.rpm
2020-01-06 10:57:49 +00:00
/usr/bin/podman version
/usr/bin/podman info # will catch a broken conmon
