For quite some time (Go 1.16? To be honest, I don't remember) placing
sources in a specific directory under $GOPATH is no longer required.
[NO NEW TESTS NEEDED]
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
It looks like those were added to aim in CI, and is no longer required.
As it is quite unexpected to have make targets operate on directories such
as ../../, let's remove those.
Fix Ubuntu build instructions accordingly (runc binary package is
available in those distros).
[NO NEW TESTS NEEDED]
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Images built in https://github.com/containers/automation_images/pull/393
Very minor and safe. Purpose is to stabilize those VM images,
which were needed for podman. They include a 6.11.6 kernel
which fixes one bug, and newer pasta in f39 which fixes
another bug.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Bump c/common to v0.61.0, c/image to v5.33.0, and c/storage to v1.56.0
in preparation for Buildah v1.38.0 and Podman v5.3.0
[NO NEW TESTS NEEDED]
Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
They compare buildah-bud against podman-run, which breaks if
/usr/bin/podman changes its ulimits, as happened recently
in podman PR 24335.
Signed-off-by: Ed Santiago <santiago@redhat.com>
As I used this locally and the binaires already existed make did not
rebuild. While we could list all go files here nobody should be
modifying files under vendor/ directly so just checking go.mod/sum seems
easiest.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
When the target location of a RUN --mount is specified as a relative
path, we normally try to convert it to an absolute path by combining it
with the currently-configured working directory. If there is no such
value, though, the result is still not an absolute path. Work around
this by using "/" when the configured working directory is "".
Set this field in the `runMountInfo` struct on FreeBSD, as we already
did on Linux.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
- all images pushed to a local registry must have a unique name.
Bring in safename() helper from podman tests.
- all cache tests must use a private TMPDIR
- in force-compression test, use a custom-crafted image with
no possibility of sharing layers with any other image that
any other test might push to the registry.
- use a private crun tmpdir in seccomp test, because crun
does some unexpected caching.
And, forgive me, a little refactoring of unpleasant duplication
Signed-off-by: Ed Santiago <santiago@redhat.com>
Prep work for parallelizing bats tests: when pushing images to
local registry, use a pseudorandom unique name to avoid
possibility of collisions/conflicts with other tests. This
is good practice regardless of whether we run serial or parallel.
Also slight refactor of some duplicate code.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Write output files only to $TEST_SCRATCH_DIR, never to cwd
Reformat overly-long lines for readability (whitespace only changes)
And, in the last test, the output files are plaintext, not json.
Fix filenames accordingly.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Bugs found during testing of parallel bats tests:
- write randomfiles in $TEST_SCRATCH_DIR, not cwd!
- remove unused & confusing & broken expectedEnv code
And, I couldn't help myself, improve & refactor one test
Signed-off-by: Ed Santiago <santiago@redhat.com>
runc/libcontainer/userns package moved to a new home; the old package
will be made obsoleted. Switch to the new package.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This wrapper doesn't need to load anything from helpers.bash, because
the various .bats files already do so on their own.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Use a listener helper to bind to an available-according-to-the-kernel
listening port and run a command with its stdio more or less tied to the
connection instead of trying to launch a git daemon directly using a
port number that we can only guess is available.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
