One of the auth tests is failing on RHEL8.4:
# buildah push --tls-verify=true ...
Get "https://localhost:5000/v2/": x509: certificate relies on legacy Common Name field, use SANs or temporarily enable Common Name matching with GODEBUG=x509ignoreCN=0
(Expected output: ' x509: certificate signed by unknown authority')
Cause: who knows? Some internal Go change.
Solution: set magic GODEBUG envariable in the buildah invocation.
This makes that message go away, and gives us the expected one.
Indicate that this may be a temporary workaround. I vaguely
recall reading that a future version of Go would remove it.
We'll deal with that then.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Reset back to v1.20.0-dev for the upstream branch.
Any 1.19.* releases should come out of that release branch.
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
When using volume mounts, the destination directory will get
created if it does not exists. The current code blows up when
the destination directory did not exists.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Some pull policies require to first look up a local image and compare
that to the remote counter part. When looking up the remote image, we
need to make sure to use the name of the local image, if it exists.
This fixes a bug where a short name resolved to an image with the
"localhost/" prefix. This prefix is only used for local image look ups
via `shortnames.ResolveLocally`. Hence, when looking up the remote
counter part, we must preserve this prefix.
Fixes: #2904
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Prior to Docker 20.10, failed COPY/ADD instructions result in error
messages containing the string `no such file or directory`. This was
changed in docker to a string containing `file not found`. Since
the conformance tests potentially need to work with multiple docker
versions, they need to be sensitive to both errors.
Signed-off-by: Chris Evich <cevich@redhat.com>
On newer versions of `time`, the error message quotes the bad value.
This leads to an erroneous failure in the test:
```
working-container
time: invalid duration ABCD'
time: invalid duration "ABCD"'
```
The comparison used for `expect_output --substrig` supports basic
regular expressions. Encode the expected value in the test to be
tolerant of quoting in the output value.
Signed-off-by: Chris Evich <cevich@redhat.com>
This test fails after updating to new VM images which include
https://github.com/containers/common/pull/319
Work around the problem by adding in the capabilities expected
to be present. Thanks to @edsantiago and @giuseppe for the fix.
Signed-off-by: Chris Evich <cevich@redhat.com>
Due to necessary changes in both scripts and within images, updates are
necessary for this script to function. These changes also bring
the script very close to being identical to the same in the
containers/podman repository. The intent is to support a future
where this script can simply be shared across repos.
Signed-off-by: Chris Evich <cevich@redhat.com>
Also, utilize the common library functions from containers/automation.
This library is now pre-installed into the VM images. There are some
minor API differences to a few frequently used functions. Otherwise
the behaviors are largely identical.
Signed-off-by: Chris Evich <cevich@redhat.com>
Utilize VM Images produced from the containers/automation_images repo.
Also, rearrange tasks to more closely match their runtime dependency
order.
Signed-off-by: Chris Evich <cevich@redhat.com>
This change mirrors a similar change made in early 2020 for the
containers/podman repository. Primarily, it alters the appearance of
the task names in the Github WebUI to be more readable by humans.
Also, the former "gate" task is renamed to "smoke". This prevents
confusion with downstream Fedora/RHEL post-packaging testing which
is(also referred to as the "gate" tests.
Finally, task-dependencies are altered to support a cleaner flow which
will be implemented in a future commit.
Signed-off-by: Chris Evich <cevich@redhat.com>
When it was first introduced, the blob info cache's location didn't
change from the system-wide default location when we were running in
rootless mode, so we started setting its location ourselves to avoid
triggering permissions errors when updating it.
The image library has since started taking into account that it was
running in rootless mode, but its hardwired default isn't the same as
the one we were setting, so we ended up creating a second cache file.
Stop doing that.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
When you create a manifest or pull a manifest, it shows up
inside of the buildah images list. When you go to inspect it
the inspect code blows up with a cryptic error message.
This patch fixes this problem and just uses the buildah manifest inspect
code.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Currently manifests just look like images in container storage.
It is surprising to the user when they go to push the images
that they end up failing, and have to use the buildah manifest push.
This patch causes buildah push to failover to buildah manifest push
if the image is a manifest.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1900822
Currently we are not passing the TMPDIR to the destination context
so when copying to containers storage we always fall back to /var/tmp.
This change sets the destination to match the source, so we can better
handle the storage.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Remove --override-os and --override-arch flags.
Also use --platform option if specified when generating the SystemContext.
Conflict --platform option with --os, --arch and --variant options.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
