1
0
mirror of https://github.com/containers/buildah.git synced 2026-02-05 09:45:38 +01:00

Use for range over integers

Available since Go 1.22 (see https://tip.golang.org/ref/spec#For_range).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This commit is contained in:
Kir Kolyshkin
2025-04-07 12:05:10 -07:00
parent c46bbf46af
commit 17777cf8ac
3 changed files with 6 additions and 6 deletions

View File

@@ -2117,7 +2117,7 @@ func (s *StageExecutor) generateCacheKey(ctx context.Context, currNode *parser.N
if err != nil {
return "", fmt.Errorf("getting history of base image %q: %w", s.builder.FromImageID, err)
}
for i := 0; i < len(diffIDs); i++ {
for i := range len(diffIDs) {
fmt.Fprintln(hash, diffIDs[i].String())
}
}

View File

@@ -124,13 +124,13 @@ func checkValue(t *testing.T, value reflect.Value, name string, kind reflect.Kin
case reflect.Map:
assert.Falsef(t, value.IsZero(), "map field %s not set when it was not already expected to be left unpopulated by conversion", name)
keys := value.MapKeys()
for i := 0; i < len(keys); i++ {
for i := range len(keys) {
v := value.MapIndex(keys[i])
checkValue(t, v, name+"{"+keys[i].String()+"}", elemType.Kind(), nil, allowedToBeZero)
}
case reflect.Slice:
assert.Falsef(t, value.IsZero(), "slice field %s not set when it was not already expected to be left unpopulated by conversion", name)
for i := 0; i < value.Len(); i++ {
for i := range value.Len() {
v := value.Index(i)
checkValue(t, v, name+"["+strconv.Itoa(i)+"]", elemType.Kind(), nil, allowedToBeZero)
}

View File

@@ -696,7 +696,7 @@ func buildUsingDocker(ctx context.Context, t *testing.T, client *docker.Client,
continue
}
needToEnsureBase := true
for j := 0; j < i; j++ {
for j := range i {
if stageBase == stages[j].Name {
needToEnsureBase = false
}
@@ -1314,10 +1314,10 @@ func compareJSON(a, b map[string]any, skip []string) (missKeys, leftKeys, diffKe
break
}
m := make(map[any]struct{})
for i := 0; i < len(tmpb); i++ {
for i := range len(tmpb) {
m[tmpb[i]] = struct{}{}
}
for i := 0; i < len(tmpa); i++ {
for i := range len(tmpa) {
if _, ok := m[tmpa[i]]; !ok {
diffKeys = append(diffKeys, diffDebug(k, v, vb))
isSame = false