From b0a39618324e8543fdd193237bbb80c29dabc167 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gy=C3=B6rgy=20Krajcsovits?= Date: Mon, 16 Jun 2025 13:14:21 +0200 Subject: [PATCH] fix(abnf-checker): return error on example error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We just printed the error before but not set exit code. Signed-off-by: György Krajcsovits --- docs/specs/om/open_metrics_spec_2_0.md | 1 + openmetrics-spec-tests/check_openmetrics_spec.py | 3 +++ 2 files changed, 4 insertions(+) diff --git a/docs/specs/om/open_metrics_spec_2_0.md b/docs/specs/om/open_metrics_spec_2_0.md index 675b3d0b..d03b32f8 100644 --- a/docs/specs/om/open_metrics_spec_2_0.md +++ b/docs/specs/om/open_metrics_spec_2_0.md @@ -1184,3 +1184,4 @@ OpenMetrics would like to register two MIME types, `application/openmetrics-text + diff --git a/openmetrics-spec-tests/check_openmetrics_spec.py b/openmetrics-spec-tests/check_openmetrics_spec.py index 40fd20d3..2a9c4ab5 100644 --- a/openmetrics-spec-tests/check_openmetrics_spec.py +++ b/openmetrics-spec-tests/check_openmetrics_spec.py @@ -105,9 +105,12 @@ if __name__ == "__main__": print(f"Error parsing ABNF: {e}") sys.exit(1) print("ABNF parsed successfully.") + exit_code = 0 for ex in examples(filename): try: Grammar.get(start_node).parse_all(ex.content) print(f"Example parsed successfully: {ex.line_number}: {ex.content[:30]}...") # Print first 30 chars except Exception as e: print(f"Error parsing example at line {ex.line_number}: {e}\nExample: {ex.content[:30]}...") + exit_code = 2 + sys.exit(exit_code)