From 410443d27be8bc911af86a826beb13c25d46e4dd Mon Sep 17 00:00:00 2001 From: Jan Fajerski Date: Tue, 27 Jan 2026 16:57:01 +0100 Subject: [PATCH] naming: improve unit suggestion Signed-off-by: Jan Fajerski --- docs/practices/naming.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/practices/naming.md b/docs/practices/naming.md index 4999feb5..0c6f0060 100644 --- a/docs/practices/naming.md +++ b/docs/practices/naming.md @@ -24,7 +24,7 @@ A metric name... (exported by many client libraries) * http\_request\_duration\_seconds (for all HTTP requests) -* ...MUST have a single unit (i.e. do not mix seconds with milliseconds, or seconds with bytes). +* ...MUST refer to a single unit (e.g. do not mix seconds with milliseconds) and to a single quantity (e.g. do not mix request size with request duration). * ...SHOULD use base units (e.g. seconds, bytes, meters - not milliseconds, megabytes, kilometers). See [below](#base-units) for a list of base units. * ...SHOULD have a suffix describing the unit, in plural form. Note that an accumulating count has `total` as a suffix, in addition to the unit if applicable. Also note that this applies to units in the narrow sense (like the units in the table below), but not to countable things in general. For example, connections or notifications are not considered units for this rule and do not have to be at the end of the metric name. (See also examples in the next paragraph.) * http\_request\_duration\_seconds