From 8d14d8b0153332a387bcac8aedba637abc63bc1c Mon Sep 17 00:00:00 2001 From: beorn7 Date: Wed, 3 Sep 2025 17:23:00 +0200 Subject: [PATCH] histogram spec: Fix wording around annotation about counter resets Previously, we wrongly stated that there will never be an annotation about conflicting counter resets ever. However, with the HistogramStatsIterator (used for functions `histogram_count`, `histogram_sum`, and `histogram_avg`), you could craft a query that will produce the annotation. Signed-off-by: beorn7 --- docs/specs/native_histograms.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/specs/native_histograms.md b/docs/specs/native_histograms.md index 21792fdf..4986db89 100644 --- a/docs/specs/native_histograms.md +++ b/docs/specs/native_histograms.md @@ -1781,8 +1781,10 @@ above](#unary-minus-and-negative-histograms). Adding or subtracting two counter histograms with directly contradicting counter reset hints (i.e. `CounterReset` and `NotCounterReset`) triggers a warn-level annotation. (TODO: As described [above](#counter-reset-considerations), the TSDB currently does not return -`NotCounterReset`, so this annotation will not happen in practice. See -[tracking issue](https://github.com/prometheus/prometheus/issues/15346).) +`NotCounterReset`, so this annotation will only happen under specific +circumstances involving the `HistogramStatsIterator`, which includes additional +counter reset tracking. See [tracking +issue](https://github.com/prometheus/prometheus/issues/15346).) Multiplication (`*`) works between a float sample or a scalar on the one side and a histogram on the other side, in any order. It multiplies all bucket