1
0
mirror of https://github.com/projectatomic/atomic.git synced 2026-02-06 03:45:28 +01:00

36 Commits

Author SHA1 Message Date
Brent Baude
ed763d4c2d Full pylint run and cleanups. Passes all tests. 2016-11-07 13:15:53 -06:00
Brent Baude
802836f43d WIP refactor 2016-11-07 13:15:53 -06:00
Dan Walsh
28579aea79 Cleanup of dbus interfaces
Rename atomic_client to atomic_dbus_client, so it is easier to understand.
Cleanup a couple of errors causin dbus to break.

Closes: #732
Approved by: rhatdan
2016-10-27 13:37:16 +00:00
Dan Walsh
04b0913cb5 Revert atomic host dbus support
OSTree commands already have Cockpit/dbus support.  Users should
call them directly.

Closes: #733
Approved by: cgwalters
2016-10-26 18:57:44 +00:00
Dan Walsh
656ade8846 Cleanup handling of dbus calls and test client.
Closes: #723
Approved by: rhatdan
2016-10-24 21:39:23 +00:00
Brent Baude
112abcf2ac Atomic/info.py: Fix info and version
The atomic image version subcommand was broken.  Among the issues
was it called the wrong method, attempted to obtain the image
if not locally present, and outputted incorrect information. Some
of the problems were described in:

     https://github.com/projectatomic/atomic/issues/708

The version method has been redone to obtain the correct information.  It
no longer attempts to obtain the image if not present. It raises an
error.

Also, moved the version method into info and performed a pep8 clean up.

Example output now appears like:

```
atomic --debug version -r docker.io/busybox

IMAGE NAME                                     VERSION   IMAGE ID
10.3.11.254:5000/baude/busybox:latest          None      e02e811dd08f
  Tag: docker.io/busybox:latest
  Tag: localhost:5000/busybox:latest

atomic --debug version -r registry.access.redhat.com/rhel7/rsyslog

IMAGE NAME                                               VERSION                IMAGE ID
registry.access.redhat.com/rhel7/rsyslog:latest          rhel7/rsyslog-7.2-21   53f20e902da7
registry.access.redhat.com/rhel7.2:7.2-56                rhel7/rhel-7.2-56      1a9b3357bac5

```

Closes: #710
Approved by: baude
2016-10-14 19:53:03 +00:00
Dan Walsh
3fd6c15297 Add dbus support for atomic stop
Closes: #682
Approved by: rhatdan
2016-10-08 09:56:20 +00:00
Dan Walsh
ea1bf06d98 Add dbus support for atomic install/uninstall
Closes: #682
Approved by: rhatdan
2016-10-08 09:56:20 +00:00
Dan Walsh
31527472c2 Add dbus support for atomic run
Closes: #682
Approved by: rhatdan
2016-10-08 09:56:20 +00:00
Dan Walsh
217bc6288c Add dbus support for atomic pull
Closes: #682
Approved by: rhatdan
2016-10-08 09:56:20 +00:00
Dan Walsh
57a223b401 Add dbus support for atomic top.
Also add missing force qualifier for ContainersDelete

Closes: #682
Approved by: rhatdan
2016-10-08 09:56:20 +00:00
Dan Walsh
c0256dcfe6 Implement dbus interface for atomic commands
Add missing interfaces.

Fix functions to return text, rather then displaying directly.

Change atomic_client.py to take input from command line. These args are translated into function calls in python.

Add tests scripts in tests/integration/dbus directory

Closes: #668
Approved by: rhatdan
2016-10-04 14:31:42 +00:00
Dan Walsh
29e7829fd8 Move atomic ps to atomic containers
As we add more commands related to containers, IE Trim, we need to make
containers be a subcommand and add verbs like list, and trim

Closes: #579
Approved by: giuseppe
2016-09-02 11:10:08 +00:00
Dan Walsh
45ec779178 Move generate from atomic verify to atomic images
Also breakout images handling into a separate python file.

Atomic/images.py

I have switched atomic images generate to generate an images
mtree file for each image in the system.

Closes: #534
Approved by: giuseppe
2016-08-16 08:03:19 +00:00
AmartC
63024095fa Implementing Atomic ps for DBus API
Closes: #516
Approved by: giuseppe
2016-08-05 17:48:23 +00:00
AmartC
14f613eb23 DBus API to retrieve images data and vulnerability information
images now either print to tty or return json data via dbus

Make encoding and decoding work properly for both Python2 and Python3

Create Cockpit JavaScript test client that will call the DBus API
and receive information.

Closes: #494
Approved by: rhatdan
2016-07-29 19:08:27 +00:00
AmartC
1c329531a7 Extra comment removed
Closes: #482
Approved by: rhatdan
2016-07-15 16:21:51 +00:00
AmartC
e2f30deec6 Update support for Dbus API
Closes: #481
Approved by: rhatdan
2016-07-15 15:41:25 +00:00
AmartC
a47341a179 Fix verify for DBus API
Closes: #479
Approved by: rhatdan
2016-07-15 13:31:37 +00:00
Dan Walsh
17e887ace7 Lots of cleanups for pylint and python3-lint warnings
Closes: #463
Approved by: jlebon
2016-07-14 22:02:54 +00:00
AmartC
2b56f1d9a8 Making scan work for Dbus API 2016-07-14 11:06:03 -04:00
AmartC
6cdb51841f Dbus API which now works with scan. Includes changes to client and server.
Closes: #462
Approved by: rhatdan
2016-07-11 22:22:27 +00:00
Dan Walsh
f2974f5bff Remove unused and bogus ;
Beginning to cleanup code to remove warnings from pylint

Testing with

	$(PYTHON3_PYLINT) --disable=all --enable=E --enable=W --additional-builtins=_ *.py atomic Atomic tests/unit/*.py

Reveals these unused and bogus ;.

Closes: #461
Approved by: cgwalters
2016-07-11 16:50:47 +00:00
Dan Walsh
ebece46bad Change atomic dbus permissions
When actually modifying the system we need to require org.atomic.readwrite

Closes: #459
Approved by: cgwalters
2016-07-08 20:30:21 +00:00
Dan Walsh
5fb6fe2dcc Fix build issues on python3 with python3-pylint
Force make test to test python3-pylint.

Closes: #453
Approved by: jlebon
2016-07-08 16:22:17 +00:00
AmartC
302e95eb65 Get list of scanners returned to the user 2016-06-24 10:01:44 -04:00
AmartC
14241ea5d3 Changes made to diff and atomic_dbus.
Also note that for atomic_client, there was cases added to handle the other Atomic features which were already in atomic_dbus such as version, verify and storage.

Closes: #437
Approved by: rhatdan
2016-06-23 15:32:31 +00:00
Alex Jia
46af8c4357 atomic_dbus: fix undefined variable
Signed-off-by: Alex Jia <ajia@redhat.com>
2016-06-14 06:40:42 -04:00
Dan Walsh
ea932628a6 foobar 2016-06-11 05:48:18 -04:00
AmartC
79202a8506 atomic_dbus: Revert pylint breakage
The previous changes to make pylint happy broke things,
so revert them and add an ignore flag.

Closes: #417
Approved by: rhatdan
2016-06-09 13:52:54 +00:00
Jonathan Lebon
d34e4ff880 pylint: disable no-name-in-module for GLib
For some reason, pylint fails to find GLib in gi.repository. Disable
that error.
2015-12-18 10:41:34 -05:00
Dan Walsh
ec5ab037da Use from . import methods 2015-11-30 16:16:51 -05:00
Dan Walsh
1189a252a9 pylint is complaining about super on some fedora 2015-11-11 11:14:27 -05:00
Navid Shaikh
5d45d490d6 Fixes pep8 warnings for python modules 2015-08-11 13:28:07 +05:30
William Temple
179a1211f8 PEP8 (Python style guide) Compliance
Signed-off-by: William Temple <wtemple@redhat.com>
2015-07-29 12:44:31 -04:00
Dan Walsh
735ab7b6b5 Rename atomic_server.py to atomic_dbus.py
Also cleanup setup.py to handle most of the setup.
setup handles python3 issues better then standard Makefile
2015-07-13 08:30:33 -04:00