There were three unused verification options normally available to the
atomic CLI but absent in the dbus API: no_validate, verbose, and
storage. These were added to the dbus client and server.
Signed-off-by: baude <bbaude@redhat.com>
Closes: #1086
Approved by: rhatdan
When pushing an image to registry anonymously, the check for user and
password should not fail. This was reported in BZ #1453135.
Added ImagePush() to dbus_client which was lacking.
Closes: #1015
Approved by: giuseppe
We need to make sure the atomic_dbus_client code works and if something
in atomic_dbus.py changes, the client should either be updated or still
work.
Closes: #975
Approved by: rhatdan
When installing an image, we now write a small bit of json
to /var/lib/atomic/install.json. The json format is:
{
<image_name>: {
id: <image_id>,
install_date: <install_date_in_utc
}
}
This will be used in update, run, etc to ensure that any image
with an INSTALL label is first installed.
Closes: #950
Approved by: giuseppe
There was a bug in the update code where passing the
kwargs and the named variable force resulted in a TypeError
for multiple values existing.
Fixed by not passing the force keyword to _docker.py and
extracting the keyword from the kwargs.
Closes: #881
Approved by: rhatdan
In the case of cockpit, it would be preferable to be able
to lookup scan results by a container or image's id. If the
container or image has not been scanned, we throw an exception;
otherwise we return the resulting json file as a str.
One other possible exception can be thrown when attempting to read
the desired file from the filesystem. If the file cannot be read,
an exception will be thrown. Either way, it is a clear indicator
that the object needs to be scanned for fresh results.
The following is a simple *python* example:
from atomic_dbus_client import AtomicDBus
ad = AtomicDBus()
results = ad.GetScanResultsById('6858a846fb6b557331e068252fd910b5dc93f8e6341e641400bf4582dc34e10d')
Note the use of the full ID. As of now, we only look up against the full id
as opposed to the short id form which is often used.
Closes: #874
Approved by: baude
This makes the default SPC_ARGS and RUN_ARGS a bit smarter. We only add
"-t" if we're attached to a terminal, otherwise Docker will fail to
start. We also add a --detach option to passthrough to `docker run`.
These options make atomic easier to use through D-Bus.
Closes: #776
Approved by: rhatdan
The 'user' parameter of Install() is a bool, not a string.
The 'command' parameter of Run() is a list of strings, not a string.
Closes: #776
Approved by: rhatdan
Rename atomic_client to atomic_dbus_client, so it is easier to understand.
Cleanup a couple of errors causin dbus to break.
Closes: #732
Approved by: rhatdan