1
0
mirror of https://github.com/projectatomic/atomic.git synced 2026-02-07 06:44:52 +01:00
Commit Graph

11 Commits

Author SHA1 Message Date
Brent Baude
dcbe9b5b92 Atomic/diff.py Add release to version, name, and epoch of RPM
When an RPM diff was performed between two docker objects, we
previously only store the name, version, and epoch of the RPM for
comparision.  It turns out versioning information is also done in
the release portion as well.

This addresses https://github.com/projectatomic/atomic/issues/315
2016-03-04 14:36:51 -06:00
Brent Baude
758ab4d7af Atomic Diff: RPMS arent being collected
Due to very small bug, the function that collects the
operating system version and RPMs was not being called.
2015-12-15 13:02:07 -06:00
Brent Baude
327f152d4b BUGFIX: Atomic diff leaks FD (BZ # 1285006)
Under the condition that you diff two images and one or both
of the images are not RPM based, no cleanup of the mounts and
dm devices was done. This was reported via BZ #1285006.

We now handle the exit and cleanup differently which counts
for this condition.

Also added a try/except for catching control-c, where if found
it will clean up the mounts and dm devices.
2015-12-10 11:02:00 -06:00
Dan Walsh
ec5ab037da Use from . import methods 2015-11-30 16:16:51 -05:00
Brent Baude
d9fed17a13 Move lengthy subfunctions to classes
Set a pattern where if an atomic subfunction
is lengthy, then we can break that out into its own class.
This reduces the overall size of the Atomic class and allows
new development and debug to be cleaner.

Instead of using the func function of argparser, we pass
the Class and Function that should be run as variables. For
example, the Atomic verify subfunction would now be:

    _class=Atomic.Atomic, func='verify'

The defined class is instantiated after parseargs is run.  We
then perform the set_args and call the function.
2015-11-30 14:53:21 -06:00
Dan Walsh
ca5243baad Fix output of diff to work on python3 2015-11-24 11:10:42 -05:00
Dan Walsh
1577419951 I merged Colins patch instead of mine
This reverses my previous patch
2015-11-24 09:21:30 -05:00
Daniel J Walsh
a9aede9da3 Merge pull request #229 from cgwalters/pylint-pyrpm
diff: Quiet pylint warning
2015-11-24 09:20:26 -05:00
Dan Walsh
df23b26d95 Fix bogus pylint error 2015-11-24 08:58:36 -05:00
Colin Walters
40901254fe diff: Quiet pylint warning
It doesn't understand native code bindings.
2015-11-23 21:36:57 -05:00
Brent Baude
6e24d6bcdb Introduce 'atomic diff'
Allow users to diff between two docker images|container. There
    are two types of diffs that can be run -- a file diff or an
    RPM diff.  The file diff is always the default.  The RPM diff
    can be added with -r.  The file diff can be excluded with -n.
2015-11-23 15:46:06 -06:00