mirror of
https://github.com/openshift/source-to-image.git
synced 2026-02-05 12:44:54 +01:00
743 lines
24 KiB
Go
743 lines
24 KiB
Go
// +build integration
|
|
|
|
package docker
|
|
|
|
import (
|
|
"encoding/json"
|
|
"flag"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"runtime"
|
|
"testing"
|
|
"time"
|
|
|
|
dockertypes "github.com/docker/docker/api/types"
|
|
dockercontainer "github.com/docker/docker/api/types/container"
|
|
dockerapi "github.com/docker/docker/client"
|
|
"golang.org/x/net/context"
|
|
|
|
"k8s.io/klog/v2"
|
|
|
|
"github.com/openshift/source-to-image/pkg/api"
|
|
"github.com/openshift/source-to-image/pkg/build"
|
|
"github.com/openshift/source-to-image/pkg/build/strategies"
|
|
"github.com/openshift/source-to-image/pkg/docker"
|
|
dockerpkg "github.com/openshift/source-to-image/pkg/docker"
|
|
"github.com/openshift/source-to-image/pkg/scm/git"
|
|
"github.com/openshift/source-to-image/pkg/tar"
|
|
"github.com/openshift/source-to-image/pkg/util"
|
|
"github.com/openshift/source-to-image/pkg/util/fs"
|
|
)
|
|
|
|
const (
|
|
DefaultDockerSocket = "unix:///var/run/docker.sock"
|
|
TestSource = "https://github.com/openshift/ruby-hello-world"
|
|
|
|
FakeBuilderImage = "sti_test/sti-fake"
|
|
FakeUserImage = "sti_test/sti-fake-user"
|
|
FakeImageScripts = "sti_test/sti-fake-scripts"
|
|
FakeImageScriptsNoSaveArtifacts = "sti_test/sti-fake-scripts-no-save-artifacts"
|
|
FakeImageNoTar = "sti_test/sti-fake-no-tar"
|
|
FakeImageOnBuild = "sti_test/sti-fake-onbuild"
|
|
FakeNumericUserImage = "sti_test/sti-fake-numericuser"
|
|
FakeImageOnBuildRootUser = "sti_test/sti-fake-onbuild-rootuser"
|
|
FakeImageOnBuildNumericUser = "sti_test/sti-fake-onbuild-numericuser"
|
|
FakeImageAssembleRoot = "sti_test/sti-fake-assemble-root"
|
|
FakeImageAssembleUser = "sti_test/sti-fake-assemble-user"
|
|
|
|
TagCleanBuild = "test/sti-fake-app"
|
|
TagCleanBuildUser = "test/sti-fake-app-user"
|
|
TagIncrementalBuild = "test/sti-incremental-app"
|
|
TagIncrementalBuildUser = "test/sti-incremental-app-user"
|
|
TagCleanBuildScripts = "test/sti-fake-app-scripts"
|
|
TagIncrementalBuildScripts = "test/sti-incremental-app-scripts"
|
|
TagIncrementalBuildScriptsNoSaveArtifacts = "test/sti-incremental-app-scripts-no-save-artifacts"
|
|
TagCleanLayeredBuildNoTar = "test/sti-fake-no-tar"
|
|
TagCleanBuildOnBuild = "test/sti-fake-app-onbuild"
|
|
TagIncrementalBuildOnBuild = "test/sti-incremental-app-onbuild"
|
|
TagCleanBuildOnBuildNoName = "test/sti-fake-app-onbuild-noname"
|
|
TagCleanBuildNoName = "test/sti-fake-app-noname"
|
|
TagCleanLayeredBuildNoTarNoName = "test/sti-fake-no-tar-noname"
|
|
TagCleanBuildAllowedUIDsNamedUser = "test/sti-fake-alloweduids-nameduser"
|
|
TagCleanBuildAllowedUIDsNumericUser = "test/sti-fake-alloweduids-numericuser"
|
|
TagCleanBuildAllowedUIDsOnBuildRoot = "test/sti-fake-alloweduids-onbuildroot"
|
|
TagCleanBuildAllowedUIDsOnBuildNumericUser = "test/sti-fake-alloweduids-onbuildnumeric"
|
|
TagCleanBuildAllowedUIDsAssembleRoot = "test/sti-fake-alloweduids-assembleroot"
|
|
TagCleanBuildAllowedUIDsAssembleUser = "test/sti-fake-alloweduids-assembleuser"
|
|
|
|
// Need to serve the scripts from local host so any potential changes to the
|
|
// scripts are made available for integration testing.
|
|
//
|
|
// Port 23456 must match the port used in the fake image Dockerfiles
|
|
FakeScriptsHTTPURL = "http://127.0.0.1:23456/.s2i/bin"
|
|
)
|
|
|
|
var engineClient docker.Client
|
|
|
|
func init() {
|
|
klog.InitFlags(nil)
|
|
|
|
var err error
|
|
engineClient, err = docker.NewEngineAPIClient(docker.GetDefaultDockerConfig())
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
// get the full path to this .go file so we can construct the file url
|
|
// using this file's dirname
|
|
_, filename, _, _ := runtime.Caller(0)
|
|
testImagesDir := filepath.Join(filepath.Dir(filepath.Dir(filename)), "scripts")
|
|
|
|
l, err := net.Listen("tcp", ":23456")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
hs := http.Server{Handler: http.FileServer(http.Dir(testImagesDir))}
|
|
hs.SetKeepAlivesEnabled(false)
|
|
go hs.Serve(l)
|
|
}
|
|
|
|
func getDefaultContext() (context.Context, context.CancelFunc) {
|
|
return context.WithTimeout(context.Background(), 20*time.Second)
|
|
}
|
|
|
|
// TestInjectionBuild tests the build where we inject files to assemble script.
|
|
func TestInjectionBuild(t *testing.T) {
|
|
tempdir, err := ioutil.TempDir("", "s2i-test-dir")
|
|
if err != nil {
|
|
t.Errorf("Unable to create temporary directory: %v", err)
|
|
}
|
|
defer os.RemoveAll(tempdir)
|
|
|
|
err = ioutil.WriteFile(filepath.Join(tempdir, "secret"), []byte("secret"), 0666)
|
|
if err != nil {
|
|
t.Errorf("Unable to write content to temporary injection file: %v", err)
|
|
}
|
|
|
|
integration(t).exerciseInjectionBuild(TagCleanBuild, FakeBuilderImage, []string{
|
|
tempdir + ":/tmp",
|
|
tempdir + ":",
|
|
tempdir + ":test;" + tempdir + ":test2",
|
|
}, true)
|
|
}
|
|
|
|
func TestInjectionBuildBadDestination(t *testing.T) {
|
|
tempdir, err := ioutil.TempDir("", "s2i-test-dir")
|
|
if err != nil {
|
|
t.Errorf("Unable to create temporary directory: %v", err)
|
|
}
|
|
defer os.RemoveAll(tempdir)
|
|
|
|
err = ioutil.WriteFile(filepath.Join(tempdir, "secret"), []byte("secret"), 0666)
|
|
if err != nil {
|
|
t.Errorf("Unable to write content to temporary injection file: %v", err)
|
|
}
|
|
|
|
integration(t).exerciseInjectionBuild(TagCleanBuild, FakeBuilderImage, []string{tempdir + ":/bad/dir"}, false)
|
|
}
|
|
|
|
type integrationTest struct {
|
|
t *testing.T
|
|
setupComplete bool
|
|
}
|
|
|
|
func (i integrationTest) InspectImage(name string) (*dockertypes.ImageInspect, error) {
|
|
ctx, cancel := getDefaultContext()
|
|
defer cancel()
|
|
resp, _, err := engineClient.ImageInspectWithRaw(ctx, name)
|
|
if err != nil {
|
|
if dockerapi.IsErrNotFound(err) {
|
|
return nil, fmt.Errorf("no such image :%q", name)
|
|
}
|
|
return nil, err
|
|
}
|
|
return &resp, nil
|
|
}
|
|
|
|
var (
|
|
FakeScriptsFileURL string
|
|
)
|
|
|
|
func getLogLevel() (level int) {
|
|
for level = 5; level >= 0; level-- {
|
|
if klog.V(klog.Level(level)) == true {
|
|
break
|
|
}
|
|
}
|
|
return
|
|
}
|
|
|
|
// setup sets up integration tests
|
|
func (i *integrationTest) setup() {
|
|
if !i.setupComplete {
|
|
// get the full path to this .go file so we can construct the file url
|
|
// using this file's dirname
|
|
_, filename, _, _ := runtime.Caller(0)
|
|
|
|
testImagesDir := filepath.Join(filepath.Dir(filepath.Dir(filename)), "scripts")
|
|
FakeScriptsFileURL = "file://" + filepath.ToSlash(filepath.Join(testImagesDir, ".s2i", "bin"))
|
|
|
|
for _, image := range []string{TagCleanBuild, TagCleanBuildUser, TagIncrementalBuild, TagIncrementalBuildUser} {
|
|
ctx, cancel := getDefaultContext()
|
|
engineClient.ImageRemove(ctx, image, dockertypes.ImageRemoveOptions{})
|
|
cancel()
|
|
}
|
|
|
|
i.setupComplete = true
|
|
}
|
|
|
|
from := flag.CommandLine
|
|
if vflag := from.Lookup("v"); vflag != nil {
|
|
// the thing here is that we are looking for the bash -v passed into test-integration.sh (with no value),
|
|
// but for klog (https://k8s.io/klog/v2/blob/master/klog.go), one specifies
|
|
// the logging level with -v=# (i.e. -v=0 or -v=3 or -v=5).
|
|
// so, for the changes stemming from issue 133, we 'reuse' the bash -v, and set the highest klog level.
|
|
// (if you look at STI's main.go, and setupGlog, it essentially maps klog's -v to --loglevel for use by the sti command)
|
|
//NOTE - passing --loglevel or -v=5 into test-integration.sh does not work
|
|
if getLogLevel() != 5 {
|
|
vflag.Value.Set("5")
|
|
// FIXME currently klog has only option to redirect output to stderr
|
|
// the preferred for STI would be to redirect to stdout
|
|
flag.CommandLine.Set("logtostderr", "true")
|
|
}
|
|
}
|
|
}
|
|
|
|
func integration(t *testing.T) *integrationTest {
|
|
i := &integrationTest{t: t}
|
|
i.setup()
|
|
return i
|
|
}
|
|
|
|
// Test a clean build. The simplest case.
|
|
func TestCleanBuild(t *testing.T) {
|
|
integration(t).exerciseCleanBuild(TagCleanBuild, false, FakeBuilderImage, "", true, true, false)
|
|
}
|
|
|
|
// Test Labels
|
|
func TestCleanBuildLabel(t *testing.T) {
|
|
integration(t).exerciseCleanBuild(TagCleanBuild, false, FakeBuilderImage, "", true, true, true)
|
|
}
|
|
|
|
func TestCleanBuildUser(t *testing.T) {
|
|
integration(t).exerciseCleanBuild(TagCleanBuildUser, false, FakeUserImage, "", true, true, false)
|
|
}
|
|
|
|
func TestCleanBuildFileScriptsURL(t *testing.T) {
|
|
integration(t).exerciseCleanBuild(TagCleanBuild, false, FakeBuilderImage, FakeScriptsFileURL, true, true, false)
|
|
}
|
|
|
|
func TestCleanBuildHttpScriptsURL(t *testing.T) {
|
|
integration(t).exerciseCleanBuild(TagCleanBuild, false, FakeBuilderImage, FakeScriptsHTTPURL, true, true, false)
|
|
}
|
|
|
|
func TestCleanBuildScripts(t *testing.T) {
|
|
integration(t).exerciseCleanBuild(TagCleanBuildScripts, false, FakeImageScripts, "", true, true, false)
|
|
}
|
|
|
|
func TestLayeredBuildNoTar(t *testing.T) {
|
|
integration(t).exerciseCleanBuild(TagCleanLayeredBuildNoTar, false, FakeImageNoTar, FakeScriptsFileURL, false, true, false)
|
|
}
|
|
|
|
// Test that a build config with a callbackURL will invoke HTTP endpoint
|
|
func TestCleanBuildCallbackInvoked(t *testing.T) {
|
|
integration(t).exerciseCleanBuild(TagCleanBuild, true, FakeBuilderImage, "", true, true, false)
|
|
}
|
|
|
|
func TestCleanBuildOnBuild(t *testing.T) {
|
|
integration(t).exerciseCleanBuild(TagCleanBuildOnBuild, false, FakeImageOnBuild, "", true, true, false)
|
|
}
|
|
|
|
func TestCleanBuildOnBuildNoName(t *testing.T) {
|
|
integration(t).exerciseCleanBuild(TagCleanBuildOnBuildNoName, false, FakeImageOnBuild, "", false, false, false)
|
|
}
|
|
|
|
func TestCleanBuildNoName(t *testing.T) {
|
|
integration(t).exerciseCleanBuild(TagCleanBuildNoName, false, FakeBuilderImage, "", true, false, false)
|
|
}
|
|
|
|
func TestLayeredBuildNoTarNoName(t *testing.T) {
|
|
integration(t).exerciseCleanBuild(TagCleanLayeredBuildNoTarNoName, false, FakeImageNoTar, FakeScriptsFileURL, false, false, false)
|
|
}
|
|
|
|
func TestAllowedUIDsNamedUser(t *testing.T) {
|
|
integration(t).exerciseCleanAllowedUIDsBuild(TagCleanBuildAllowedUIDsNamedUser, FakeUserImage, true)
|
|
}
|
|
|
|
func TestAllowedUIDsNumericUser(t *testing.T) {
|
|
integration(t).exerciseCleanAllowedUIDsBuild(TagCleanBuildAllowedUIDsNumericUser, FakeNumericUserImage, false)
|
|
}
|
|
|
|
func TestAllowedUIDsOnBuildRootUser(t *testing.T) {
|
|
integration(t).exerciseCleanAllowedUIDsBuild(TagCleanBuildAllowedUIDsNamedUser, FakeImageOnBuildRootUser, true)
|
|
}
|
|
|
|
func TestAllowedUIDsOnBuildNumericUser(t *testing.T) {
|
|
integration(t).exerciseCleanAllowedUIDsBuild(TagCleanBuildAllowedUIDsNumericUser, FakeImageOnBuildNumericUser, false)
|
|
}
|
|
|
|
func TestAllowedUIDsAssembleRoot(t *testing.T) {
|
|
integration(t).exerciseCleanAllowedUIDsBuild(TagCleanBuildAllowedUIDsAssembleRoot, FakeImageAssembleRoot, true)
|
|
}
|
|
|
|
func TestAllowedUIDsAssembleUser(t *testing.T) {
|
|
integration(t).exerciseCleanAllowedUIDsBuild(TagCleanBuildAllowedUIDsAssembleUser, FakeImageAssembleUser, false)
|
|
}
|
|
|
|
func (i *integrationTest) exerciseCleanAllowedUIDsBuild(tag, imageName string, expectError bool) {
|
|
t := i.t
|
|
config := &api.Config{
|
|
DockerConfig: docker.GetDefaultDockerConfig(),
|
|
BuilderImage: imageName,
|
|
BuilderPullPolicy: api.DefaultBuilderPullPolicy,
|
|
Source: git.MustParse(TestSource),
|
|
Tag: tag,
|
|
Incremental: false,
|
|
ScriptsURL: "",
|
|
ExcludeRegExp: tar.DefaultExclusionPattern.String(),
|
|
}
|
|
config.AllowedUIDs.Set("1-")
|
|
_, _, err := strategies.Strategy(engineClient, config, build.Overrides{})
|
|
if err != nil && !expectError {
|
|
t.Fatalf("Cannot create a new builder: %v", err)
|
|
}
|
|
if err == nil && expectError {
|
|
t.Fatalf("Did not get an error and was expecting one.")
|
|
}
|
|
}
|
|
|
|
func (i *integrationTest) exerciseCleanBuild(tag string, verifyCallback bool, imageName string, scriptsURL string, expectImageName bool, setTag bool, checkLabel bool) {
|
|
t := i.t
|
|
callbackURL := ""
|
|
callbackInvoked := false
|
|
callbackHasValidJSON := false
|
|
if verifyCallback {
|
|
handler := func(w http.ResponseWriter, r *http.Request) {
|
|
// we got called
|
|
callbackInvoked = true
|
|
// the header is as expected
|
|
contentType := r.Header["Content-Type"][0]
|
|
callbackHasValidJSON = contentType == "application/json"
|
|
// the request body is as expected
|
|
if callbackHasValidJSON {
|
|
defer r.Body.Close()
|
|
body, _ := ioutil.ReadAll(r.Body)
|
|
type CallbackMessage struct {
|
|
Success bool
|
|
Labels map[string]string
|
|
}
|
|
var callbackMessage CallbackMessage
|
|
err := json.Unmarshal(body, &callbackMessage)
|
|
callbackHasValidJSON = (err == nil) && callbackMessage.Success && len(callbackMessage.Labels) > 0
|
|
}
|
|
}
|
|
ts := httptest.NewServer(http.HandlerFunc(handler))
|
|
defer ts.Close()
|
|
callbackURL = ts.URL
|
|
}
|
|
|
|
var buildTag string
|
|
if setTag {
|
|
buildTag = tag
|
|
} else {
|
|
buildTag = ""
|
|
}
|
|
|
|
config := &api.Config{
|
|
DockerConfig: docker.GetDefaultDockerConfig(),
|
|
BuilderImage: imageName,
|
|
BuilderPullPolicy: api.DefaultBuilderPullPolicy,
|
|
Source: git.MustParse(TestSource),
|
|
Tag: buildTag,
|
|
Incremental: false,
|
|
CallbackURL: callbackURL,
|
|
ScriptsURL: scriptsURL,
|
|
ExcludeRegExp: tar.DefaultExclusionPattern.String(),
|
|
}
|
|
|
|
b, _, err := strategies.Strategy(engineClient, config, build.Overrides{})
|
|
if err != nil {
|
|
t.Fatalf("Cannot create a new builder.")
|
|
}
|
|
resp, err := b.Build(config)
|
|
if err != nil {
|
|
t.Fatalf("An error occurred during the build: %v", err)
|
|
} else if !resp.Success {
|
|
t.Fatalf("The build failed.")
|
|
}
|
|
if callbackInvoked != verifyCallback {
|
|
t.Fatalf("S2I build did not invoke callback")
|
|
}
|
|
if callbackHasValidJSON != verifyCallback {
|
|
t.Fatalf("S2I build did not invoke callback with valid json message")
|
|
}
|
|
|
|
// We restrict this check to only when we are passing tag through the build config
|
|
// since we will not end up with an available tag by that name from build
|
|
if setTag {
|
|
i.checkForImage(tag)
|
|
containerID := i.createContainer(tag)
|
|
i.checkBasicBuildState(containerID, resp.WorkingDir)
|
|
|
|
if checkLabel {
|
|
i.checkForLabel(tag)
|
|
}
|
|
|
|
i.removeContainer(containerID)
|
|
}
|
|
|
|
// Check if we receive back an ImageID when we are expecting to
|
|
if expectImageName && len(resp.ImageID) == 0 {
|
|
t.Fatalf("S2I build did not receive an ImageID in response")
|
|
}
|
|
if !expectImageName && len(resp.ImageID) > 0 {
|
|
t.Fatalf("S2I build received an ImageID in response")
|
|
}
|
|
}
|
|
|
|
// Test an incremental build.
|
|
func TestIncrementalBuildAndRemovePreviousImage(t *testing.T) {
|
|
integration(t).exerciseIncrementalBuild(TagIncrementalBuild, FakeBuilderImage, true, false, false)
|
|
}
|
|
|
|
func TestIncrementalBuildAndKeepPreviousImage(t *testing.T) {
|
|
integration(t).exerciseIncrementalBuild(TagIncrementalBuild, FakeBuilderImage, false, false, false)
|
|
}
|
|
|
|
func TestIncrementalBuildUser(t *testing.T) {
|
|
integration(t).exerciseIncrementalBuild(TagIncrementalBuildUser, FakeBuilderImage, true, false, false)
|
|
}
|
|
|
|
func TestIncrementalBuildScripts(t *testing.T) {
|
|
integration(t).exerciseIncrementalBuild(TagIncrementalBuildScripts, FakeImageScripts, true, false, false)
|
|
}
|
|
|
|
func TestIncrementalBuildScriptsNoSaveArtifacts(t *testing.T) {
|
|
integration(t).exerciseIncrementalBuild(TagIncrementalBuildScriptsNoSaveArtifacts, FakeImageScriptsNoSaveArtifacts, true, true, false)
|
|
}
|
|
|
|
func TestIncrementalBuildOnBuild(t *testing.T) {
|
|
integration(t).exerciseIncrementalBuild(TagIncrementalBuildOnBuild, FakeImageOnBuild, false, true, true)
|
|
}
|
|
|
|
func (i *integrationTest) exerciseInjectionBuild(tag, imageName string, injections []string, expectSuccess bool) {
|
|
t := i.t
|
|
|
|
injectionList := api.VolumeList{}
|
|
for _, i := range injections {
|
|
err := injectionList.Set(i)
|
|
if err != nil {
|
|
t.Errorf("injectionList.Set() failed with error %s\n", err)
|
|
}
|
|
}
|
|
// For test purposes, keep at least one injected source
|
|
var keptVolume *api.VolumeSpec
|
|
if len(injectionList) > 0 {
|
|
injectionList[0].Keep = true
|
|
keptVolume = &injectionList[0]
|
|
}
|
|
config := &api.Config{
|
|
DockerConfig: docker.GetDefaultDockerConfig(),
|
|
BuilderImage: imageName,
|
|
BuilderPullPolicy: api.DefaultBuilderPullPolicy,
|
|
Source: git.MustParse(TestSource),
|
|
Tag: tag,
|
|
Injections: injectionList,
|
|
ExcludeRegExp: tar.DefaultExclusionPattern.String(),
|
|
}
|
|
builder, _, err := strategies.Strategy(engineClient, config, build.Overrides{})
|
|
if err != nil {
|
|
t.Fatalf("Unable to create builder: %v", err)
|
|
}
|
|
resp, err := builder.Build(config)
|
|
if !expectSuccess {
|
|
if resp.Success {
|
|
t.Fatal("Success was returned, but should have failed")
|
|
}
|
|
return
|
|
}
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error occurred during build: %v", err)
|
|
}
|
|
if !resp.Success {
|
|
t.Fatalf("S2I build failed.")
|
|
}
|
|
i.checkForImage(tag)
|
|
containerID := i.createContainer(tag)
|
|
defer i.removeContainer(containerID)
|
|
|
|
// Check that the injected file is delivered to assemble script
|
|
i.fileExists(containerID, "/sti-fake/secret-delivered")
|
|
i.fileExists(containerID, "/sti-fake/relative-secret-delivered")
|
|
|
|
// Make sure the injected file does not exists in resulting image
|
|
testFs := fs.NewFileSystem()
|
|
files, err := util.ListFilesToTruncate(testFs, injectionList)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error: %v", err)
|
|
}
|
|
for _, f := range files {
|
|
if err = i.testFile(tag, f); err == nil {
|
|
t.Errorf("The file %q must be empty or not exist", f)
|
|
}
|
|
}
|
|
if keptVolume != nil {
|
|
keptFiles, err := util.ListFiles(testFs, *keptVolume)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error: %v", err)
|
|
}
|
|
for _, f := range keptFiles {
|
|
if err = i.testFile(tag, f); err != nil {
|
|
t.Errorf("The file %q must exist and not be empty", f)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func (i *integrationTest) testFile(tag, path string) error {
|
|
exitCode := i.runInImage(tag, "test -s "+path)
|
|
if exitCode != 0 {
|
|
return fmt.Errorf("file %s does not exist or is empty in the container %s", path, tag)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (i *integrationTest) exerciseIncrementalBuild(tag, imageName string, removePreviousImage bool, expectClean bool, checkOnBuild bool) {
|
|
t := i.t
|
|
start := time.Now()
|
|
config := &api.Config{
|
|
DockerConfig: docker.GetDefaultDockerConfig(),
|
|
BuilderImage: imageName,
|
|
BuilderPullPolicy: api.DefaultBuilderPullPolicy,
|
|
Source: git.MustParse(TestSource),
|
|
Tag: tag,
|
|
Incremental: false,
|
|
RemovePreviousImage: removePreviousImage,
|
|
ExcludeRegExp: tar.DefaultExclusionPattern.String(),
|
|
}
|
|
|
|
builder, _, err := strategies.Strategy(engineClient, config, build.Overrides{})
|
|
if err != nil {
|
|
t.Fatalf("Unable to create builder: %v", err)
|
|
}
|
|
resp, err := builder.Build(config)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error occurred during build: %v", err)
|
|
}
|
|
if !resp.Success {
|
|
t.Fatalf("S2I build failed.")
|
|
}
|
|
|
|
previousImageID := resp.ImageID
|
|
config = &api.Config{
|
|
DockerConfig: docker.GetDefaultDockerConfig(),
|
|
BuilderImage: imageName,
|
|
BuilderPullPolicy: api.DefaultBuilderPullPolicy,
|
|
Source: git.MustParse(TestSource),
|
|
Tag: tag,
|
|
Incremental: true,
|
|
RemovePreviousImage: removePreviousImage,
|
|
PreviousImagePullPolicy: api.PullIfNotPresent,
|
|
ExcludeRegExp: tar.DefaultExclusionPattern.String(),
|
|
}
|
|
|
|
builder, _, err = strategies.Strategy(engineClient, config, build.Overrides{})
|
|
if err != nil {
|
|
t.Fatalf("Unable to create incremental builder: %v", err)
|
|
}
|
|
resp, err = builder.Build(config)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error occurred during incremental build: %v", err)
|
|
}
|
|
if !resp.Success {
|
|
t.Fatalf("S2I incremental build failed.")
|
|
}
|
|
|
|
i.checkForImage(tag)
|
|
containerID := i.createContainer(tag)
|
|
defer i.removeContainer(containerID)
|
|
i.checkIncrementalBuildState(containerID, resp.WorkingDir, expectClean)
|
|
|
|
_, err = i.InspectImage(previousImageID)
|
|
if removePreviousImage {
|
|
if err == nil {
|
|
t.Errorf("Previous image %s not deleted", previousImageID)
|
|
}
|
|
} else {
|
|
if err != nil {
|
|
t.Errorf("Couldn't find previous image %s", previousImageID)
|
|
}
|
|
}
|
|
|
|
if checkOnBuild {
|
|
i.fileExists(containerID, "/sti-fake/src/onbuild")
|
|
}
|
|
|
|
if took := time.Since(start); took > docker.DefaultDockerTimeout {
|
|
// https://github.com/openshift/source-to-image/issues/301 is a
|
|
// case where incremental builds would get stuck until the
|
|
// timeout.
|
|
t.Errorf("Test took too long (%v), some operation may have gotten stuck waiting for the DefaultDockerTimeout (%v). Inspect the logs to find operations that took long.", took, docker.DefaultDockerTimeout)
|
|
}
|
|
}
|
|
|
|
// Support methods
|
|
func (i *integrationTest) checkForImage(tag string) {
|
|
_, err := i.InspectImage(tag)
|
|
if err != nil {
|
|
i.t.Errorf("Couldn't find image with tag: %s", tag)
|
|
}
|
|
}
|
|
|
|
func (i *integrationTest) createContainer(image string) string {
|
|
ctx, cancel := getDefaultContext()
|
|
defer cancel()
|
|
opts := dockertypes.ContainerCreateConfig{Name: "", Config: &dockercontainer.Config{Image: image}}
|
|
container, err := engineClient.ContainerCreate(ctx, opts.Config, opts.HostConfig, opts.NetworkingConfig, opts.Name)
|
|
if err != nil {
|
|
i.t.Errorf("Couldn't create container from image %s with error %+v", image, err)
|
|
return ""
|
|
}
|
|
|
|
ctx, cancel = getDefaultContext()
|
|
defer cancel()
|
|
err = engineClient.ContainerStart(ctx, container.ID, dockertypes.ContainerStartOptions{})
|
|
if err != nil {
|
|
i.t.Errorf("Couldn't start container: %s with error %+v", container.ID, err)
|
|
return ""
|
|
}
|
|
|
|
ctx, cancel = getDefaultContext()
|
|
defer cancel()
|
|
waitC, errC := engineClient.ContainerWait(ctx, container.ID, dockercontainer.WaitConditionNextExit)
|
|
select {
|
|
case result := <-waitC:
|
|
if result.StatusCode != 0 {
|
|
i.t.Errorf("Bad exit code from container: %d", result.StatusCode)
|
|
return ""
|
|
}
|
|
case err := <-errC:
|
|
i.t.Errorf("Error waiting for container: %v", err)
|
|
return ""
|
|
}
|
|
return container.ID
|
|
}
|
|
|
|
func (i *integrationTest) runInContainer(image string, command []string) int {
|
|
ctx, cancel := getDefaultContext()
|
|
defer cancel()
|
|
opts := dockertypes.ContainerCreateConfig{Name: "", Config: &dockercontainer.Config{Image: image, AttachStdout: false, AttachStdin: false, Cmd: command}}
|
|
container, err := engineClient.ContainerCreate(ctx, opts.Config, opts.HostConfig, opts.NetworkingConfig, opts.Name)
|
|
if err != nil {
|
|
i.t.Errorf("Couldn't create container from image %s err %+v", image, err)
|
|
return -1
|
|
}
|
|
|
|
ctx, cancel = getDefaultContext()
|
|
defer cancel()
|
|
err = engineClient.ContainerStart(ctx, container.ID, dockertypes.ContainerStartOptions{})
|
|
if err != nil {
|
|
i.t.Errorf("Couldn't start container: %s", container.ID)
|
|
}
|
|
ctx, cancel = getDefaultContext()
|
|
defer cancel()
|
|
waitC, errC := engineClient.ContainerWait(ctx, container.ID, dockercontainer.WaitConditionNextExit)
|
|
exitCode := -1
|
|
select {
|
|
case result := <-waitC:
|
|
exitCode = int(result.StatusCode)
|
|
case err := <-errC:
|
|
i.t.Errorf("Couldn't wait for container: %s: %v", container.ID, err)
|
|
}
|
|
ctx, cancel = getDefaultContext()
|
|
defer cancel()
|
|
err = engineClient.ContainerRemove(ctx, container.ID, dockertypes.ContainerRemoveOptions{})
|
|
if err != nil {
|
|
i.t.Errorf("Couldn't remove container: %s", container.ID)
|
|
}
|
|
return exitCode
|
|
}
|
|
|
|
func (i *integrationTest) removeContainer(cID string) {
|
|
ctx, cancel := getDefaultContext()
|
|
defer cancel()
|
|
engineClient.ContainerKill(ctx, cID, "SIGKILL")
|
|
removeOpts := dockertypes.ContainerRemoveOptions{
|
|
RemoveVolumes: true,
|
|
}
|
|
err := engineClient.ContainerRemove(ctx, cID, removeOpts)
|
|
if err != nil {
|
|
i.t.Errorf("Couldn't remove container %s: %s", cID, err)
|
|
}
|
|
}
|
|
|
|
func (i *integrationTest) fileExists(cID string, filePath string) {
|
|
res := i.fileExistsInContainer(cID, filePath)
|
|
|
|
if !res {
|
|
i.t.Errorf("Couldn't find file %s in container %s", filePath, cID)
|
|
}
|
|
}
|
|
|
|
func (i *integrationTest) fileNotExists(cID string, filePath string) {
|
|
res := i.fileExistsInContainer(cID, filePath)
|
|
|
|
if res {
|
|
i.t.Errorf("Unexpected file %s in container %s", filePath, cID)
|
|
}
|
|
}
|
|
|
|
func (i *integrationTest) runInImage(image string, cmd string) int {
|
|
return i.runInContainer(image, []string{"/bin/sh", "-c", cmd})
|
|
}
|
|
|
|
func (i *integrationTest) checkBasicBuildState(cID string, workingDir string) {
|
|
i.fileExists(cID, "/sti-fake/assemble-invoked")
|
|
i.fileExists(cID, "/sti-fake/run-invoked")
|
|
i.fileExists(cID, "/sti-fake/src/Gemfile")
|
|
|
|
_, err := os.Stat(workingDir)
|
|
if !os.IsNotExist(err) {
|
|
i.t.Errorf("Unexpected error from stat check on %s", workingDir)
|
|
}
|
|
}
|
|
|
|
func (i *integrationTest) checkIncrementalBuildState(cID string, workingDir string, expectClean bool) {
|
|
i.checkBasicBuildState(cID, workingDir)
|
|
if expectClean {
|
|
i.fileNotExists(cID, "/sti-fake/save-artifacts-invoked")
|
|
} else {
|
|
i.fileExists(cID, "/sti-fake/save-artifacts-invoked")
|
|
}
|
|
}
|
|
|
|
func (i *integrationTest) fileExistsInContainer(cID string, filePath string) bool {
|
|
ctx, cancel := getDefaultContext()
|
|
defer cancel()
|
|
rdr, stats, err := engineClient.CopyFromContainer(ctx, cID, filePath)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
defer rdr.Close()
|
|
return "" != stats.Name
|
|
}
|
|
|
|
func (i *integrationTest) checkForLabel(image string) {
|
|
docker := dockerpkg.New(engineClient, (&api.Config{}).PullAuthentication)
|
|
|
|
labelMap, err := docker.GetLabels(image)
|
|
if err != nil {
|
|
i.t.Fatalf("Unable to get labels from image %s: %v", image, err)
|
|
}
|
|
|
|
if labelMap["testLabel"] != "testLabel_value" {
|
|
i.t.Errorf("Unable to verify 'testLabel' for image '%s'", image)
|
|
}
|
|
}
|