Stop clearing S2I_BUILD_TAGS in hack/test-go.sh so that integration
tests will run when it's invoked from hack/test-dockerfile.sh and from
hack/docker.sh.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
`FOO=${FOO:-value}` sets FOO to 'value' if it is null (empty) or unset,
whereas `FOO=${FOO-value}` (without the colon) sets FOO only when FOO is
unset.
Let the go tool pick the default cover mode.
Since -coverprofile implies -cover, we don't need to test S2I_COVER when
OUTPUT_COVERAGE is given.
- enable use of cygwin to build and test s2i
- simplify git and file downloaders
- track posix file permissions on windows
- remove unnecessary runtime.GOOS == "windows" checks
- unit test fixes
