miscellaneous changes associated with s2i windows work

- add missing function documentation
- fix govet shadow warnings
- fix spelling errors
- add .atom-build.yml to .gitignore
- don't mess up bash completions if build fails
- re-enable test-go.sh race checker as documented
- remove extraneous goroutines in tests
- use ExcludeRegExp in integration tests
- remove finished containers in integration tests

hack/verify-bash-completion.sh

@@ -10,12 +10,12 @@ source "${S2I_ROOT}/hack/common.sh"
 cd "${S2I_ROOT}"
 
 mv contrib/bash/s2i contrib/bash/s2i-proposed
+trap "mv contrib/bash/s2i-proposed contrib/bash/s2i" exit
 hack/update-generated-completions.sh
 
 ret=0
 diff -Naupr contrib/bash/s2i contrib/bash/s2i-proposed || ret=$?
 
-mv contrib/bash/s2i-proposed contrib/bash/s2i
 if [[ $ret -eq 0 ]]
 then
   echo "SUCCESS: Generated completions up to date."