openshift/source-to-image
1
0
Fork 0
mirror of https://github.com/openshift/source-to-image.git synced 2026-02-05 12:44:54 +01:00
Code Issues Releases Activity
Files
master
source-to-image/hack/install-tools.sh

14 lines
244 B
Bash
Raw Permalink Normal View History

Added govet
2015-08-25 16:11:55 +02:00
#!/bin/bash
Fix hack/verify-*.sh and improve other scripts Summary: - Add 'make verify' to Travis. - Fix verify-golint.sh: old invocation would not work unless GOPATH is a single directory. - Fix verify-govet.go: 'go vet' does not take flags, should use 'go tool vet'. - Fix early termination of hack/verify-govet.sh. - Enable 'go vet' in 'make verify'; will prevent introducing problems detected by the vet tool in future PRs. - Make sure golint is installed in Travis. - Improve install-tools.sh, parity with the one in openshift/origin. - s/os::util::sed/s2i::util::sed for consistency. - Reimplement/simplify find_files, now called s2i::util::find_files, and use it in all scripts consistently. - Suggest autocorrection for gofmt, as seen in openshift/origin. - Do not check Go version (verify-*.sh should be run no matter the Go version?!). - Do not create directory _output/govet (not used?!). - Explicitly disable check of composite literals. Vet gives false positives on literals using unkeyed fields.
2016-05-15 20:45:19 +02:00
set -o errexit
set -o nounset
set -o pipefail
Added govet
2015-08-25 16:11:55 +02:00
Fix hack/verify-*.sh and improve other scripts Summary: - Add 'make verify' to Travis. - Fix verify-golint.sh: old invocation would not work unless GOPATH is a single directory. - Fix verify-govet.go: 'go vet' does not take flags, should use 'go tool vet'. - Fix early termination of hack/verify-govet.sh. - Enable 'go vet' in 'make verify'; will prevent introducing problems detected by the vet tool in future PRs. - Make sure golint is installed in Travis. - Improve install-tools.sh, parity with the one in openshift/origin. - s/os::util::sed/s2i::util::sed for consistency. - Reimplement/simplify find_files, now called s2i::util::find_files, and use it in all scripts consistently. - Suggest autocorrection for gofmt, as seen in openshift/origin. - Do not check Go version (verify-*.sh should be run no matter the Go version?!). - Do not create directory _output/govet (not used?!). - Explicitly disable check of composite literals. Vet gives false positives on literals using unkeyed fields.
2016-05-15 20:45:19 +02:00
STARTTIME=$(date +%s)
Added govet
2015-08-25 16:11:55 +02:00
Fix hack/verify-*.sh and improve other scripts Summary: - Add 'make verify' to Travis. - Fix verify-golint.sh: old invocation would not work unless GOPATH is a single directory. - Fix verify-govet.go: 'go vet' does not take flags, should use 'go tool vet'. - Fix early termination of hack/verify-govet.sh. - Enable 'go vet' in 'make verify'; will prevent introducing problems detected by the vet tool in future PRs. - Make sure golint is installed in Travis. - Improve install-tools.sh, parity with the one in openshift/origin. - s/os::util::sed/s2i::util::sed for consistency. - Reimplement/simplify find_files, now called s2i::util::find_files, and use it in all scripts consistently. - Suggest autocorrection for gofmt, as seen in openshift/origin. - Do not check Go version (verify-*.sh should be run no matter the Go version?!). - Do not create directory _output/govet (not used?!). - Explicitly disable check of composite literals. Vet gives false positives on literals using unkeyed fields.
2016-05-15 20:45:19 +02:00
echo $(go version)
Added govet
2015-08-25 16:11:55 +02:00
chore(hack): Go Modules based scripts.
2019-10-28 11:01:00 +01:00
GO111MODULE=off go get golang.org/x/lint/golint
Fix hack/verify-*.sh and improve other scripts Summary: - Add 'make verify' to Travis. - Fix verify-golint.sh: old invocation would not work unless GOPATH is a single directory. - Fix verify-govet.go: 'go vet' does not take flags, should use 'go tool vet'. - Fix early termination of hack/verify-govet.sh. - Enable 'go vet' in 'make verify'; will prevent introducing problems detected by the vet tool in future PRs. - Make sure golint is installed in Travis. - Improve install-tools.sh, parity with the one in openshift/origin. - s/os::util::sed/s2i::util::sed for consistency. - Reimplement/simplify find_files, now called s2i::util::find_files, and use it in all scripts consistently. - Suggest autocorrection for gofmt, as seen in openshift/origin. - Do not check Go version (verify-*.sh should be run no matter the Go version?!). - Do not create directory _output/govet (not used?!). - Explicitly disable check of composite literals. Vet gives false positives on literals using unkeyed fields.
2016-05-15 20:45:19 +02:00
ret=$?; ENDTIME=$(date +%s); echo "$0 took $(($ENDTIME - $STARTTIME)) seconds"; exit "$ret"
Copy Permalink