From 4b1782688d0a1a2aa47483e8d3fb48c8d0c64eca Mon Sep 17 00:00:00 2001 From: Bob Gaydos Date: Wed, 2 Feb 2022 17:54:18 -0500 Subject: [PATCH] CNV-13715: Online VM Snapshot improvements --- modules/virt-creating-vm-snapshot-cli.adoc | 6 ++++-- .../virtual_disks/virt-managing-vm-snapshots.adoc | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/modules/virt-creating-vm-snapshot-cli.adoc b/modules/virt-creating-vm-snapshot-cli.adoc index 79511505f0..a70aaa920a 100644 --- a/modules/virt-creating-vm-snapshot-cli.adoc +++ b/modules/virt-creating-vm-snapshot-cli.adoc @@ -64,11 +64,13 @@ $ kubectl wait my-vm my-vmsnapshot --for condition=Ready + [NOTE] ==== -Online snapshots have a default time deadline of five (`5`) minutes. If the snapshot does not complete successfully in five minutes, the status is set to `failed`. Afterwards, the file system will be thawed and the VM unfrozen but the status remains `failed` until you delete the failed snapshot image. +Online snapshots have a default time deadline of five minutes (`5m`). If the snapshot does not complete successfully in five minutes, the status is set to `failed`. Afterwards, the file system will be thawed and the VM unfrozen but the status remains `failed` until you delete the failed snapshot image. -To change the default time deadline, add the `FailureDeadline` attribute to the VM snapshot spec with the time (in minutes) that you want to specify before the snapshot operation times out. +To change the default time deadline, add the `FailureDeadline` attribute to the VM snapshot spec with the time designated in minutes (`m`) or in seconds (`s`) that you want to specify before the snapshot operation times out. To set no deadline, you can specify `0`, though this is generally not recommended, as it can result in an unresponsive VM. + +If you do not specify a unit of time such as `m` or `s`, the default is seconds (`s`). ==== .Verification diff --git a/virt/virtual_machines/virtual_disks/virt-managing-vm-snapshots.adoc b/virt/virtual_machines/virtual_disks/virt-managing-vm-snapshots.adoc index c62585f4d5..be23d00569 100644 --- a/virt/virtual_machines/virtual_disks/virt-managing-vm-snapshots.adoc +++ b/virt/virtual_machines/virtual_disks/virt-managing-vm-snapshots.adoc @@ -11,9 +11,11 @@ You can create and delete virtual machine (VM) snapshots for VMs, whether the VM * Red Hat OpenShift Container Storage * Any other storage provider with the Container Storage Interface (CSI) driver that supports the Kubernetes Volume Snapshot API +Online snapshots have a default time deadline of five minutes (`5m`) that can be changed, if needed. + [IMPORTANT] ==== -Online snapshots are not supported for virtual machines that have hot-plugged virtual disks. +Online snapshots are supported for virtual machines that have hot-plugged virtual disks. However, hot-plugged disks that are not in the virtual machine specification are not included in the snapshot. ==== [NOTE]