From aa7c78e5cd366512a97c2facfc15c700969c91b6 Mon Sep 17 00:00:00 2001
From: Prithviraj Patil <116709298+prithvipatil97@users.noreply.github.com>
Date: Sun, 6 Apr 2025 20:44:54 +0530
Subject: [PATCH] Update logging-loki-pod-placement.adoc

- Need to remove additional nodeSelector and tolerations from Lokistack CR
- Here is the documentation link:
https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/logging/scheduling-resources#logging-loki-pod-placement_logging-taints-tolerations
- nodeSelector and tolerations are mentioned twice under the distributor field of Lokistack CR.
~~~
    distributor:
      nodeSelector:
        node-role.kubernetes.io/infra: ""
      tolerations:
      - effect: NoSchedule
        key: node-role.kubernetes.io/infra
        value: reserved
      - effect: NoExecute
        key: node-role.kubernetes.io/infra
        value: reserved
      nodeSelector:
        node-role.kubernetes.io/infra: ""
      tolerations:
      - effect: NoSchedule
        key: node-role.kubernetes.io/infra
        value: reserved
      - effect: NoExecute
        key: node-role.kubernetes.io/infra
        value: reserved
~~~

- values for both nodeSelector and tolerations are the same.
- Keeping it twice is not required and it is an unnecessary configuration.
- Hence need to remove additional nodeSelector and tolerations from the documentation.

- Here is the updated look:
~~~
    distributor:
      nodeSelector:
        node-role.kubernetes.io/infra: ""
      tolerations:
      - effect: NoSchedule
        key: node-role.kubernetes.io/infra
        value: reserved
      - effect: NoExecute
        key: node-role.kubernetes.io/infra
        value: reserved
~~~
---
 modules/logging-loki-pod-placement.adoc | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/modules/logging-loki-pod-placement.adoc b/modules/logging-loki-pod-placement.adoc
index b8ae9c92e7..161e2caa3d 100644
--- a/modules/logging-loki-pod-placement.adoc
+++ b/modules/logging-loki-pod-placement.adoc
@@ -84,15 +84,6 @@ spec:
       - effect: NoExecute
         key: node-role.kubernetes.io/infra
         value: reserved
-      nodeSelector:
-        node-role.kubernetes.io/infra: ""
-      tolerations:
-      - effect: NoSchedule
-        key: node-role.kubernetes.io/infra
-        value: reserved
-      - effect: NoExecute
-        key: node-role.kubernetes.io/infra
-        value: reserved
     indexGateway:
       nodeSelector:
         node-role.kubernetes.io/infra: ""