mirror of
https://github.com/openshift/installer.git
synced 2026-02-07 03:47:13 +01:00
d9ae9b3f50
8.0.0 is the version that's compatible with Kubernetes 1.11 [1], and we've been using Kubernetes 1.11.3 for apimachinery since2a606ef2(vendor: bump apimachinery to 1.11.3, 2018-10-01, #382). client-go 9.0.0 is nominally compatible with Kubernetes 1.12 [2], and I want this for UntilWithoutRetry [3] which is new in 9.0.0 [4]. I edited Gopkg.toml by hand and regenerated everything else with: $ dep ensure using: $ dep version dep: version : v0.5.0 build date : git hash : 22125cf go version : go1.10.3 go compiler : gc platform : linux/amd64 features : ImportDuringSolve=false I need to bump apimachinery into the 1.12 channel as well to avoid (and now I match client-go's declared dependency [2]): $ dep ensure Solving failure: package k8s.io/apimachinery/pkg/util/naming does not exist within project k8s.io/apimachinery naming is new in 1.12 [5] and we're pulling it with: $ git grep util/naming vendor vendor/k8s.io/apimachinery/pkg/runtime/scheme.go: "k8s.io/apimachinery/pkg/util/naming" vendor/k8s.io/client-go/tools/cache/reflector.go: "k8s.io/apimachinery/pkg/util/naming" $ git grep tools/cache vendor/k8s.io/client-go/tools/watch vendor/k8s.io/client-go/tools/watch/informerwatcher.go: "k8s.io/client-go/tools/cache" vendor/k8s.io/client-go/tools/watch/until.go: "k8s.io/client-go/tools/cache" Then I needed to change client-go to an override to avoid: $ dep ensure Solving failure: package k8s.io/api/autoscaling/v2beta2 does not exist within project k8s.io/api Besides the version bump, dep also pulled in libraries for waiting on Kubernetes events. [1]:7d04d0e2a0[2]:1638f8970c[3]: https://github.com/kubernetes/client-go/blob/v9.0.0/tools/watch/until.go#L47-L58 [4]:cbdb98d74d[5]:3c4948ecf2