mirror of
https://github.com/openshift/installer.git
synced 2026-02-05 06:46:36 +01:00
552b61936e
* pkg/destroy/aws/ec2helpers.go ** the bulk of the changes are to the ec2helpers file. All of the sdk v1 imports are removed except for session as this one is engrained too many files currently. pkg/destroy/aws/aws.go ** Add a client for ELB ELBV2 and IAM to the Cluster Removal Struct. Even though these changes are mainly to ec2helpers, the other clients were required in for certain operations. ** The rest of the file updates are alter ARN import to come from aws sdk v2. * pkg/destroy/aws/iamhelpers.go ** Remove/Change all imports from AWS sdk v1 to v2. pkg/destroy/aws/errors.go pkg/destroy/aws/ec2helpers.go ** Remove the Error checking/formatting function from ec2helpers and put the function in the errors.go file. * pkg/destroy/aws/elbhelpers.go ** Remove all SDK v1 imports from elb helpers. * Add reference to correct HandleErrorCode function. * pkg/destroy/aws/aws.go ** Update Route53, s3, and efs services to sdk v2. This is slowly removing the requirement for aws session. * ** Vendor updates for S3 and EFS services. ** This caused updates to other packages such as aws/config, credentials, stscreds, and a list of aws internal packages. * Clean up references and use the exported config creator to create new clients in destroyer. * ** Migrate the use of resource tagging api to the sdk V2. pkg/destroy/aws: ** Alter the function name from HandleErrorCode to handleErrorCode. The initial thought was that this function could be used in other areas of the code, but it will remain in destroy for now. pkg/destroy/aws/shared.go: ** Remove the session import and uses in the file. * Fix references to HandleErrorCode. * kg/destroy/aws/aws.go: ** Remove session from the imports. Added the agent handler to the configurations. * Fix package updates for vendoring. * Use the correct private and public zone clients. Set a Destroy User Agent. Cleanup pointer references to use the aws sdk. * The ListUsers API call does not return tags for the IAM users in the response. There is a separate call ListUserTags to fetch its tag for checking in the installer code. * rebase: fix other imports after rebase * revert: use GetRole/GetUser to fetch tags An older commit uses ListRoleTags/ListUserTags in order to save bandwidth by fetching only tags. However, the minimal permission required for the installer does not have permission iam:ListUserTags or iam:ListRoleTags, thus causing the deprovisioning to skip users and roles. This is part of the reasons for previous CI leaks. This commit reverts the optimisation idea to just user GetRole/GetUser, which should have sufficient minimal permission policy. --------- Co-authored-by: barbacbd <barbacbd@gmail.com>