49b4da9f5b
ibmcloud: add ibm cloud types support the new ibm cloud platform by adding required types ibmcloud: add initial assets Add ibmcloud assets to support the new ibmcloud platform. These changes are functional, but additional functionality will be built out over time ibmcloud: resolve linting issues ibmcloud: obtain the cisInstanceCRN for install-config The cisInstanceCRN field is derived from the user-provided baseDomain. It is needed for all DNS configuration. types: fix ibmcloud machinepool file name ibmcloud: rename platform ResourceGroupID field Rename the field `ResourceGroupID` in the Platform type to `ResourceGroup` ibmcloud: add initial metadata ibmcloud: add ClusterOSImage customization The ClusterOSImage field will allow the user to specify the custom RHCOS image to use for their cluster VSIs ibmcloud: add fields to Platform type Add the DefaultMachinePlatform, VPC, VPCResourceGroup, and Subnets fields to the Platform type. These are needed to fully define a cluster. ibmcloud: improve platform validation and tests Add in additional validation to the ibmcloud Platform. Also, add unit tests around that new validation. This is just a start and more validation and unit tests are required. ibmcloud: fix linting issues These issues were discovered using golangci-lint ibmcloud: use resource group name in install config Use the resource group name instead of ID in the install config. This will be more human friendly. The ID will also still be valid, but name will be preferred. ibmcloud: improve default resource group check Check for the default resource group based off of the 'default' field in the resource group struct. ibmcloud: fix typo ibmcloud: remove vpcResourceGroup and use vpc ID vpcResourceGroup is no longer needed if the vpc field holds the ID of the VPC instead of the name. ibmcloud: enforce clusterOSImage region The clusterOSImage refers to a custom image in a user's VPC. That image is regionally scoped and the region should be honored. Users should not be allowed to pick a custom image from a region that differes from the value of the region field in the install config. ibmcloud: use resourcev2 API The resourcev2 API should be used in place of v1. This is the most up-to-date and well supported version. ibmcloud: fix log message Co-Authored-By: Hidematsu Sueki <Hidematsu.Sueki@ibm.com> ibmcloud: add machinepool type and validation Add the MachinePool type for the IBM Cloud platform. Also include initial validation on the fields. ibmcloud: update survey version ibmcloud: use ibm go sdks instead of bluemix-go The ibm-go-sdk and corresponding service SDKs in the IBM GH org are more up-to-date and routinely supported. The old bluemix-go SDKs should no longer be used. update go mod update vendor fix: make validateVPCConfig a private function Co-authored-by: Matthew Staebler <staebler@redhat.com> fix: improve log message for resource group not found Co-authored-by: Matthew Staebler <staebler@redhat.com> fix: simplify subnet return statement Co-authored-by: Matthew Staebler <staebler@redhat.com> fix: improve log message for vpc not found Co-authored-by: Matthew Staebler <staebler@redhat.com> fix: images slice declaration Co-authored-by: Matthew Staebler <staebler@redhat.com> fix: improve images range loop Co-authored-by: Matthew Staebler <staebler@redhat.com> fix: typo in baseDomain help string Co-authored-by: Matthew Staebler <staebler@redhat.com> fix: clarify resource group help message fix: use platformPath as variable name Co-authored-by: Matthew Staebler <staebler@redhat.com> fix: ibmcloud platform reference Co-authored-by: Matthew Staebler <staebler@redhat.com> fix: remove unnecessary conditionals in validation fix: check encryptionKey exists before validation fix: improve zone validation message Co-authored-by: Matthew Staebler <staebler@redhat.com> fix: keep errors out of happy path fix: add index to subnets validation fix: create VPCResourceNotFoundError fix: use sets.String for contains fix: ibmcloud platform type comments fix: improve vpc config validation messages fix: add omitempty for encryptionKey Co-authored-by: Matthew Staebler <staebler@redhat.com> fix: improve BootVolume copying Co-authored-by: Matthew Staebler <staebler@redhat.com> fix: rename MachinePool.Type to InstanceType fix: remove validateRegion fix: remove unnecessary context from client fix: remove context timeout in ic Platform fix: remove superfluous edit fix: update unit tests fix: move types used by cilent to same package fix: update OWNERS and OWNERS_ALIASES fix: improve client call to load services fix: improve GetZoneIDByName range loop fix: whitepsace in OWNERS fix: populate ibmcloud OWNERS_ALIASES fix: make cisServiceID a const Co-authored-by: Matthew Staebler <staebler@redhat.com> ibmcloud: refactor resource groups Allow users to have VPC resources in a different resource group from the cluster creation. This will enable CI and E2E testing along with making it easier to destroy clusters. This commit also adds a "Name" suffix to resource groups to align with other platforms naming convention. fix: error message format fix: update unit test ibmcloud: move ibmcloud to hidden platforms The IBMCloud platform will be in a developer preview for 4.9. As a result we will move it to the list of hidden platforms. This commit does that by default, but allows for it to show up in the survey via a build flag: 'ibmcloud'. ibmcloud: remove cisInstanceCRN field The cisInstanceCRN platform field is not needed. Though it is possible to manage a single DNS zone with multiple CIS instances, only one zone can be in the "Active" state at a time. As a result, we know which CIS instance to use based off of its managed zone's state. fix: address pr comments update codegen
3.2 KiB
Contributor Covenant Code of Conduct
Our Pledge
In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
Our Standards
Examples of behavior that contributes to creating a positive environment include:
- Using welcoming and inclusive language
- Being respectful of differing viewpoints and experiences
- Gracefully accepting constructive criticism
- Focusing on what is best for the community
- Showing empathy towards other community members
Examples of unacceptable behavior by participants include:
- The use of sexualized language or imagery and unwelcome sexual attention or advances
- Trolling, insulting/derogatory comments, and personal or political attacks
- Public or private harassment
- Publishing others' private information, such as a physical or electronic address, without explicit permission
- Other conduct which could reasonably be considered inappropriate in a professional setting
Our Responsibilities
Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
Scope
This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
Enforcement
Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at ivan+abuse@flanders.co.nz. All complaints will be reviewed and investigated and will result in a response that is deemed necessary and appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
Attribution
This Code of Conduct is adapted from the Contributor Covenant, version 1.4, available at http://contributor-covenant.org/version/1/4