1
0
mirror of https://github.com/openshift/installer.git synced 2026-02-05 15:47:14 +01:00
Commit Graph

27 Commits

Author SHA1 Message Date
Thuan Vo
36c65d9e47 OCPBUGS-56079: apply fixes for yaml-lint errors
Notes: there are other yaml-lint warnings but they've been there for a
long time. This commit only focuses on the errors introduced during 4.19
cycle.
2025-05-12 18:44:52 -07:00
dkokkino
6317f88e89 Edit manifest test
- lb-default-stable: As a default load balancer is now being assigned when one is not provided this test needs to be updated to reflect that change
- lb-unmanaged: I made changes to how the defaults are set. If the load
  balancer is user-managed VIPs will not automatically be assigned
  anymore. This change needs to be reflected in this test by adding a
  apiVIPs and ingressVIPs value to the install-config
2025-03-31 11:41:38 +02:00
Thuan Vo
3628a43a38 CORS-3637: OWNERS files for platform provider subdirectories
The files use aliases defined in OWNERS_ALIASES
2025-01-27 10:37:24 -08:00
Maysa Macedo
f6a9ce358f Fix FailureDomains check on manifests test
The `FailureDomains` was updated to become a pointer, consequently
the field may be absent in the `OpenShiftMachineV1Beta1MachineTemplate`.
This commits updates the manifests test to take that into account.
2023-11-13 14:36:58 +01:00
Pierre Prinetti
ed2a27dc7d openstack: Test zero replicas in worker machine-pool
Assert that:
* setting zero workers does not crash the Installer
* there always is at least one MachineSet
2023-08-07 14:09:18 +02:00
OpenShift Merge Robot
a3fa7e0a6e Merge pull request #7367 from shiftstack/configure-ipv6
Bug OCPBUGS-16249: Add ip=dhcp,dhcp6 option to Kernel args
2023-08-02 04:26:04 +02:00
Maysa Macedo
641857ff2d Add ip=dhcp,dhcp6 option to Kernel args
On clusters configured with dual-stack network the
IPv4 and IPv6 addresses can be added to the main interface
at different time, which results in the openshift node addresses
not containing the IPv6 address. This commit fixes the issue
by including `ip=dhcp,dhcp6` to the kernel args of masters and works,
which sets `required-timeout` to an value that the IP configuration
will be tried before succeeds. This configuration is valid for day1
dual-stack clusters only.
2023-07-31 16:27:19 -03:00
Martin André
95dfb07010 OpenStack: Add manifest convert tests 2023-07-27 10:27:59 -04:00
Emilien Macchi
a1ea1c870e openstack: Variable Root volume types
Co-Authored-By: Emilien Macchi <emilien@redhat.com>
Co-Authored-By: Pierre Prinetti <pierreprinetti@redhat.com>
2023-07-18 10:40:25 -04:00
Pierre Prinetti
482a2fef7d OSASINFRA-3155 - OpenStack: Create ControlPlaneMachineSet CRDs
Co-Authored-By: Pierre Prinetti <pierreprinetti@redhat.com>
Co-Authored-By: Emilien Macchi <emilien@redhat.com>
2023-07-06 16:41:51 +02:00
Emilien Macchi
97e3019c03 openstack: remove portTargets
We introduced a TechPreview of OpenStack network failure domains in 4.13
that is now incompatible with the new control-plane-machine-set.

With this change, we remove the experimental implementation of network
failure domains to prepare for the control-plane-machine-set
implementation.

Co-Authored-By: Emilien Macchi <emilien@redhat.com>
Co-Authored-By: Pierre Prinetti <pierreprinetti@redhat.com>
2023-06-14 16:21:51 +02:00
OpenShift Merge Robot
d010f530dd Merge pull request #7127 from shiftstack/osp_lb
OSASINFRA-3153: move `loadBalancer` API to GA for OpenStack
2023-05-31 18:41:39 -04:00
Emilien Macchi
d6496349a6 openstack/manifest-tests/ServerGroup: add AZ to ctlplane 2023-05-10 09:55:36 -04:00
Emilien Macchi
0321c41943 OSASINFRA-3153: move loadBalancer API to GA for OpenStack
This API has not moved and there is no plan to make any change that
would be backward incompatible in the future.

The feature was well tested (and automated) by our QE on this platform,
as well documented on OCP 4.13.

We think this API is ready to be GA'ed.
2023-04-25 09:44:34 -04:00
Pierre Prinetti
668586fb24 openstack: No master primarySubnet control-plane portTarget is set
When a "control-plane" portTarget is set, masters should not have the
machinesSubnet in the "primarySubnet" field of their Machine
ProviderSpec.
2023-03-20 17:51:34 +01:00
Pierre Prinetti
8801811574 openstack-manifests: Export JUnit results
Expose test results as JUnit to let Prow parse them.
2023-03-14 11:11:16 +01:00
Pierre Prinetti
34b53ca9d3 openstack-manifests: Refactor 2023-03-12 17:39:56 +01:00
Pierre Prinetti
4c5b601e1f OpenStack: Add Failure domains
Distribute Control plane machines across user-defined failure domains.

This feature is being release under a TechPreviewNoUpgrade FeatureSet.

Failure domains can be defined in the `controlPlane` machine-pool of
`install-config.yaml` as follows:

```yaml
controlPlane:
  name: master
  platform:
    openstack:
      type: ${CONTROL_PLANE_FLAVOR}
      failureDomains:
      - computeAvailabilityZone: 'nova-1'
        storageAvailabilityZone: 'cinder-1'
        portTargets:
        - id: storage
          network:
            id: 8db6a48e-375b-4caa-b20b-5b9a7218bfe6
      - computeAvailabilityZone: 'nova-2'
        storageAvailabilityZone: 'cinder-2'
        portTargets:
        - id: storage
          network:
            id: 39a7b82a-a8a4-45a4-ba5a-288569a6edd1
      - computeAvailabilityZone: 'nova-3'
        storageAvailabilityZone: 'cinder-3'
        portTargets:
        - id: storage
          network:
            id: 8e4b4e0d-3865-4a9b-a769-559270271242
```

Each `failureDomains` entry can take an optional
`computeAvailabilityZone` string, an optional `storageAvailabilityZone`
string, and an optional `portTargets` array.

Each `portTargets` entry requires an arbirtary `id`, which must be unique per
`failureDomain`. If `id` is exactly `control-plane`, then that
`portTarget` is used instead of the default primary subnet (or instead
of `machinesSubnet` if defined) as the first machine network.

Each `portTargets` entry takes an optional `network` object and an
optional `fixedIPs` array (not represented in the example).

The `network` object taks an optional `name` string and an optional `id`
string. `name` is ignored if `id` is passed.

Each `fixedIPs` entry takes a `subnet` object which syntax is [defined
in the `machinev1alpha1` spec as
`SubnetFilter`](d170fcdc0f/machine/v1alpha1/types_openstack.go (L230-L281)).

Note that unless an external load balancer is used, `portTargets` with
id `control-plane` must all have one single subnet and must all refer to
the same OpenStack subnet. As a consequence, the result will be similar
as setting a `machinesSubnet`, except that Compute nodes will not
follow.
2023-03-04 08:03:20 +01:00
Emilien Macchi
625932f5c3 Support for External LB as Tech Preview 2023-02-21 09:29:03 -05:00
Jamo Luhrsen
74486c10c6 Change defaultNetworkType to ovn-kubernetes
In 4.12, the default CNI will be OVNKubernetes.
This change will deploy ovnk by default as well
as adjust tests, docs and comments to reflect
the same.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
2022-07-28 22:26:08 -07:00
rna-afk
968705f212 openstack: Fix install config for openstack manifests
The openstack manifests tests use an install config with the
clusterID field that is no longer supported by the installer.
Changes to the installer to enforce strict unmarshalling of the
install config is in place but is being hindered by the openstack
manifests tests in this PR.

https://github.com/openshift/installer/pull/5307
2021-11-03 09:08:42 -04:00
Pierre Prinetti
f6dbeccc70 openstack: Expose worker server group policy
With this change, Compute nodes within each MachineSet are automatically
created in a Server group, with a default policy of
"soft-anti-affinity".

With this change, a "serverGroupPolicy" can be set in install-config, on
the worker MachinePool and/or in the platform default.

Implements OSASINFRA-2570

Co-Authored-By: Matthew Booth <mbooth@redhat.com>
2021-10-04 18:05:15 +02:00
Mike Fedosin
54a61b26b4 OpenStack: Add manifest tests for root volume AZs
This commit adds specific manifests tests to check Machines and
MachineSets manifests generating when Root Volume availability
zones are set.
2021-04-08 13:58:25 +02:00
Pierre Prinetti
ea8318b1f3 openstack manifest tests: Increase verbosity 2020-12-10 18:09:28 +01:00
Pierre Prinetti
73f033dbbc openstack: Test AZ Machines generation 2020-12-10 18:08:32 +01:00
Pierre Prinetti
feebe4c70c openstack: Test Nova AZ manifest generation
* instrument the manifest-generation test-framework to execute Python
testfiles
* test machinesets with availability zones
2020-12-07 14:32:58 +01:00
Pierre Prinetti
b85276295a openstack: Test manifest creation
Add a script for testing OpenStack manifest generation.

Co-Authored-By: Matthew Booth <mbooth@redhat.com>
2020-12-02 11:23:33 +01:00