1
0
mirror of https://github.com/openshift/installer.git synced 2026-02-05 15:47:14 +01:00
Commit Graph

4 Commits

Author SHA1 Message Date
W. Trevor King
7af2ce659d scripts/maintenance: Dependency checks for tag-aws.sh and clean-aws.sh
Following the pattern set by tag-route53-hosted-zones.sh.  I'm also
following tag-route53-hosted-zones.sh in not testing for any POSIX
commands we use, although it would be easy to add tests for them as
well if we wanted.
2018-07-08 15:04:49 -07:00
W. Trevor King
2aea052782 scripts/maintenance/tag-route53-hosted-zones: Error messages for missing deps
At least on Bash 4.4, the -V form writes a missing-command message to
stderr:

  $ echo $BASH_VERSION
  4.4.23(1)-release
  $ command -v does-not-exist >/dev/null
  $ command -V does-not-exist >/dev/null
  -bash: command: does-not-exist: not found

Because we're not redirecting command's stderr in the script, it will
fall through to the caller's stderr and make it easier for them to
figure out what went wrong.

Also write a "Missing required dependencies" string to stderr.  We'd
had a "Dependencies not installed." string literal from 82bdd9fe
(installer/scripts: AWS tag and delete scripts, 2017-06-28,
coreos/tectonic-installer#1239), but it hadn't been written anywhere
so it was effectively an internal comment.
2018-07-08 15:04:49 -07:00
W. Trevor King
da45d540dc scripts/maintenance: Fix $2 -> $1 for unrecognized options
The typos are from 82bdd9fe (installer/scripts: AWS tag and delete
scripts, 2017-06-28, coreos/tectonic-installer#1239).

While I'm touching these lines, also send their output to stderr
instead of stdout (because we're reporting an error).

Also exit nonzero in these unrecognized-option cases.
2018-07-08 15:04:34 -07:00
Andy Pickering
7296010bed frontend: Remove frontend code and backend API code 2018-03-16 12:33:38 +01:00