1
0
mirror of https://github.com/openshift/installer.git synced 2026-02-05 15:47:14 +01:00
Commit Graph

10 Commits

Author SHA1 Message Date
Vince Prignano
d33bede015 hack/shellcheck: update for cluster-api folder
Signed-off-by: Vince Prignano <vincepri@redhat.com>
2023-10-23 11:29:31 -07:00
John Hixson
9c77d6a437 terraform: allow for building local providers individually
This will build local terraform providers individually. The local terraform
providers are the providers that either (1) are not published in a public
regisrty or (2) require patches.

azureprivatedns: private to the installer repo
azurestack: requires patches
ibm: arm build is not published
ignition: arm buid is not published
ironic: not published
ovirt: not published
vsphere: requires patches
vsphereprivate: private to the installer repo

Building these has been added hack/build.sh. In the future a better way of
handling the vendoring in the individual directories will be necessary.

co-authored: staebler
2022-02-21 10:30:46 -05:00
Joseph Callen
16bd4f9e88 Add terraform vendor path to shellcheck
Causing test failures
2020-01-10 16:33:46 -05:00
Alejandro Rosero
b4a3f9678b BDD Suite: Add scripts and documentation 2019-02-04 12:48:46 -05:00
W. Trevor King
ef594e5016 hack/shellcheck: Set --workdir and ignore tests/smoke vendor
Setting --workdir and passing ${@} through means:

  $ ./hack/shellcheck.sh

will show any errors with relative paths that will still work outside
the container.  For example:

  ./tests/smoke/.build/external/go_sdk/src/syscall/mkall.sh:278:7: note: Expressions don't expand in single quotes, use double quotes for that. [SC2016]

instead of:

  /workdir/tests/smoke/.build/external/go_sdk/src/syscall/mkall.sh:278:7: note: Expressions don't expand in single quotes, use double quotes for that. [SC2016]

Adding prune rules for vendor and .build under tests/smoke avoids
complaining about that file and others over which are maintained
upstream or elsewhere.
2018-09-13 10:47:40 -07:00
Steve Milner
c234fc3f95 *: use podman instead of docker
Signed-off-by: Steve Milner <smilner@redhat.com>
2018-09-11 15:19:08 -07:00
W. Trevor King
01339127e8 hack: Add :z to --volume mounts
Like we did in bootkube.sh in 0fa4eb13 (Fix perm errors with selinux
enabled, 2018-08-15, #134).  This gives us permission to access the
mounted volume when SELinux is enabled (docs in [1]).

I've also normalized these invocations for consistency between the
various hack/ scripts:

* Adding slash separators to put each option on its own line,
  excepting the final command being run in the container.  This makes
  the long commands slightly easier to skim.  It will also make it
  easier to track down motivation for an option with 'git blame',
  because commits touching options on other lines won't clutter the
  blame.

* Use long-form options (-v -> --volume, etc.).  This makes the
  options a bit more accessible to newcomers, and now that each option
  is on it's own line we have plenty of space.

* Dropped single quotes from 'TRUE'.  There are no shell-sensitive
  characters in TRUE, so there's no need to quote it.

* Use ${PWD} consistently.  It's in POSIX [2], so there's no need to
  execute a pwd process to get this value.

* Drop -t.  None of these commands should need a pseudoterminal.

* Drop explicit rw --volume options.  They're the default [3].

[1]: https://github.com/containers/libpod/blame/v0.8.3/docs/podman-run.1.md#L628
[2]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03
[3]: https://github.com/containers/libpod/blame/v0.8.3/docs/podman-run.1.md#L646
2018-08-27 20:49:25 -07:00
staebler
f6a54f3bf5 Ignore the vendor and .build directories when running shellcheck. 2018-08-15 14:59:09 -04:00
Alejandro Rosero V
0b6ab7dc52 Prow: Add shellcheck. Update shellcheck to work in Traivs CI 2018-08-02 17:31:03 -05:00
Alejandro Rosero V
fcaf88317c Prow: Add shellcheck to openshift/installer 2018-08-02 15:29:12 -05:00