This is to address the "NoSuchBucket: The specified bucket does not exist"
error as explained in https://bugzilla.redhat.com/show_bug.cgi?id=1759617 and
many other similar bugs. This bug has been "fixed" several times over the
years, yet it continues to rear its ugly self. The ultimate problem is a race
condition with S3 eventual consistency. As described in the bug above, the
bucket does not yet exist when trying to reference tags. The openshift fork
that this commit references, contains an upstream patch as described in
https://github.com/terraform-providers/terraform-provider-aws/pull/13009 that
should address this issue.
Pulling in stretchr/testify@199de5f3a4 (Update the LICENSE to match
the 'standard' MIT license file, 2018-08-16, stretchr/testify#648) to
drop the "Please consider promoting this project..." deviation from
the stock MIT license.
Generated with:
$ dep ensure -update github.com/stretchr/testify
using:
$ dep version
dep:
version : v0.5.1
build date : 2019-03-20
git hash : faa61893
go version : go1.10.3
go compiler : gc
platform : linux/amd64
features : ImportDuringSolve=false
Generated with:
$ glide get --test --strip-vendor github.com/stretchr/testify/assert
[INFO]Preparing to install 1 package.
[INFO]Attempting to get package github.com/stretchr/testify/assert
[INFO]--> Gathering release information for github.com/stretchr/testify
[INFO]The package github.com/stretchr/testify appears to have Semantic Version releases (http://semver.org).
[INFO]The latest release is v1.2.2. You are currently not using a release. Would you like
[INFO]to use this release? Yes (Y) or No (N)
y
[INFO]The package github.com/stretchr/testify appears to use semantic versions (http://semver.org).
[INFO]Would you like to track the latest minor or patch releases (major.minor.patch)?
[INFO]The choices are:
[INFO] - Tracking minor version releases would use '>= 1.2.2, < 2.0.0' ('^1.2.2')
[INFO] - Tracking patch version releases would use '>= 1.2.2, < 1.3.0' ('~1.2.2')
[INFO] - Skip using ranges
[INFO]For more information on Glide versions and ranges see https://glide.sh/docs/versions
[INFO]Minor (M), Patch (P), or Skip Ranges (S)?
m
[INFO]--> Adding github.com/stretchr/testify to your configuration with the version ^1.2.2
...
$ rm -rf glide.lock vendor
$ glide install --strip-vendor
$ glide-vc --use-lock-file --no-tests --only-code
$ bazel run //:gazelle
using:
$ glide --version
glide version v0.13.1
$ (cd $GOPATH/src/github.com/sgotti/glide-vc && git describe)
v0.1.0-2-g6ddf6ee
$ bazel version
Build label: 0.16.1- (@non-git)
Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Mon Aug 13 16:42:29 2018 (1534178549)
Build timestamp: 1534178549
Build timestamp as int: 1534178549
The changes look reasonable, with the possible exception of client-go:
$ cd $GOPATH/src/k8s.io/client-go
$ git describe 78700dec6369ba22221b72770783300f143df150
v6.0.0
$ git describe 7d04d0e2a0a1a4d4a1cd6baa432a2301492e4e65
v8.0.0
The v6 hash came into this repo with da6286fb (vendor: Update vendor
for installconfig generation, 2018-08-23, #160), so I'm not clear on
why it was pulling in the 2017-12-06 v6 instead of the 2018-06-28 v8.
I guess CI will let us know if anything breaks ;).
