Remove the interactive disconnected workflow type. The appliance
embeds registries.conf and CA certificates directly in the system ignition
for bootstrap, eliminating the need for a separate workflow type.
Key changes:
Command-line interface:
- Remove --interactive flag from unconfigured-ignition command
- Remove ContextWrapper and workflow context management
Workflow handling:
- Simplify to always use AgentWorkflowTypeInstall for unconfigured ignition
- Remove AgentWorkflowTypeInstallInteractiveDisconnected constant
- Remove workflow type switching logic in UnconfiguredIgnition
- Remove workflow dependency from UnconfiguredIgnition asset
Mirror configuration:
- Remove RegistriesConf and CaBundle dependencies from UnconfiguredIgnition
- Remove addMirrorData() call (appliance provides this)
- Remove early returns for interactive workflow in mirror assets
Testing:
- Remove interactive-disconnected-workflow test case
- Remove with-mirror-configs test case from unconfigured ignition tests
- Update default dependencies in test helpers
Rationale:
The OVE appliance provides a more robust solution for disconnected
installations by embedding all necessary configuration (registries,
certificates, UI) directly in the appliance image. This approach:
- Eliminates workflow type complexity
- Decouples installer and appliance repositories
- Simplifies the codebase by removing conditional logic
- Aligns with the architecture where MCO manages post-bootstrap config
After first node reboot, the Machine Config Operator manages registry
configuration and trust bundles via IDMS/IDMT resources.
Commit message text generated by: Claude AI <noreply@anthropic.com>
The agent-interactive-console and agent-interactive-console-serial@
services should have consistent Before/After edges. Previously,
agent-auth-token-status.service had agent-interactive-console.service
in its After= directive, but there was no corresponding dependency for
the serial console variant.
This adds agent-auth-token-status.service to the Before= directive in
both console services, and removes the now-redundant After= directive
from agent-auth-token-status.service, so both services define the
dependency consistently in the same direction.
Assisted-by: Claude Code
The agent-interactive-console and agent-interactive-console-serial@
services should have consistent Before/After edges since only one runs
on each system (depending on whether there is a graphical console).
Previously, set-hostname.service had a Before= dependency on
agent-interactive-console.service only, which created an edge in the
systemd diagrams from set-hostname to agent-interactive-console but not
to agent-interactive-console-serial@.
This fixes the inconsistency by:
- Adding set-hostname.service to the After= directive in both console
services
- Removing the redundant Before= directive from set-hostname.service
Both services now define the dependency consistently in the same
direction.
Assisted-by: Claude Code
Instead of just starting the UI container and leaving conmon to manage
it (e.g. by restarting on failure), continue to manage it with systemd
as we do for all other podman containers.
Replace manually-maintained GraphViz DOT files with an auto-generation
system that parses systemd unit files and generates diagrams showing
service dependencies and workflow structure.
Key features:
- Parses systemd units from data/data/agent/systemd/units
- Extracts Before/After dependencies for edges
- Infers cluster membership from PartOf/BindsTo relationships
- Filters services by workflow based on discriminator files
- Shows file creation during workflows (node-zero creates node0, etc)
- Auto-detects disconnected services and marks with thin borders
- Auto-computes workflow differences (add-nodes vs install)
- Maintains consistent layout with invisible edge chains
Only a small number of exceptions are hardcoded:
- load-config-iso@ triggered by udev (unconfigured_ignition only)
- 99-agent-copy-files.sh excluded from interactive (agent-extract-tui provides tui)
- agent-interactive-console services disabled in unconfigured-ignition
Assisted-by: Claude Code
Convert the agent installer service workflow diagrams from PNG to
maintainable GraphViz DOT format. This allows the diagrams to be
edited as text files rather than requiring image editing tools.
Changes:
- Add GraphViz DOT source files for all four workflows
- Add Makefile to generate PNGs from DOT sources
- Add README with build and editing instructions
- Regenerate all PNG files from DOT sources
The new workflow enables easier maintenance and collaboration:
cd docs/user/agent/diagrams
edit *.dot files
make
Assisted-by: Claude Code
Created agent-extract-tui.service for the interactive-disconnected
workflow to extract the agent-tui and nmstate libraries during boot.
The files are extracted from the agent-install-utils image. In the
interactive-disconnected workflow, the image is available on the
local container storage. They need to be extracted before the
agent-interactive-console.service starts.
Addition of doc changes for minimal ISO support. Since the minimal ISO
for all platforms is very similiar to the External platform, combine the
documentation into one file.
The containerized monitor-add-nodes does not have the correct
permissions to write to the current working directory. Set the
working directory to /tmp in the container command.
Derived from a similar script by Andrea Fasano
to generate the add-nodes ISO.
https://github.com/openshift/installer/pull/8242
This script tweaks it and creates a node-joiner-monitor
pod to monitor adding nodes to a cluster.
Co-authored-by: Andrea Fasano <andfasano@redhat.com>
