1
0
mirror of https://github.com/openshift/installer.git synced 2026-02-07 03:47:13 +01:00

21 Commits

Author SHA1 Message Date
Patrick Dillon
cc99514053 unit tests: fix breakage caused by client-go & apimachinery bump
Changes in the apimachinery and client-go packages broke our unit
tests after upgrade. client-go stopped serializing the empty
preferences: {} field for the kubeconfig. apimachinery, with
c58e197ee8
caused much more extensive breakage by changing the format with
which errors are returned, and our unit tests hard code the
expected error messages.

For the most part, I used claude to fix these issues, and here
is the summary it created:

Changes Made
Root Cause: The k8s apimachinery package (errors.go:93-96) now uses json.Marshal()
to format BadValue in error messages instead of Go's native format. Error Format Changes:

Arrays: []string{"a", "b"} → ["a","b"] (JSON format, no spaces)
Nil values: []string(nil) → null
Structs: aws.Subnet{ID:"x", Roles:...} → {"id":"x"} (JSON with lowercase keys)
Custom types: gcp.OSImage{Name:"x", Project:"y"} → {"name":"x","project":"y"}
2025-11-07 09:03:40 -05:00
ehila
75fa733182 feat: add arbiter role support to ABI
added support for arbiter installs to ABI flow, we currently do not
support installing TechPreview featureSet with agent based install, this
includes adding that capability for overriding featureSet to be passed
to the assisted service.

Signed-off-by: ehila <ehila@redhat.com>
2025-07-01 07:36:15 -04:00
Richard Su
34cfb89cc8 OCPBUGS-45317: node-joiner PXE artifacts should be prefixed "node"
instead of "agent".

The "agent" prefix is used for the day 1 agent ISO.

The "node" prefix is used for day-2 artifacts, both ISO and PXE.
2024-12-05 10:15:43 -05:00
Pawan Pinjarkar
e2e19d28c5 Rename var to a common name AUTH_TOKEN_EXPIRY. All the 3 tokens expire at the same time. 2024-11-12 22:16:03 -05:00
Andrea Fasano
b57423a420 fix it name 2024-11-07 10:06:21 -05:00
Andrea Fasano
79a800dd1c report integration test 2024-11-07 10:04:03 -05:00
Richard Su
6ac97b3a8e Integration test for node-joiner add-nodes --pxe 2024-11-06 14:46:34 -05:00
openshift-merge-bot[bot]
90521f8649 Merge pull request #9108 from andfasano/day2-use-additional-ntp-sources
OCPBUGS-42544: support additionalNTPSources in node-joiner tool
2024-11-04 13:53:43 +00:00
Andrea Fasano
674c36d84c store the chrony.conf in the iso for add-nodes worklow
So that the live enviroment will have the same chrony configuration retrieved from the cluster
2024-10-30 14:08:27 -04:00
Andrea Fasano
3e81c86779 add integration tests for verifying the correct creation of the import-cluster-config.json file 2024-10-24 11:06:57 -04:00
Andrea Fasano
082c6cc018 minor code refactoring, tests improvement 2024-10-15 12:40:25 -04:00
Andrea Fasano
ae10c5f050 remove unused code related to kube-system/cluster-config-v1 resource 2024-10-15 12:40:25 -04:00
Andrea Fasano
b13476b07b retrieve FIPS from 99-worker-fips machineconfig resource 2024-10-15 12:40:25 -04:00
Andrea Fasano
b74d38b5cd retrieve SSH key from 99-worker-ssh machineconfig resource 2024-10-15 12:40:25 -04:00
Andrea Fasano
498db3b3ff retrieve APIDNSName from cluster infrastructure resource 2024-10-15 12:40:24 -04:00
Andrea Fasano
087994b047 retrieve imageDigestMirrorSets (and imageContentPolicies) from cluster resources 2024-10-15 12:40:24 -04:00
Andrea Fasano
dd03b5fac5 added envtest binaries dest dir 2024-09-30 09:50:43 -04:00
Andrea Fasano
b41600d8e6 added another test. minor internal refactoring 2024-09-30 09:48:14 -04:00
Andrea Fasano
3f38125bea additional lint/shellcheck fixes 2024-09-30 09:48:14 -04:00
Andrea Fasano
07b364d00f force envtest and fake registry to use the testscript tmp folder.
Also, no need to strictly serialize the tests execution
2024-09-30 09:48:13 -04:00
Andrea Fasano
2ff7ccc89c add integration test (plus required test infrastructure) for node-joiner 2024-09-30 09:48:13 -04:00