This reverts commit c1aa02274f, #618.
We've made a lot of progress separating out the per-platform
components since that went in, so take another run at formally
separating approval for per-platform and core changes.
As the work progresses and the familiarity with the code base grows, it
would be ideal for the OpenStack team to join the reviewers team and
help with specific and more focused reviews.
Specifically, the team is interested in reviewing OpenStack related
patches (like #511) in order to ease the workload from the rest of the
team.
The OpenStack team won't be reviewing patches outside their area of
competence.
This will make it easier to add special-case OWNERS files to
openshift/release while still getting the members slurped up with the
populate-owners tooling. That tooling pulls OWNERS_ALIASES since
openshift/release@e1f993fb (populate-owners: Also slurp
OWNERS_ALIASES, 2018-08-25, openshift/release#1285).
Most of the folks I've listed here are under Aaron in Red Hat, with
Yifan being the installer lead. I've also included Alex and Clayton,
who are higher up in Red Hat but still members of
@openshift/installer. I'm guessing about roles, but we can always
adjust later as we see fit.
Approvers can also /lgtm [1], so there's no need to list them under
'reviewers' as well.
The docs link in OWNERS is from [2].
While updating CONTRIBUTING.md to mention OWNERS (using wording based
on [3]), I've also:
* Added a line to make it clear that filing issues is helpful to (for
folks who don't have the time or inclination to work up a PR).
* Turned the unordered list into an ordered list. These entries
happen sequentially, and an ordered list makes that more obvious.
* Made "below" a link, to make finding the referenced content more
convenient.
* Shuffled words in the commit message format title to make it
shorter.
The references to 'make structure-check' are stale since d61abd48 (*:
cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137), but
I've left fixing that to follow-up work.
[1]: 4c0c2e9e65/contributors/guide/owners.md (quirks-of-the-process)
[2]: https://github.com/kubernetes/kubernetes-template-project/pull/15
[3]: 16f1588e6d/CONTRIBUTING.md (L10)
