openshift/installer
1
0
Fork 0
mirror of https://github.com/openshift/installer.git synced 2026-02-05 06:46:36 +01:00
Code Issues Releases Activity

pkg/destroy/libvirt: Add behind a libvirt_destroy build tag

Browse Source 
Docs for Go's build constraints are in [1].  This commit allows folks
with local libvirt C libraries to compile our libvirt deletion logic
(and get a dynamically-linked executable), while release binaries and
folks without libvirt C libraries can continue to get
statically-linked executables that lack libvirt deletion.

I've also simplified the public names (e.g. NewDestroyer -> New),
dropping information which is already encoded in the import path.

Pulling the init() registration out into separate files is at
Abhinav's request [2].

[1]: https://golang.org/pkg/go/build/#hdr-Build_Constraints
[2]: https://github.com/openshift/installer/pull/387#discussion_r221763315
This commit is contained in:
W. Trevor King
2018-10-01 13:56:45 -07:00
parent a10bfdd2b7
commit 4d940ceea6
10 changed files with 125 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
docs/dev/dependencies.md
View File

@@ -10,12 +10,16 @@ The following dependencies must be installed on your system before you can build
sudo dnf install golang-bin gcc-c++
```
If you need support for [libvirt destroy](libvirt-howto#cleanup), you should also install `libvirt-devel`.
### CentOS, RHEL
```sh
sudo yum install golang-bin gcc-c++
```
If you need support for [libvirt destroy](libvirt-howto#cleanup), you should also install `libvirt-devel`.
## Go
We follow a hard flattening approach; i.e. direct and inherited dependencies are installed in the base `vendor/`.