From 1489bf55572efe90a45a3169474f2df9b1a09863 Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Wed, 1 Aug 2018 09:47:44 -0700 Subject: [PATCH] *: Drop the Tectonic license Red Hat no longer requires a Tectonic license now that this installer is being used to launch OpenShift clusters. --- .gitignore | 1 - Documentation/design/installconfig.md | 3 - Documentation/design/resource_dep.dot | 2 - Documentation/dev/libvirt-howto.md | 5 +- Jenkinsfile | 1 - config.tf | 12 --- examples/tectonic.aws.yaml | 6 -- examples/tectonic.libvirt.yaml | 6 -- .../config-generator/fixtures/test-aws.yaml | 1 - installer/pkg/config/cluster.go | 1 - installer/pkg/config/validate.go | 3 - installer/pkg/validate/validate.go | 22 ----- installer/pkg/validate/validate_test.go | 83 ------------------- .../pkg/workflow/fixtures/aws.basic.yaml | 1 - installer/pkg/workflow/init_test.go | 59 +++---------- modules/tectonic/manifests.tf | 2 - .../resources/manifests/secrets/license.json | 11 --- modules/tectonic/resources/tectonic.sh | 1 - modules/tectonic/variables.tf | 6 -- pkg/asset/installconfig/installconfig.go | 3 - pkg/asset/installconfig/installconfig_test.go | 7 -- pkg/asset/installconfig/stock.go | 12 --- pkg/types/installconfig.go | 3 - steps/assets/aws/main.tf | 1 - steps/assets/base/tectonic.tf | 1 - steps/assets/libvirt/main.tf | 1 - tests/README.md | 1 - tests/run.sh | 7 +- 28 files changed, 14 insertions(+), 248 deletions(-) delete mode 100644 modules/tectonic/resources/manifests/secrets/license.json diff --git a/.gitignore b/.gitignore index 0c3da4ce7e..d719d0491d 100644 --- a/.gitignore +++ b/.gitignore @@ -9,7 +9,6 @@ id_rsa* pull-secret.json ssh-key.pem tectonic-*.tar.gz -tectonic-license.txt config.yaml bin/ diff --git a/Documentation/design/installconfig.md b/Documentation/design/installconfig.md index f069a8b3d6..313b31a97b 100644 --- a/Documentation/design/installconfig.md +++ b/Documentation/design/installconfig.md @@ -53,9 +53,6 @@ type InstallConfig struct { // perform the installation. Platform `json:"platform"` - // License is an OpenShift license needed to install a cluster. - License string `json:"license"` - // PullSecret is the secret to use when pulling images. PullSecret string `json:"pullSecret"` } diff --git a/Documentation/design/resource_dep.dot b/Documentation/design/resource_dep.dot index b4a50f7c3d..9dbbb9916d 100644 --- a/Documentation/design/resource_dep.dot +++ b/Documentation/design/resource_dep.dot @@ -18,7 +18,6 @@ strict digraph resource { node [shape=rectangle,style=filled,color=gainsboro]; base_domain [label="base domain"]; cluster_name [label="cluster name"]; - license [label="license"]; pull_secret [label="pull secret"]; platform [label="platform"]; email_address [label="email address"]; @@ -93,7 +92,6 @@ strict digraph resource { platform -> install_config; email_address -> install_config; pull_secret -> install_config; - license -> install_config; cluster_name -> install_config; base_domain -> install_config; diff --git a/Documentation/dev/libvirt-howto.md b/Documentation/dev/libvirt-howto.md index f4e0166619..946450562e 100644 --- a/Documentation/dev/libvirt-howto.md +++ b/Documentation/dev/libvirt-howto.md @@ -40,8 +40,8 @@ Because of the greater disk requirements of OpenShift, you'll need to expand the qemu-img resize coreos_production_qemu_image.img +8G ``` -#### 1.4 Get a Tectonic License -Go to https://account.coreos.com/ and obtain a Tectonic license. Save the *pull secret* and *license path* somewhere. +#### 1.4 Get a pull secret +Go to https://account.coreos.com/ and obtain a Tectonic *pull secret*. #### 1.5 Make sure you have permisions for `qemu:///system` You may want to grant yourself permissions to use libvirt as a non-root user. You could allow all users in the wheel group by doing the following: @@ -62,7 +62,6 @@ EOF 1. Set a `baseDomain` (to `tt.testing`) 1. Set the `sshKey` in the `admin` section to the **contents** of an ssh key (e.g. `ssh-rsa AAAA...`) 1. Set the `imagePath` to the **absolute** path of the operating system image you downloaded - 1. Set the `licensePath` to the **absolute** path of your downloaded license file. 1. Set the `name` (e.g. test1) 1. Look at the `podCIDR` and `serviceCIDR` fields in the `networking` section. Make sure they don't conflict with anything important. 1. Set the `pullSecretPath` to the **absolute** path of your downloaded pull secret file. diff --git a/Jenkinsfile b/Jenkinsfile index 37f86824ee..1f2c41c26f 100755 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -1,7 +1,6 @@ #!/usr/bin/env groovy commonCreds = [ - file(credentialsId: 'tectonic-license', variable: 'LICENSE_PATH'), file(credentialsId: 'tectonic-pull', variable: 'PULL_SECRET_PATH'), [ $class: 'StringBinding', diff --git a/config.tf b/config.tf index b868cde1f1..8fa122ca25 100644 --- a/config.tf +++ b/config.tf @@ -192,18 +192,6 @@ You can download the pull secret from your Account overview page at [3]. EOF } -variable "tectonic_license_path" { - type = "string" - default = "" - - description = <"${CLUSTER_NAME}.yaml" config = yaml.load(f) config['name'] = '${CLUSTER_NAME}' config['baseDomain'] = '${DOMAIN}' - config['licensePath'] = '${LICENSE_PATH}' config['pullSecretPath'] = '${PULL_SECRET_PATH}' config['aws']['region'] = '${AWS_REGION}' config['aws']['master']['iamRoleName'] = 'tf-tectonic-master-node'