mirror of
https://github.com/opencontainers/image-spec.git
synced 2026-02-05 18:45:00 +01:00
558802debc
The main reason for this is to fix the links in the output docs, which currently all 404. This upgrades pandoc to 3.1, which isn't the latest, due to a regression in the relative links between markdown files. I pulled out the "header.html" logic, injected the title directly, and configured the build to embed images into the output doc for better portability (and the ability to generate dev docs). Signed-off-by: Brandon Mitchell <git@bmitch.net>
140 lines
4.6 KiB
Makefile
140 lines
4.6 KiB
Makefile
EPOCH_TEST_COMMIT ?= v0.2.0
|
|
|
|
DOCKER ?= $(shell command -v docker 2>/dev/null)
|
|
PANDOC ?= $(shell command -v pandoc 2>/dev/null)
|
|
|
|
GOPATH:=$(shell go env GOPATH)
|
|
|
|
OUTPUT_DIRNAME ?= output
|
|
DOC_FILENAME ?= oci-image-spec
|
|
|
|
# pinned to a 3.1 release due to a regression, see https://github.com/jgm/pandoc/issues/10952 before upgrading
|
|
PANDOC_CONTAINER ?= docker.io/pandoc/latex:3.1@sha256:1cf54d9214a9b52de2f58cf5895cc596a5960711a54d7938dc72f2b23473caf3
|
|
ifeq "$(strip $(PANDOC))" ''
|
|
ifneq "$(strip $(DOCKER))" ''
|
|
PANDOC = $(DOCKER) run \
|
|
--rm \
|
|
-v "$(CURDIR)/:/workdir/:ro" \
|
|
-v "$(CURDIR)/$(OUTPUT_DIRNAME)/:/workdir/$(OUTPUT_DIRNAME)/" \
|
|
-u "$(shell id -u):$(shell id -g)" \
|
|
--workdir /workdir \
|
|
$(PANDOC_CONTAINER)
|
|
endif
|
|
endif
|
|
|
|
# These docs are in an order that determines how they show up in the PDF/HTML docs.
|
|
DOC_FILES := \
|
|
spec.md \
|
|
media-types.md \
|
|
descriptor.md \
|
|
image-layout.md \
|
|
manifest.md \
|
|
image-index.md \
|
|
layer.md \
|
|
config.md \
|
|
annotations.md \
|
|
conversion.md \
|
|
considerations.md \
|
|
implementations.md
|
|
|
|
FIGURE_FILES := \
|
|
img/media-types.png
|
|
|
|
MARKDOWN_LINT_VER?=v0.8.1
|
|
|
|
TOOLS := gitvalidation
|
|
|
|
default: check-license lint test
|
|
|
|
.PHONY: fmt
|
|
fmt: ## format the json with indentation
|
|
for i in schema/*.json ; do jq --indent 2 -M . "$${i}" > xx && cat xx > "$${i}" && rm xx ; done
|
|
|
|
.PHONY: docs
|
|
docs: $(OUTPUT_DIRNAME)/$(DOC_FILENAME).pdf $(OUTPUT_DIRNAME)/$(DOC_FILENAME).html ## generate a PDF/HTML version of the OCI image specification
|
|
|
|
ifeq "$(strip $(PANDOC))" ''
|
|
$(OUTPUT_DIRNAME)/$(DOC_FILENAME).%: $(DOC_FILES) $(FIGURE_FILES)
|
|
$(error cannot build $@ without either pandoc or docker)
|
|
else
|
|
$(OUTPUT_DIRNAME)/$(DOC_FILENAME).pdf: $(DOC_FILES) $(FIGURE_FILES)
|
|
@mkdir -p $(OUTPUT_DIRNAME)/ && \
|
|
version="v$$(go run .tool/curver.go)" && \
|
|
$(PANDOC) -f gfm -t latex -o $@ --metadata "title=image-spec $${version}" --standalone --file-scope --pdf-engine=xelatex -V geometry:margin=0.5in,bottom=0.8in -V block-headings $(DOC_FILES)
|
|
ls -sh $@
|
|
|
|
$(OUTPUT_DIRNAME)/$(DOC_FILENAME).html: $(DOC_FILES) $(FIGURE_FILES)
|
|
@mkdir -p $(OUTPUT_DIRNAME)/ && \
|
|
version="v$$(go run .tool/curver.go)" && \
|
|
$(PANDOC) -f gfm -t html5 -o $@ --metadata "title=image-spec $${version}" --standalone --file-scope --embed-resources -V "maxwidth:95%" $(DOC_FILES)
|
|
ls -sh $@
|
|
endif
|
|
|
|
.PHONY: validate-examples
|
|
validate-examples: schema/schema.go ## validate examples in the specification markdown files
|
|
cd schema && go test -run TestValidate .
|
|
|
|
.PHONY: check-license
|
|
check-license: ## check license headers in source files
|
|
@echo "checking license headers"
|
|
@./.tool/check-license
|
|
|
|
.PHONY: lint
|
|
|
|
.PHONY: lint
|
|
lint: lint-go lint-md ## Run all linters
|
|
|
|
.PHONY: lint-go
|
|
lint-go: .install.lint ## lint check of Go files using golangci-lint
|
|
@echo "checking Go lint"
|
|
@GO111MODULE=on $(GOPATH)/bin/golangci-lint run
|
|
@[ "$$BUILD_SPEC_MODULE_ONLY" = true ] || { cd schema && GO111MODULE=on $(GOPATH)/bin/golangci-lint run; }
|
|
|
|
.PHONY: lint-md
|
|
lint-md: ## Run linting for markdown
|
|
docker run --rm -v "$(PWD):/workdir:ro" docker.io/davidanson/markdownlint-cli2:$(MARKDOWN_LINT_VER) \
|
|
"**/*.md" "#vendor"
|
|
|
|
.PHONY: test
|
|
test: ## run the unit tests
|
|
go test -race -cover ./...
|
|
[ "$$BUILD_SPEC_MODULE_ONLY" = true ] || { cd schema && go test -race -cover ./...; }
|
|
|
|
img/%.png: img/%.dot ## generate PNG from dot file
|
|
dot -Tpng $^ > $@
|
|
|
|
# When this is running in GitHub, it will only check the commit range
|
|
.PHONY: .gitvalidation
|
|
.gitvalidation:
|
|
@which git-validation > /dev/null 2>/dev/null || (echo "ERROR: git-validation not found. Consider 'make install.tools' target" && false)
|
|
ifdef GITHUB_SHA
|
|
$(GOPATH)/bin/git-validation -q -run DCO,short-subject,dangling-whitespace -range $(GITHUB_SHA)..HEAD
|
|
else
|
|
$(GOPATH)/bin/git-validation -v -run DCO,short-subject,dangling-whitespace -range $(EPOCH_TEST_COMMIT)..HEAD
|
|
endif
|
|
|
|
.PHONY: .install.tools
|
|
install.tools: $(TOOLS:%=.install.%)
|
|
|
|
.PHONY: .install.lint
|
|
.install.lint:
|
|
case "$$(go env GOVERSION)" in \
|
|
go1.18.*) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.47.3;; \
|
|
go1.19.*) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.1;; \
|
|
go1.20.*) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.2;; \
|
|
go1.21.*) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.59.1;; \
|
|
*) go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest;; \
|
|
esac
|
|
|
|
.PHONY: .install.gitvalidation
|
|
.install.gitvalidation:
|
|
go install github.com/vbatts/git-validation@latest
|
|
|
|
.PHONY: clean
|
|
clean: ## clean all generated and compiled artifacts
|
|
rm -rf *~ $(OUTPUT_DIRNAME) header.html
|
|
|
|
.PHONY: help
|
|
help: # Display help
|
|
@awk -F ':|##' '/^[^\t].+?:.*?##/ { printf "\033[36m%-30s\033[0m %s\n", $$1, $$NF }' $(MAKEFILE_LIST)
|