mirror of
https://gerrit.ovirt.org/vdsm
synced 2026-02-05 12:46:23 +01:00
c81f6ea536
Nir prefers it like that, I don't mind. perl -0777 -i.original -pe 's/#\nfrom __future__/#\n\nfrom __future__/' `git ls-files \*.py` is easy. Change-Id: Iad69872e6ae1de62e7f2081da44bb92963eb358c Signed-off-by: Dan Kenigsberg <danken@redhat.com>
144 lines
4.8 KiB
Python
144 lines
4.8 KiB
Python
#
|
|
# Copyright 2015 Red Hat, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
#
|
|
# Refer to the README and COPYING files for full details of the license
|
|
#
|
|
|
|
from __future__ import absolute_import
|
|
from __future__ import division
|
|
|
|
from vdsm.common import response
|
|
from vdsm.common.define import doneCode
|
|
from vdsm.common.define import errCode
|
|
|
|
from testlib import permutations, expandPermutations
|
|
from testlib import VdsmTestCase as TestCaseBase
|
|
|
|
|
|
@expandPermutations
|
|
class ResponseTests(TestCaseBase):
|
|
|
|
def test_error(self):
|
|
NAME = 'noVM' # no special meaning, any error is fine
|
|
res = response.error(NAME)
|
|
|
|
template = errCode[NAME]
|
|
self.assertEqual(res["status"]["code"], template["status"]["code"])
|
|
self.assertEqual(res["status"]["message"],
|
|
template["status"]["message"])
|
|
|
|
def test_error_with_message(self):
|
|
NAME = 'noVM' # no special meaning, any error is fine
|
|
MESSAGE = 'we want a specific message here'
|
|
res = response.error(NAME, MESSAGE)
|
|
|
|
template = errCode[NAME]
|
|
self.assertEqual(res["status"]["code"], template["status"]["code"])
|
|
self.assertEqual(res["status"]["message"], MESSAGE)
|
|
|
|
def test_success(self):
|
|
res = response.success()
|
|
|
|
self.assertEqual(res, {"status": doneCode})
|
|
|
|
def test_success_with_message(self):
|
|
MESSAGE = "the message was overwritten"
|
|
res = response.success(message=MESSAGE)
|
|
|
|
template = doneCode
|
|
self.assertEqual(res["status"]["code"], template["code"])
|
|
self.assertEqual(res["status"]["message"], MESSAGE)
|
|
|
|
def test_success_with_args(self):
|
|
res = response.success(a=1, b=2)
|
|
|
|
self.assertEqual(res, {"status": doneCode, "a": 1, "b": 2})
|
|
|
|
@permutations([[{'answer': 42}], [{'fooList': ['bar', 'baz']}]])
|
|
def test_success_with_extra_args(self, args):
|
|
res = response.success(**args)
|
|
self.assertEqual(res['status']['code'], 0)
|
|
self.assertEqual(res['status']['message'], 'Done')
|
|
for key in args:
|
|
self.assertEqual(res[key], args[key])
|
|
|
|
def test_is_error(self):
|
|
NAME = 'noVM' # no special meaning, any error is fine
|
|
self.assertTrue(response.is_error(response.error(NAME)))
|
|
|
|
@permutations((
|
|
('noVM', 'noVM'),
|
|
('hookError', 'hookError'),
|
|
('noVM', 'hookError')
|
|
))
|
|
def test_is_specific_error(self, actual_err, expected_err):
|
|
match = actual_err == expected_err
|
|
self.assertEqual(match, response.is_error(response.error(actual_err),
|
|
err=expected_err))
|
|
|
|
def test_malformed_empty(self):
|
|
self.assertRaises(response.MalformedResponse,
|
|
response.is_error,
|
|
{})
|
|
|
|
def test_malformed_missing_code(self):
|
|
self.assertRaises(response.MalformedResponse,
|
|
response.is_error,
|
|
{'status': {}})
|
|
|
|
@permutations([
|
|
# res
|
|
[response.success()],
|
|
[response.success(foo='bar', a=42)],
|
|
[response.error('noVM')],
|
|
[{'status': {'code': '0', 'message': 'ok', 'foo': 'bar'}}],
|
|
])
|
|
def test_is_valid(self, res):
|
|
self.assertTrue(response.is_valid(res))
|
|
|
|
@permutations([
|
|
# res
|
|
[('foo', 'bar')],
|
|
[['foo', 'bar']],
|
|
[{'code': 42}],
|
|
[{'message': 'foobar'}],
|
|
[{'success': True}],
|
|
])
|
|
def test_is_not_valid(self, res):
|
|
self.assertFalse(response.is_valid(res))
|
|
|
|
def test_malformed_exception_contains_response(self):
|
|
bad_res = {}
|
|
try:
|
|
response.is_error(bad_res)
|
|
except response.MalformedResponse as ex:
|
|
self.assertEqual(ex.response, bad_res)
|
|
|
|
def test_malformed_exception_str(self):
|
|
bad_res = {}
|
|
try:
|
|
response.is_error(bad_res)
|
|
except response.MalformedResponse as ex:
|
|
self.assertEqual(str(ex),
|
|
"Missing required key in {}")
|
|
|
|
# TODO: drop this once we get rid of errCode
|
|
def test_legacy_error_code(self):
|
|
for code, res in errCode.items():
|
|
self.assertTrue(response.is_error(res))
|
|
self.assertEqual(res, response.error(code))
|