gluster/glusterfs
1
0
Fork 0
mirror of https://github.com/gluster/glusterfs.git synced 2026-02-05 15:48:40 +01:00
Code Issues Releases Wiki Activity

cluster/afr: Delay post-op for fsync

Browse Source 
Problem:
AFR doesn't delay post-op for fsync fop. For fsync heavy workloads
this leads to un-necessary fxattrop/finodelk for every fsync leading
to bad performance.

Fix:
Have delayed post-op for fsync. Add special flag in xdata to indicate
that afr shouldn't delay post-op in cases where either the
process will terminate or graph-switch would happen. Otherwise it leads
to un-necessary heals when the graph-switch/process-termination
happens before delayed-post-op completes.

Fixes: #1253
Change-Id: I531940d13269a111c49e0510d49514dc169f4577
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
This commit is contained in:
Pranith Kumar K
2020-05-29 14:24:53 +05:30
committed by Pranith Kumar Karampuri
parent a113d93621
commit af89d9e623
9 changed files with 240 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
api/src/glfs-resolve.c
View File

@@ -728,6 +728,7 @@ glfs_migrate_fd_safe(struct glfs *fs, xlator_t *newsubvol, fd_t *oldfd)
0,
};
char uuid1[64];
dict_t *xdata = NULL;
oldinode = oldfd->inode;
oldsubvol = oldinode->table->xl;
@@ -736,7 +737,16 @@ glfs_migrate_fd_safe(struct glfs *fs, xlator_t *newsubvol, fd_t *oldfd)
return fd_ref(oldfd);
if (!oldsubvol->switched) {
ret = syncop_fsync(oldsubvol, oldfd, 0, NULL, NULL, NULL, NULL);
xdata = dict_new();
if (!xdata || dict_set_int8(xdata, "last-fsync", 1)) {
gf_smsg(fs->volname, GF_LOG_WARNING, ENOMEM, API_MSG_FSYNC_FAILED,
"err=%s", "last-fsync set failed", "gfid=%s",
uuid_utoa_r(oldfd->inode->gfid, uuid1), "subvol=%s",
graphid_str(oldsubvol), "id=%d", oldsubvol->graph->id,
NULL);
}
ret = syncop_fsync(oldsubvol, oldfd, 0, NULL, NULL, xdata, NULL);
DECODE_SYNCOP_ERR(ret);
if (ret) {
gf_smsg(fs->volname, GF_LOG_WARNING, errno, API_MSG_FSYNC_FAILED,
@@ -816,6 +826,9 @@ out:
newfd = NULL;
}
if (xdata)
dict_unref(xdata);
return newfd;
}