From 85692c74112ccfae50009b84c8d7fbdc7bdc5152 Mon Sep 17 00:00:00 2001 From: Oshank Kumar Date: Thu, 2 Aug 2018 17:03:37 +0530 Subject: [PATCH] Valiate Last Error Response in failure function of GlusterCli If last Error Response is nil, then calling failure function will cause segmentation fault error Fixes #1115 Signed-off-by: Oshank Kumar --- glustercli/cmd/common.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/glustercli/cmd/common.go b/glustercli/cmd/common.go index 78f9aed4..fa0add41 100644 --- a/glustercli/cmd/common.go +++ b/glustercli/cmd/common.go @@ -56,9 +56,14 @@ func failure(msg string, err error, errcode int) { w.WriteString(msg + "\n") - if err != nil { - resp := client.LastErrorResponse() + resp := client.LastErrorResponse() + if resp == nil && err != nil { + fmt.Fprintln(w, err) + os.Exit(errcode) + } + + if err != nil { w.WriteString("\nResponse headers:\n") for k, v := range resp.Header { if strings.HasSuffix(k, "-Id") {