* change type to url, remove operator check and add semantic validation
* update conversion config
* trigger ci
* change url to pointer and regenerate files
* add empty string test case
* update test case
* update url
* update back url validation in operator
* trigger ci
* remove url validation from operator
* trigger ci
* add exclusion of empty string
* fix typo
* add e2e test case for url
* alertmanager: update optional var type to *string and add minlength validation
to have stricter validation
* validation: update url validation
to use the new method validatURLPtr
* alertmanager: change href to URL and add validation
to cover more cases
* alertmanager: update type
to add more validation
* validation: fix issue
wrong type
* Change to deref for shorter implementation
* alertmanager: fix typo
to address the variable type issue
* validation: update url validation
to use the new method
This commit removes the `dispatchStartDelay` field from the Alertmanager
CRD and uses instead the `minReadySeconds` value as the default
duration to delay the first flush of aggregation groups.
When Kubernetes performs pod updates (due to spec updates or pod
eviction),`minReadySeconds` defines how long a statefulset's pod should
be ready before kube-controller-manager can proceed with the next pod
update. The main use case of `minReadySeconds` is to ensure that
Prometheus has resent all alerts before updating the next pod hence it
makes sense for Alertmanager to wait the same amount of time before
sending alert notifications. Users who want to use another value for
`--dispatch.start-delay` can customize it using the
`.spec.additionalArgs` field.
The removal of `dispatchStartDelay` is possible because the field hasn't
been made available in any public release.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
* update to url type
* update generated files
* update e2e test cases
* trigger ci
* update url validation method
* trigger ci
* validation: update validation method
make the url validation shorter
This commit introduces a new `updateStrategy` field for
statefulset-based workloads (Prometheus, PrometheusAgent, Alertmanager
and ThanosRuler). While for now, there's a 1:1 mapping with StatefulSet
strategies, it paves the way to the introduction of custom strategies
which may be required to streamline operations in case of broken updates
(similar to the scenario explained in
https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#forced-rollback).
Closes #5435
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
This commit introduces a new `podManagementPolicy` field for
statefulset-based workloads (Prometheus, PrometheusAgent, Alertmanager
and ThanosRuler). While the default will still be `Parallel`, users have
expressed the need to use `OrderedReady` in specific situations.
Closes #2753
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
This commit adds the following arguments in jsonnet + default manifests:
* `--watch-referenced-objects-in-all-namespaces=true`
* `--disable-unmanaged-prometheus-configuration=true`
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Pull requests #7867 and #7953 switched from the core Events API to the
new `events.k8s.io` API group but we forgot to update the RBAC
permissions of the prometheus-operator Service Account and the
verification which happens during the startup.
Closes #8076
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
This commit also clarifies the meaning of the 'url' field in the Prober
spec which isn't a "true" URL.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
