coreos/prometheus-operator
1
0
Fork 0
mirror of https://github.com/coreos/prometheus-operator.git synced 2026-02-05 06:45:27 +01:00
Code Issues Releases Wiki Activity

chore: Refactor OVHCloudSDConfig (#7238)

Browse Source 
Signed-off-by: slashexx <dhruvpuri.35@gmail.com>
This commit is contained in:
Dhruv
2025-01-31 09:52:22 +05:30
committed by GitHub
parent b916b01e44
commit 3643b5d93e
5 changed files with 197 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

191
test/e2e/scrapeconfig_test.go
View File

@@ -619,6 +619,9 @@ func testScrapeConfigCRDValidations(t *testing.T) {
t.Run("AzureSD", func(t *testing.T) {
runScrapeConfigCRDValidation(t, AzureSDTestCases)
})
t.Run("OVHCloudSD", func(t *testing.T) {
runScrapeConfigCRDValidation(t, OVHCloudSDTestCases)
})
}
func runScrapeConfigCRDValidation(t *testing.T, testCases []scrapeCRDTestCase) {
@@ -2479,3 +2482,191 @@ var AzureSDTestCases = []scrapeCRDTestCase{
expectedError: true,
},
}
var OVHCloudSDTestCases = []scrapeCRDTestCase{
{
name: "Valid OVHCloudSDConfig",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationKey: "valid-app-key",
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
Service: monitoringv1alpha1.OVHServiceDedicatedServer,
Endpoint: ptr.To("https://api.ovh.com/endpoint"),
RefreshInterval: ptr.To(monitoringv1.Duration("30s")),
},
},
},
expectedError: false,
},
{
name: "Valid OVHCloudSDConfig without optional fields",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationKey: "valid-app-key",
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
Service: monitoringv1alpha1.OVHServiceDedicatedServer,
},
},
},
expectedError: false,
},
{
name: "Valid ApplicationKey",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationKey: "valid-app-key",
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
Service: monitoringv1alpha1.OVHServiceVPS,
},
},
},
expectedError: false,
},
{
name: "Empty ApplicationKey",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationKey: "",
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
Service: monitoringv1alpha1.OVHServiceVPS,
},
},
},
expectedError: true,
},
{
name: "Missing ApplicationKey",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
Service: monitoringv1alpha1.OVHServiceVPS,
},
},
},
expectedError: true,
},
{
name: "Valid Service field (VPS)",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationKey: "valid-app-key",
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
Service: monitoringv1alpha1.OVHServiceVPS,
},
},
},
expectedError: false,
},
{
name: "Valid Service field (DedicatedServer)",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationKey: "valid-app-key",
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
Service: monitoringv1alpha1.OVHServiceDedicatedServer,
},
},
},
expectedError: false,
},
{
name: "Invalid Service type",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationKey: "valid-app-key",
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
Service: "InvalidService",
},
},
},
expectedError: true,
},
{
name: "Missing Service field",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationKey: "valid-app-key",
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
},
},
},
expectedError: true,
},
{
name: "Valid ConsumerKey",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationKey: "valid-app-key",
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
Service: monitoringv1alpha1.OVHServiceVPS,
},
},
},
expectedError: false,
},
{
name: "Empty Endpoint",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationKey: "valid-app-key",
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
Service: monitoringv1alpha1.OVHServiceVPS,
Endpoint: ptr.To(""),
},
},
},
expectedError: true,
},
{
name: "Empty RefreshInterval",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationKey: "valid-app-key",
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
Service: monitoringv1alpha1.OVHServiceVPS,
RefreshInterval: ptr.To(monitoringv1.Duration("")),
},
},
},
expectedError: false,
},
{
name: "Valid RefreshInterval",
scrapeConfigSpec: monitoringv1alpha1.ScrapeConfigSpec{
OVHCloudSDConfigs: []monitoringv1alpha1.OVHCloudSDConfig{
{
ApplicationKey: "valid-app-key",
ApplicationSecret: v1.SecretKeySelector{Key: "valid-secret-key"},
ConsumerKey: v1.SecretKeySelector{Key: "valid-consumer-key"},
Service: monitoringv1alpha1.OVHServiceVPS,
RefreshInterval: ptr.To(monitoringv1.Duration("30s")),
},
},
},
expectedError: false,
},
}